From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7289030248044167168 X-Received: by 2002:a05:651c:204:b0:2c5:22c0:582c with SMTP id y4-20020a05651c020400b002c522c0582cmr12930143ljn.11.1698328981151; Thu, 26 Oct 2023 07:03:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:be9e:0:b0:2b9:5450:e122 with SMTP id a30-20020a2ebe9e000000b002b95450e122ls27073ljr.0.-pod-prod-03-eu; Thu, 26 Oct 2023 07:02:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVYQvlWM5cL53DtAJDo5W3B8thY9ZopVvsQJOmqlojU5+kLYR6LPZrO5+4o0PPxesWOQNP X-Received: by 2002:a05:651c:c85:b0:2bc:dcdb:b5dc with SMTP id bz5-20020a05651c0c8500b002bcdcdbb5dcmr14897458ljb.39.1698328978679; Thu, 26 Oct 2023 07:02:58 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1698328978; cv=pass; d=google.com; s=arc-20160816; b=HwI3trZ2v6bkkbP9PiSOPNnhexKgVhX2DvCmllOoTsFLAI6AOAPz4wd5Gb9ABHYd5J vE/LvMihboqpWof/Je1VIzT9GJcjfy59xFajgLWbdI1foW2/QiswTFyn3L0i3j23QQ5G +lOjQdYjq58TLzpe9qNJ/VQcWfBxrGXl5lH8kWHo0h/y4Fe60rJdpMF1EbFGutVyxZg+ luGboAOzPmGBDWqimjrN2AkHPN0WbY/q949l5QG1mDA70Bcb6yTgccSheINLrkoVknXa gwzKZlzJL3UgWV82esyvII6qF921gJi9SEz9RHij1Dm6U8LMrIZfR3IQ2miOG2ymptNZ HMiw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :cc:to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=JRwjFWSmHrmqThSBQp59JaI3h4wPrSmweU/bXiCGT1A=; fh=2+iSbdVfk3+EJ9rXATO15dxMFjGGqnPOyXRcZSx+Vl8=; b=bW2w7zbxb6Sr7Z1WcMF6IgyZmNtWYcSEm5CpbB+tWKWGEo4GvdMUJIK0NUkinTzCEz Mf5DUpbau2Hr8SBwx0yiva4n2yNYSx4NODd7UCkEqVv8irW714sYpwubS7f+vxqy62xx pyRHQkRDceNPCs/aVbFPFJCgToYulLEJTTKhAajsws7MoDV3M+a4tSLB8xSmdT9ScQqi bFOSCzj5rJ8emU9GH7jOUPsF06JOCBwGtmwDex4l3HRzyGBV2mRFg1O/zxbnEUiCkw7X +PE6v3GsBUU/HdHfnUFiSAfjjTlHF1JQB0N45KashUfl5Yyb5XeP4nu9l7kMMKpa3g3z ujrA== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="lST/wS9+"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe12::608 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on20608.outbound.protection.outlook.com. [2a01:111:f400:fe12::608]) by gmr-mx.google.com with ESMTPS id q26-20020a2e875a000000b002c50578f98fsi641527ljj.8.2023.10.26.07.02.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Oct 2023 07:02:58 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe12::608 as permitted sender) client-ip=2a01:111:f400:fe12::608; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="lST/wS9+"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe12::608 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=la5C9A5048sBPklARvjdIcvR3y2VON++79VBb4MvykRI2WhxB+e/CUinbK81DdtUcvTSbXiqv1+buC+jvtgKbi2Ci51D0K1iT+G49BLEYb+nZIWI+mxrKZaOrVC4q7NithDw6cr8kuiuhm+lca0P7UWnkeLBbohScaBLxp+sxbqkqP2dBxE2Ve0bfoj31uuKOZSRaXirJhtCkqCng4kdcFBYu+9RYhm/LA6VIPpFmw/e23Y4FY3JS1OrDZs5OYgSKbEvnHxKqDTN0S7n5qzBHS2NMTIyHjiBQFY9tc8Q59r6rv+uMIlrozSjUV89YDpyOiMUrAwv6ITTomJEeU1AEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JRwjFWSmHrmqThSBQp59JaI3h4wPrSmweU/bXiCGT1A=; b=atPucNrAFEmIkhmIRd90dUiGCGqPsTGkBFP+kxIuM9EQnJeqiFdDrMuOgFhgs3RaNNJq6p7sScOeSHIwKLK8QFeBQ099tTvJOB6SETvr1oJWGbpsVoF55FlSlojHkFT15mEKD5WlucIZ6SN2gc4wxWk8vUkwLVCZT0+dHk5BEeo7BpmG3AFD+knvpdmGfJ8A6UdW7PJXJzt7f/gVL8Y4Ej+JVKvuBg7CZKh4K0byEDg/TkAyqDlFcxJMC8QqGnYTnLiX/+wZC1kn500k7k6gkcAQNYFqJoaBC2LeQeaMkWMBXKmmQdtHWM8MbFuMy+6SdOplhvUFxnBF6BY+eUfLOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JRwjFWSmHrmqThSBQp59JaI3h4wPrSmweU/bXiCGT1A=; b=lST/wS9+xeyWI/ga9IWhPH96B7YL0JxIJ5U31LwB7raIh7lnqdsJBo9vKppq5fI6ow5DxOLxaxSM+RzUf4J2IOWybVzjWlayVNTgiwkz/89ZPdDSqCAgeNflYD4g3iQqMxEb4ZZ/UZ4iXXOOzyfj+K450mZV8qaAryE2ac9FxFCx508VbblaWEhXRF++PhUgTtHzdghbulzr8ejFqoReIKWxzOFcZzsK38jFu7dxNmYq7nzkrI4CGj9kgY/DQn6zmBZrz74GZolZKhSWlHONrFONvp+8flLCtsGm/RiV7xvLxvKNMrquOH9FmUpDzLTgCKVRfCX8zl6ZvWoKwbX3jg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by DB8PR10MB3564.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:136::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.19; Thu, 26 Oct 2023 14:02:57 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::ce06:5d24:9896:669c]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::ce06:5d24:9896:669c%6]) with mapi id 15.20.6907.032; Thu, 26 Oct 2023 14:02:57 +0000 Message-ID: Date: Thu, 26 Oct 2023 16:02:52 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dpkg-source: Drop -I filter Content-Language: en-US To: "MOESSBAUER, Felix (T CED INW-CN)" , "isar-users@googlegroups.com" Cc: "amikan@ilbers.de" References: <8af8ae1e-c845-4900-b99b-3cb361c3968c@siemens.com> <3040766a-bb96-4aa1-ba4d-0c47b9721c79@siemens.com> <50dc03958e268d5367ccef29a41c2a1cfe891267.camel@siemens.com> From: Jan Kiszka In-Reply-To: <50dc03958e268d5367ccef29a41c2a1cfe891267.camel@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CH5P223CA0018.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:1f3::25) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|DB8PR10MB3564:EE_ X-MS-Office365-Filtering-Correlation-Id: b81a741a-86b3-433c-af19-08dbd62c416f X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KzkJ3yxU9300GTvcIQZQ+akFcTXYTcPsRdLRm5PGMtDEclORij5S3cRsdxGxyXiWw+1CvYnVS7st9r4aRjYOGfU0tgvwz9OV2+wZYLpa7FRkbQ/IDmJo9zU2cmlg2gAc6dDzMqsX7uDvJGOtLENsSDstpHADOyohAiwX7fF1olcO/dAnpmmJK/fpyiM24sGEVph06CTd2btIRc+GjprC4MTSJT2VIZ6P+dnYMyqTFRo0GQhFotyx84jEwBVlJhuTpA+aCel8d3OCE6Y/c8CYvXa4b5+7wwc6u8WIuB93ZGh3E9Rm3q7YGYur4Ti6wrOunuOFAJHv8xFZ7azh4XdXzeqeSnKJ5qh/psqKBKnNeO/0CBoMwQ1ZX2umXX1xyLJBapdQARQ8O6j3Nvm+czhj1Li8+nuhsfvlIRNnWvRi0SeHVQlPSjQ5gmLy2qFZ89+1E5Al+9LuznfZbiEJ6PEajWZVpacZRUaROuxsPVuBYKDgIpmNONyXa7Ii7Xjw2zoBAPQNVpzmZ1cX71PLcu1Yys45l1JKSxqK4GbrNjhj9iwNvW9lQ6qmNnCf8ZLkvVsV78FpRtkxcJCTeg+8PJkYX4mAhD0ggwEW160E5Iv1CSSfRkWvNxjz0Yw8ZcD/cGczohHMiAekdstCxr53t/80Pw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(346002)(366004)(136003)(396003)(376002)(230922051799003)(186009)(1800799009)(64100799003)(451199024)(31686004)(53546011)(6506007)(6512007)(6666004)(4001150100001)(8676002)(8936002)(41300700001)(36756003)(5660300002)(2906002)(4326008)(44832011)(966005)(86362001)(66556008)(478600001)(6486002)(31696002)(2616005)(66946007)(316002)(66476007)(110136005)(38100700002)(26005)(82960400001)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWZhN1dyZXlLSllRSC9BTXVqaHBlak9COWM2SFRRd3NoM094OTl1U3d2T01M?= =?utf-8?B?Zm9idGljUy8vbkJHZUkwUTJ5MHQ2ZkppL3dqRkxUV3lLQThGaUQ2UlZ6RGRJ?= =?utf-8?B?bHhqRFpYTHIrVjJDd2IyRm1KTmwvSDRFa2ozVHcwNVhjUUd3RGZLUzRMR2VT?= =?utf-8?B?aURaQk85WlBWK3F4V0dKWGpUOXJoMmEyNHNZZy93Nkp4S3N5bE9ETXBtbzF3?= =?utf-8?B?Sjk3bittY3ZUZ2tSMTZEenNJdml6Uy9rREZibndYN1F3bjFUMGxPWTRwc0Fa?= =?utf-8?B?N3dEL2FVWk8yTmlVaURSSFYraFRJQmdmWDBaR3hWV29tdnBlWmNmMVMwUTBW?= =?utf-8?B?WGs0eE5HR3UxbHBhV0VFTzM3b2JMaHlZTm95QTA3UGgwQzNhSnZFdStldm1z?= =?utf-8?B?NWdsYlBESXJqU0hDeXFhMVNFcmsyMjA3Vmg5R3Q5eUh0U1BzTVZEVThnM2or?= =?utf-8?B?N2V5b2kwVnNBR09kYUdRajJHcmEvN3ZBK1ErQW13ZFptck12ZGYxZHdCQjkr?= =?utf-8?B?aE5KSkVtV3kraEs5Znp6RlQ0UXdhVjhzRkYvVkQrMndtRndvcVhXN1pCRERN?= =?utf-8?B?b29mR09SaDVXS3ZMbDN6OVAybkd0SmQ5N0tBQlUvQmFBRjdIMnhDU0ZEQ0Jo?= =?utf-8?B?R29xSHpFM0NGV0tidzdaaHY5Q202TXBvU2JVK2xmVzhPS0dwZk9OMmZvQW13?= =?utf-8?B?U0llbXFXR1pZTDZrZUNuRzVLcVhuUDZXdEdHdGkrZWZodlREbnU2NlpHYVR5?= =?utf-8?B?TXBYWkVYR3lLK1JnK29HdHdRZGttK25DY1BoSlpETzhsVittTjIwZWxwMTJi?= =?utf-8?B?UmcxTGl1UG5MV2QxUVp0T3NpY2JVK1M4Q0ZFc3UwbjBYVERZaVpZZHJSdTdZ?= =?utf-8?B?QU9KOEtBb2Yvd21zSFhSN0hrSmkxK01pdVVxeWM3d3hnLzBkODZWcTQrb0lW?= =?utf-8?B?K1pvWmF6LzEwZ2NVcUdhbDk0bmlTelM0UWFUVlphamNvRVg4blhmWitBRFNK?= =?utf-8?B?MzJUU0Nab1FxeHltdnZpdGFCNHBYV3NDN0ZYdzFham9JcHNvUTdhcEtlRE9V?= =?utf-8?B?QVBwRkUwT0RsMTV5YjBCemJ6WURaRzRRM1VhNTRtQW5wNVpicmlrVDVoWEZF?= =?utf-8?B?WFZ2UTJUR3h1OU0rM2JXbDBrc0RYOXBPWFMza2EvR3U3MVh6L2p5MW95d3Iz?= =?utf-8?B?VjdFbUlGVEdYRUE0SFIxWVBHUERROE5scmVxdUcvNzVKT0xkR2IrN1lZU3Vn?= =?utf-8?B?T0ZxZkpZdEJuMktJdkR1SW9PTFVpQ3NGVzkzT2c3MUNjLy9rZTZjb1JSUkdH?= =?utf-8?B?M0VJLzFqemk4anBCamNPK3Fvc1dYRGZkU0Y3OXM4a2R6WUxGM29sTU9UMzFY?= =?utf-8?B?SFJha3pjOEx3VDZHUEtkeTdSNU5QdnQxRnV4TzZaUmRYRnFjZFU4NXAzRS9F?= =?utf-8?B?a3hKcENvM0FRM2FkQXlWRU92bVdNeEhDNFUybG0rUTNKNjB5QmJSSGF3aDk1?= =?utf-8?B?akExcHZ1Um82SjdoS3ZtcG5PYTFTbG14dGJaSGZUWEUyTWpCcUhZMDZZd29p?= =?utf-8?B?Mkc0SEVKRHB4VnIzWXVNbk5BOUREdWk4LzlQWjZhQk4vMktFd3MvRmNoNTdV?= =?utf-8?B?QjNFSWlIaFdSME1VNUQzOGxDMkkxZ2FkVTRBa216RVp0Mk1XOFFlYVIrbjNB?= =?utf-8?B?cTI4TWJxempoZzNacGxJdysxR2ZBSnZkK05OcUZXRU1DRUhGWlBGUDFpaWEw?= =?utf-8?B?V0FuUU1OK2ZLNHlMbC9wdytEK1J3YmhLWXBIeE45SUVVNlkxLzhxK3owUFdC?= =?utf-8?B?bkpwYnpiZE1EL00wQWFBbko3cDBaVDVla2xMTGU4aEp5WXE3Wngyak05dk1r?= =?utf-8?B?WTVzRklETVhtQUR3WGo1bkJYaDdBSmpnMGJiNEJIV1lQRTNjZ3c2Z05RWG9N?= =?utf-8?B?KzEwMzN2R1hWandYS2xQZFQ5MWJZZjgyS2ZrNGNUUU9reWczYmMzcnBJR2RB?= =?utf-8?B?ZU5HQ0MxRzJUWVVaaWRPL0VPNDJqNmc5cWxSL05PNHlERWc2NGFOdTlzTWdq?= =?utf-8?B?eFlveEpiMUF3Nkx0REd4NFZKSlZHUGt2eHdSSjJWendYOE51NUpHWStUTEIy?= =?utf-8?B?TkhSc0JBWkZoMmQwL2RpdXN5NSt5ODd3UEZpMlBpMHpURTNPekszTVcrYzNJ?= =?utf-8?B?TGc9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: b81a741a-86b3-433c-af19-08dbd62c416f X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 14:02:56.9922 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q2+3uYJ9sRiFqeDrSUoMfFoBRBBNsNryV9TokrhSCObJlmW6YkuNMAGl+Blz8kO9NwyMnzr7Nn5dZleDL9foWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB3564 X-TUID: 5Gsk/jjHP6rh On 26.10.23 12:21, MOESSBAUER, Felix (T CED INW-CN) wrote: > On Thu, 2023-10-12 at 14:27 +0200, 'Jan Kiszka' via isar-users wrote: >> On 12.10.23 13:19, 'Jan Kiszka' via isar-users wrote: >>> From: Jan Kiszka >>> >>> This is a regression of 38b832ad8248 which added this while >>> factoring >>> out this step. However, some packages may break over this, e.g. the >>> edk2-standalonemm-rpmb recipe in isar-cip-core. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> meta/classes/dpkg-source.bbclass | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/meta/classes/dpkg-source.bbclass b/meta/classes/dpkg- >>> source.bbclass >>> index 1f4f8164..a86b4635 100644 >>> --- a/meta/classes/dpkg-source.bbclass >>> +++ b/meta/classes/dpkg-source.bbclass >>> @@ -12,7 +12,7 @@ do_dpkg_source() { >>> if [ ! -z "${SOURCE_DATE_EPOCH}" ]; then >>> export SOURCE_DATE_EPOCH="${SOURCE_DATE_EPOCH}" >>> fi >>> - sh -c "cd ${WORKDIR}; dpkg-source -I -b ${PPS}" >>> + sh -c "cd ${WORKDIR}; dpkg-source -b ${PPS}" >>> } >>> addtask dpkg_source after do_prepare_build before do_dpkg_build >>> >> >> That said, we can also think about re-introducing it, but it would >> need >> some control in recipe hands. Would be work on top in any case. > > There are more things that break with the original patch: > > First, we do not generate a debian/source/format, which defaults to 1.0 > which is an ancient version. Second, when setting this correctly to 3.0 > (native), we cannot include any non soversioned binaries into the > source archive (--include-binaries does not work for native packages). > This unfortunately breaks many packages at our side containing > proprietary stuff (like GPU drivers). > Doesn't this pattern help here? https://gitlab.com/cip-project/cip-core/isar-cip-core/-/commit/d6ebec910bd65b18d0a33abbcf7b57e1ffb8454d Jan -- Siemens AG, Technology Linux Expert Center