From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6524973730788016128 X-Received: by 10.80.200.202 with SMTP id k10mr8761310edh.10.1520605381532; Fri, 09 Mar 2018 06:23:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.80.173.41 with SMTP id y38ls2328855edc.2.gmail; Fri, 09 Mar 2018 06:23:00 -0800 (PST) X-Google-Smtp-Source: AG47ELvsXpL4+A18wcgt5+DJMZ3DefDnusTzr6WtI56/hYkuzD/ZEGG4TmmWMU9zhgnaB3emdnBX X-Received: by 10.80.244.2 with SMTP id r2mr7367719edm.2.1520605380837; Fri, 09 Mar 2018 06:23:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520605380; cv=none; d=google.com; s=arc-20160816; b=s6nx/uJ0EJ5u3BljebNuPeNm+9LXgLWweNqAaVrV5DFxg+TyPwl+WtL2qaKeYPmhyS Id5jBdnLO33kdqoKTa6xXlMF1YkxXGj3y8nbXNb12YIzLHRXBfz+NgKRZDY/P4V7WmiA xUriYMXxA7z5UX2CNXVfb6IEqQbdnqvb6aX7dvLzzctPqpYnP9exnCFwqSfFGPhY6+pM qMxRkB+lsWWfmCZTUZRb1d/dLzQhyQ3IOcYz/gnQcUCrieEW7BPxDoxZqs4AuDHSBlnJ 6a6q9WLjU7NwolGJlu9wfEb4VEUHHzKs/XWtDGbEVbP2FpgoO41exs5T3MbMne5Jjdff uwhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=pjp9sRQnOSncUDrW464CEtp8NmWv7Q8xn8zGLfGSleo=; b=fdLrywnF3WY0mU4BjOzZjOuLSRbbxMW2lT0FkwFvA/ATEZhtooVh+4oWl7gTfpm0Qw wNNLeO1rWON3QXlo6MOMWl8prHS0apW4VbnfGrukr6D9X383UlUcy5NV+m1/QLt9Ed2h dd3HKyn8YjceC4R4DH+DbDyFg1e+0GB5khcXq6WHU0CKHkt9ygspOdiCH4bqmUnrctZH UaKfOHMi19NpqYqERMcpKuulgcrERRi6LgHEniB12ZxexPXvEsHKqiWkBYm0TeqQQo9N XwEX2+514zqCkmkMdn0kirfILl/MiZaSwK6pu01V/9SSlgPkQB9c8HVAO5kX/czPrNTl +71A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id f24si63803edc.0.2018.03.09.06.23.00 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Mar 2018 06:23:00 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w29EN0sX008906 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Mar 2018 15:23:00 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w29EMxpg024846; Fri, 9 Mar 2018 15:22:59 +0100 Subject: Re: [PATCH v4 0/5] Debootstrap integration To: Claudius Heine , isar-users@googlegroups.com, Alexander Smirnov Cc: Claudius Heine References: <20180307164457.31933-1-claudius.heine.ext@siemens.com> <646a5e59-a6a1-4ccd-249a-1c1fa87f0d17@siemens.com> <34de0acc-e28b-d1be-2a02-6296849e7e0b@siemens.com> <16b13094-46e0-1c03-f60f-1df8f46e91b9@siemens.com> From: Jan Kiszka Message-ID: Date: Fri, 9 Mar 2018 15:22:59 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <16b13094-46e0-1c03-f60f-1df8f46e91b9@siemens.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: vQfq6GjKZh3p On 2018-03-08 09:14, Claudius Heine wrote: > Hi Jan, > > On 03/08/2018 07:06 AM, Jan Kiszka wrote: >> On 2018-03-07 20:51, [ext] Jan Kiszka wrote: >>> On 2018-03-07 17:44, [ext] claudius.heine.ext@siemens.com wrote: >>>> From: Claudius Heine >>>> >>>> Hi, >>>> >>>> sorry, just saw a small error, some changes to isar-bootstrap got into >>>> the buildchroot patch. >>>> >>>> Cheers, >>>> Claudius >>>> >>>> Changes from v3: >>>>    - A small modification to isar-bootstrap.bb snuck into the >>>> buildchroot >>>>      patch. >>>> >>>> Changes from v2: >>>>    - rebased to current next >>>>    - added missing newlines at the end of file >>>>    - use cleandirs with root permissions >>>>      this could be improved in some later patch series, so that this >>>>      feature can be shared. >>>>    - moved main source url of packages to apt source list files of the >>>>      distributions: >>>>      - Implemented some basic parsing of source.lists files in >>>>        isar-bootstrap. >>>>      - Made 'DISTRO_SUITE', 'DISTRO_APT_SOURCE' and 'DISTRO_COMPONENTS' >>>>        variables obsolete. >>>>    - implemented repo key fetching to support rasbian repositories >>>>    - now the clean task removes the symlink of isar-bootstrap deploy >>>> task >>>> >>>> Changes from v1: >>>>    - rebased to current next >>>>    - added unmounting of /dev and /proc at the end of do_rootfs in >>>> isar-image-base >>>>      This was necessary for image file creation, otherwise it tried to >>>>      package stuff from the host. >>>>    - added 'isar-bootstrap:do_deploy' dependency to do_rootfs task in >>>>      image.bbclass. >>>>    - Changed 'RFSDIR' variable name to 'ROOTFSDIR' in >>>>      isar-bootstrap-helper.bbclass to be consistent with the variable >>>>      name in isar-bootstrap.bb >>>>    - Moved 'isar-apt' apt-preference settings from isar-bootstrap.bb to >>>>      isar-bootstrap-helper.bbclass >>>>    - Removed '--no-install-recommends' parameters in favor of adding >>>> the >>>>      apt configuration in 'isar-bootstrap.bb' >>>>    - unmount and remove possible existing bootstraped directories >>>> before >>>>      bootstrapping in do_bootstrap task of 'isar-bootstrap.bb' >>>>    - changed from /dev ro bind mounts to mounting devtmpfs to /dev >>>> to be >>>>      consistent with the other places where /dev is mounted. >>>> >>>> >>>> Claudius Heine (5): >>>>    implement isar-bootstrap using debootstrap >>>>    meta/isar-bootstrap-helper.bbclass: handle rfs customization >>>> centrally >>>>    meta/buildchroot: switch to using isar-bootstrap >>>>    meta-isar/isar-image-base: switch to using isar-bootstrap >>>>    meta-isar/multiconfig: remove multistrap references >>>> >>>>   meta-isar/conf/distro/debian-jessie.conf           |   9 +- >>>>   meta-isar/conf/distro/debian-jessie.list           |   3 + >>>>   meta-isar/conf/distro/debian-stretch.conf          |   7 +- >>>>   meta-isar/conf/distro/debian-stretch.list          |   3 + >>>>   meta-isar/conf/distro/debian-wheezy.conf           |   9 +- >>>>   meta-isar/conf/distro/debian-wheezy.list           |   3 + >>>>   meta-isar/conf/distro/raspbian-jessie.conf         |  12 +- >>>>   meta-isar/conf/distro/raspbian-jessie.list         |   1 + >>>>   meta-isar/conf/local.conf.sample                   |   4 +- >>>>   meta-isar/conf/multiconfig/qemuarm-jessie.conf     |   2 +- >>>>   meta-isar/conf/multiconfig/qemuarm-wheezy.conf     |   2 +- >>>>   meta-isar/conf/multiconfig/rpi-jessie.conf         |   2 +- >>>>   .../recipes-core/images/files/download_dev-random  |  24 --- >>>>   .../recipes-core/images/files/multistrap.conf.in   |  38 ---- >>>>   meta-isar/recipes-core/images/files/setup.sh       |  77 -------- >>>>   meta-isar/recipes-core/images/isar-image-base.bb   |  64 +++---- >>>>   meta/classes/image.bbclass                         |   2 +- >>>>   meta/classes/isar-bootstrap-helper.bbclass         |  39 ++++ >>>>   .../isar-bootstrap/files/isar-apt.conf             |   2 + >>>>   meta/recipes-core/isar-bootstrap/isar-bootstrap.bb | 205 >>>> +++++++++++++++++++++ >>>>   meta/recipes-devtools/buildchroot/buildchroot.bb   |  59 ++---- >>>>   meta/recipes-devtools/buildchroot/files/build.sh   |   2 +- >>>>   .../buildchroot/files/configscript.sh              |  10 - >>>>   .../buildchroot/files/multistrap.conf.in           |  37 ---- >>>>   meta/recipes-devtools/buildchroot/files/setup.sh   |  82 --------- >>>>   25 files changed, 310 insertions(+), 388 deletions(-) >>>>   create mode 100644 meta-isar/conf/distro/debian-jessie.list >>>>   create mode 100644 meta-isar/conf/distro/debian-stretch.list >>>>   create mode 100644 meta-isar/conf/distro/debian-wheezy.list >>>>   create mode 100644 meta-isar/conf/distro/raspbian-jessie.list >>>>   delete mode 100644 >>>> meta-isar/recipes-core/images/files/download_dev-random >>>>   delete mode 100644 >>>> meta-isar/recipes-core/images/files/multistrap.conf.in >>>>   delete mode 100755 meta-isar/recipes-core/images/files/setup.sh >>>>   create mode 100644 meta/classes/isar-bootstrap-helper.bbclass >>>>   create mode 100644 >>>> meta/recipes-core/isar-bootstrap/files/isar-apt.conf >>>>   create mode 100644 meta/recipes-core/isar-bootstrap/isar-bootstrap.bb >>>>   delete mode 100644 >>>> meta/recipes-devtools/buildchroot/files/multistrap.conf.in >>>>   delete mode 100755 meta/recipes-devtools/buildchroot/files/setup.sh >>>> >>> >>> FWIW, I've successfully built all CI targets locally just now. No time >>> to test the result, though. >> >> Images also run, and I was specifically able to build and run the next >> branch of jailhouse-images with these patches applied. Looks very good! >> And I also like "310 insertions(+), 388 deletions(-)" a lot. :) > > Great that you like it :) But some features would need to be implemented > or fixed again, like changing mirrors and setting hostname. So there is > some regression happening here unfortunately. > > Also, I because I was busy tackling and fixing the big issues, there > might still be some regressions or left over code in some places. I > would try looking at the configscripts for both isar-image-base and > buildchroot. I am not sure if everything there is still required or if I > accidental deleted something very important from the setup scripts. I > don't think so, but I haven't written this code or encountered any > issues it fixes. > > But all those issues should be reasonable straight forward to fix, and > if someone or myself follow the suggestions I just posted, then the code > reduction might still happen. Alex, feel free to pick up this series. I thing it would be very valuable for upcoming features like reproducible build or cross-buildchroot to have this refactoring merged first. As Claudius said, he is probably busy the next weeks with a more urgent topic. Thanks, Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux