From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6709026804638679040 X-Gmail-Labels: Topic type: DISCUSSION X-Received: by 2002:a2e:9158:: with SMTP id q24mr100434ljg.119.1562088694005; Tue, 02 Jul 2019 10:31:34 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:2b43:: with SMTP id q64ls1665162lje.10.gmail; Tue, 02 Jul 2019 10:31:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3oyjpctYXMxIXRTexRe3fmJOxrWF8EZ+kna2s+Ru/JyvDTBvzCK3fueo+qSC6/9lfTjSL X-Received: by 2002:a2e:98d7:: with SMTP id s23mr6994408ljj.179.1562088693353; Tue, 02 Jul 2019 10:31:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1562088693; cv=none; d=google.com; s=arc-20160816; b=JdXsQctdF8zBzF5xQS6I5juvWt12bIsQVkzb3YMWjh5DFfeXQR/4vW2IMGioxXgmoa fL15f61/vEkZ1QwVHnTPGdIp9vCuxQ+81M56aCk/VQEFmkL/Nsfm4Au6nFlpEqQtJ7Ud +EPHyLePXlO7fy5F+yzMSFfxczbPL48b8cuWIy6l5udrG0chea1NkX3NXYWxtnrpikp6 g0DFceSFGKFr1J9wtc/mgSdpJXYmE8oQ82fllaljFOs84ywUG2DCfaBVk7MKKZmj4iM7 Z7T9DsFGACsSCZQGDG7VW3xHO1Xj4UELqwOzvdfYiOSyHyS1Q3BOunq7XkJt2UA+xXdv jA6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=OpRbN0H6R+DInaYEscSFJsB7GrcHY0d+7V1+E7tkKx0=; b=JmoyFosTfDC2AP2SCAhrW0um5GM0ldP0d6smKT5Xe2DBud4xSJpCUjYEs7eATkrXSU ZEP2ATaE2aC1WRjv75Fm/k58UOQ/3ebVyO1I8p8mlbGWhsF9GmWzCxBu2Y7hFDO4jMcY xk6272ZqLohUJMo5/O2wbchsoN31XW6cAwxz5ySBeDvl+nuLquMFaGXK665JiOGZ01LK RQfSKLV7Qr8QcjK/kU9uQI2rAGFL6o2Y0NQMFM6FmDZhnLYromvAw5bCswwUH9zRa+MU GYcIESJ28JbA3KXCwatNnhCPcG3D4sUGnCqt/fDEDH0nVnRK6oJJTD1P2tCXSKeh25jr IqgA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id m84si703816lje.1.2019.07.02.10.31.33 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jul 2019 10:31:33 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x62HVVeQ030605 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 2 Jul 2019 19:31:31 +0200 Received: from [139.23.114.160] ([139.23.114.160]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x62HVVMe030173; Tue, 2 Jul 2019 19:31:31 +0200 Subject: Re: linux perf_4.19 To: chombourger@gmail.com, isar-users References: <4aafffd4-e6ed-4db1-a93b-dc853aa5dc84@googlegroups.com> <866f4164-0dc6-beba-ea97-c9904b4bc391@siemens.com> <45064917-b93a-4cb7-80dd-833f192bde19@googlegroups.com> From: Jan Kiszka Message-ID: Date: Tue, 2 Jul 2019 19:31:31 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <45064917-b93a-4cb7-80dd-833f192bde19@googlegroups.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: NQugj6/FAPnw On 02.07.19 14:14, chombourger@gmail.com wrote: > I do have a kernel patch to make builddep produce a debian package for perf > > I however need to clean it up before I submit it upstream. Consider the inline > patch below as RFC > (tested on 4.14 and 4.19). My worry is around the hard-coded Depends (tested OK > on Debian 9) > > Just did not get around to finalize it - sorry Sound like a plan. That package will then act as a drop-in replacement for the Debian's perf package, right? And perf is backward compatible to older kernel version, right? Asking because of the linux-libc-dev version check we already have in linux-custom.inc. Jan > > Index: linux-4.14.71/scripts/package/builddeb > =================================================================== > --- linux-4.14.71.orig/scripts/package/builddeb > +++ linux-4.14.71/scripts/package/builddeb > @@ -90,12 +90,23 @@ if [ -n "$KDEB_PKGVERSION" ]; then >  else >         packageversion=$version-$revision >  fi > +perf_kver="${version%%-*}" > +case "$perf_kver" in > +    *.*.*) > +        perf_kver="${perf_kver%.*}" > +        ;; > +esac >  sourcename=$KDEB_SOURCENAME >  tmpdir="$objtree/debian/tmp" >  kernel_headers_dir="$objtree/debian/hdrtmp" >  libc_headers_dir="$objtree/debian/headertmp" >  dbg_dir="$objtree/debian/dbgtmp" >  packagename=linux-image-$version > +perf_dir="$objtree/debian/perf-$perf_kver-tmp" > +meta_perf_dir="$objtree/debian/perftmp" > +perf_packagename=linux-perf-$perf_kver > +meta_perf_packagename=linux-perf > +dbg_dir="$objtree/debian/dbgtmp" >  kernel_headers_packagename=linux-headers-$version >  libc_headers_packagename=linux-libc-dev >  dbg_packagename=$packagename-dbg > @@ -125,6 +136,7 @@ BUILD_DEBUG="$(grep -s '^CONFIG_DEBUG_IN > >  # Setup the directory structure >  rm -rf "$tmpdir" "$kernel_headers_dir" "$libc_headers_dir" "$dbg_dir" > $objtree/debian/files > +rm -rf "$meta_perf_dir" "$perf_dir" >  mkdir -m 755 -p "$tmpdir/DEBIAN" >  mkdir -p "$tmpdir/lib" "$tmpdir/boot" >  mkdir -p "$kernel_headers_dir/lib/modules/$version/" > @@ -177,6 +189,21 @@ if grep -q '^CONFIG_MODULES=y' $KCONFIG_ >         fi >  fi > +mkdir -p $perf_dir > +$MAKE -C tools/perf -f Makefile.perf           \ > +       DESTDIR="$(readlink -f $perf_dir)"      \ > +       srctree=$(pwd)                          \ > +       LDFLAGS=                                \ > +       prefix=/usr                             \ > +       perfexecdir=lib/perf_$perf_kver-core    \ > +       install > +mv $perf_dir/usr/bin/perf $perf_dir/usr/bin/perf_$perf_kver > +rm -f $perf_dir/usr/bin/trace > +for p in $perf_dir/usr/bin/perf-*; do > +       [ -f $p ] || continue > +       mv $p $perf_dir/usr/lib/perf_$perf_kver-core/ > +done > + >  if [ "$ARCH" != "um" ]; then >         $MAKE headers_check KBUILD_SRC= >         $MAKE headers_install KBUILD_SRC= INSTALL_HDR_PATH="$libc_headers_dir/usr" > @@ -352,12 +379,35 @@ Description: Linux support headers for u >   are used by the installed headers for GNU glibc and other system libraries. >  EOF > > +cat <> debian/control > + > +Package: $meta_perf_packagename > +Section: devel > +Architecture: all > +Depends: $perf_packagename > +Description: Performance analysis tools for Linux (meta-package) > + This package depends on the package containing the 'perf' performance analysis > + tools for the latest Linux kernel. > + > +Package: $perf_packagename > +Section: devel > +Architecture: any > +Depends: libunwind8, libperl5.24, libpython2.7, binutils, libnuma1 > +Description: Performance analysis tools for Linux $KERNELRELEASE > + This package contains the 'perf' performance analysis tools for Linux kernel > + version $KERNELRELEASE > +EOF > + >  if [ "$ARCH" != "um" ]; then >         create_package "$kernel_headers_packagename" "$kernel_headers_dir" >         create_package "$libc_headers_packagename" "$libc_headers_dir" >  fi > >  create_package "$packagename" "$tmpdir" > +create_package "$perf_packagename" "$perf_dir" > + > +forcearch="-DArchitecture=all" \ > +create_package "$meta_perf_packagename" "$meta_perf_dir" > >  if [ -n "$BUILD_DEBUG" ] ; then >         # Build debug package > > On Tuesday, July 2, 2019 at 1:38:03 PM UTC+2, Jan Kiszka wrote: > > On 02.07.19 13:30, srinuv...@gmail.com wrote: > > Hi All, > > > >                 We need to support perf tool in linux-cip 4.19 kernel, Is it > > available perf_4.19 in ISAR? > > > > Let's start differently: > > - describe the problem you are facing (Debian perf vs. perf from custom >    kernels) > - describe your current downstream approach to resolve that (ideally >    with code) > - ask for feedback / suggestions how to address that in Isar generically > > Jan > > -- > Siemens AG, Corporate Technology, CT RDA IOT SES-DE > Corporate Competence Center Embedded Linux > > -- > You received this message because you are subscribed to the Google Groups > "isar-users" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to isar-users+unsubscribe@googlegroups.com > . > To post to this group, send email to isar-users@googlegroups.com > . > To view this discussion on the web visit > https://groups.google.com/d/msgid/isar-users/45064917-b93a-4cb7-80dd-833f192bde19%40googlegroups.com > . > For more options, visit https://groups.google.com/d/optout. -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux