From: Jan Kiszka <jan.kiszka@siemens.com>
To: isar-users <isar-users@googlegroups.com>
Subject: [PATCH 3/5] wic-img: Require explicit setting of WKS_FILE
Date: Wed, 5 Sep 2018 20:18:02 +0200 [thread overview]
Message-ID: <be3f55636898d4281c1c27e8260603ff51cb9226.1536171484.git.jan.kiszka@siemens.com> (raw)
In-Reply-To: <cover.1536171484.git.jan.kiszka@siemens.com>
In-Reply-To: <cover.1536171484.git.jan.kiszka@siemens.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
Do not default to some meta-isar file, that's both a laying violation
nor helpful once the user also need to specify the bootloader
dependencies for the imager.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
meta-isar/conf/multiconfig/qemuamd64-buster.conf | 1 +
meta-isar/conf/multiconfig/qemuamd64-stretch.conf | 1 +
meta/classes/wic-img.bbclass | 6 +++++-
3 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/meta-isar/conf/multiconfig/qemuamd64-buster.conf b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
index 85404ae..8140d13 100644
--- a/meta-isar/conf/multiconfig/qemuamd64-buster.conf
+++ b/meta-isar/conf/multiconfig/qemuamd64-buster.conf
@@ -10,6 +10,7 @@ KERNEL_NAME ?= "amd64"
IMAGE_PREINSTALL += "init"
IMAGE_TYPE ?= "wic-img"
+WKS_FILE ?= "sdimage-efi"
ROOTFS_DEV ?= "sda2"
diff --git a/meta-isar/conf/multiconfig/qemuamd64-stretch.conf b/meta-isar/conf/multiconfig/qemuamd64-stretch.conf
index 356d59b..0184617 100644
--- a/meta-isar/conf/multiconfig/qemuamd64-stretch.conf
+++ b/meta-isar/conf/multiconfig/qemuamd64-stretch.conf
@@ -11,6 +11,7 @@ KERNEL_NAME ?= "amd64"
IMAGE_PREINSTALL += "init"
IMAGE_TYPE ?= "wic-img"
+WKS_FILE ?= "sdimage-efi"
ROOTFS_DEV ?= "sda2"
diff --git a/meta/classes/wic-img.bbclass b/meta/classes/wic-img.bbclass
index bc405c1..167a54b 100644
--- a/meta/classes/wic-img.bbclass
+++ b/meta/classes/wic-img.bbclass
@@ -4,7 +4,11 @@
# this class is heavily inspired by OEs ./meta/classes/image_types_wic.bbclass
#
-WKS_FILE ?= "sdimage-efi"
+python () {
+ if not d.getVar('WKS_FILE', True):
+ bb.fatal("WKS_FILE must be set")
+}
+
ROOTFS_TYPE ?= "ext4"
STAGING_DATADIR ?= "/usr/lib/"
--
2.16.4
next prev parent reply other threads:[~2018-09-05 18:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 18:17 [PATCH 0/5] Refactor bootloader installation, add custom U-Boot include Jan Kiszka
2018-09-05 18:18 ` [PATCH 1/5] meta: Factor out buildchroot class Jan Kiszka
2018-09-05 18:18 ` [PATCH 2/5] image: Add imager dependency installation task Jan Kiszka
2018-09-05 18:18 ` Jan Kiszka [this message]
2018-09-05 18:18 ` [PATCH 4/5] Install wic and bootloader dependencies via imager_install_deps Jan Kiszka
2018-09-05 18:18 ` [PATCH 5/5] meta: Add custom U-Boot recipe include Jan Kiszka
2018-09-07 18:27 ` [PATCH v2 " Jan Kiszka
2018-09-05 18:19 ` [PATCH 0/5] Refactor bootloader installation, add custom U-Boot include Jan Kiszka
2018-09-11 8:33 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be3f55636898d4281c1c27e8260603ff51cb9226.1536171484.git.jan.kiszka@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox