From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6878157486786871296 Date: Mon, 23 Nov 2020 07:08:18 -0800 (PST) From: "vijaikumar....@gmail.com" To: isar-users Message-Id: In-Reply-To: <20200930060259.12422-1-Vijaikumar_Kanagarajan@mentor.com> References: <20200930060259.12422-1-Vijaikumar_Kanagarajan@mentor.com> Subject: Re: [PATCH v6 00/13] Deb-src caching MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_422_381553291.1606144098076" X-TUID: TJKmkg1YMcym ------=_Part_422_381553291.1606144098076 Content-Type: multipart/alternative; boundary="----=_Part_423_1050609166.1606144098076" ------=_Part_423_1050609166.1606144098076 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Any review comment on this series? Thanks, Vijai Kumar K On Wednesday, September 30, 2020 at 11:33:54 AM UTC+5:30 vijaikumar_...@mentor.com wrote: > Changes in v6: > - Rebase against latest next > - Address review comments from Henning > Git Tree: https://github.com/vj-kumar/isar/tree/vijai/debsrc6.3 > > Changes in v5: > The major changes in this series are as below, > - (P2) Handle cases where HOST_DISTRO!=DISTRO. This avoids mixing > of debs from different distro which inturn helps the src caching logic. > - (P5) Avoid downloading package from other builds. > - (P8) Add a reprepro based sanity test to check if the repo contains > the sources for all the debs. > - (P9) Introduce a new variable BASE_REPO_FEATURES which provides means > to enable or disable various base-apt features. (cache-deb-src for now) > - Some fixes in (P12 & P13) > Also, addressed some review comments from Henning. > Git Tree: https://github.com/vj-kumar/isar/tree/vijai/debsrc5 > > Changes in v4: > - Use = format instead of just using > to download the right version of source package. > > Changes in v3: > - Take care of non-existent downloads/deb-src directory. > > Changes in v2: > - Introduced additional patch to cache deb src > - Rebased on top of henning/staging4 tree > > Vijai Kumar K (13): > rootfs: Make rootfs finalize a separate task > deb-dl-dir: Cache host distro debs separately > meta: cache deb srcs as part of postprocessing > deb-dl-dir: Make debsrc_download faster > deb-dl-dir: Download files only belonging to the current image > deb-dl-dir: Factor out the mounting part > deb-dl-dir: Fix skipping of removed files > repository: Add a sanity test to check missing sources > base-apt: Introduce BASE_REPO_FEATURES > repository: Fix failures due to missing section > scripts/ci_build.sh: Enable deb-src caching > rootfs: Fix possible overwrite of existing resolv.conf > rootfs: Handle failures when postprocess is rerun > > meta-isar/conf/local.conf.sample | 4 ++ > meta/classes/deb-dl-dir.bbclass | 61 +++++++++++++++++- > meta/classes/dpkg-gbp.bbclass | 8 ++- > meta/classes/dpkg.bbclass | 8 ++- > meta/classes/image-tools-extension.bbclass | 4 +- > meta/classes/image.bbclass | 43 ++++++++++++- > meta/classes/repository.bbclass | 13 +++- > meta/classes/rootfs.bbclass | 62 +++++++------------ > .../isar-bootstrap/isar-bootstrap.inc | 12 +++- > meta/recipes-devtools/base-apt/base-apt.bb | 3 + > scripts/ci_build.sh | 1 + > 11 files changed, 166 insertions(+), 53 deletions(-) > > -- > 2.17.1 > > ------=_Part_423_1050609166.1606144098076 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Any review comment on this series?

Thanks,
Vijai Kumar K

On Wednesday, September 30, 2020 at 11:33:54 AM UTC+5:30 vijaikumar_...@mentor.com wrote:
Changes in v6:
- Rebase against latest next
- Address review comments from Henning
Git Tree: https://github.com/vj-kumar/isar/tree/vijai/debsrc6.3

Changes in v5:
The major changes in this series are as below,
- (P2) Handle cases where HOST_DISTRO!=DISTRO. This avoids mixing
of debs from different distro which inturn helps the src caching logic.
- (P5) Avoid downloading package from other builds.
- (P8) Add a reprepro based sanity test to check if the repo contains
the sources for all the debs.
- (P9) Introduce a new variable BASE_REPO_FEATURES which provides means
to enable or disable various base-apt features. (cache-deb-src for now)
- Some fixes in (P12 & P13)
Also, addressed some review comments from Henning.
Git Tree: https://github.com/vj-kumar/isar/tree/vijai/debsrc5

Changes in v4:
- Use <source package>=<version> format instead of just using <packagename>
to download the right version of source package.

Changes in v3:
- Take care of non-existent downloads/deb-src directory.

Changes in v2:
- Introduced additional patch to cache deb src
- Rebased on top of henning/staging4 tree

Vijai Kumar K (13):
rootfs: Make rootfs finalize a separate task
deb-dl-dir: Cache host distro debs separately
meta: cache deb srcs as part of postprocessing
deb-dl-dir: Make debsrc_download faster
deb-dl-dir: Download files only belonging to the current image
deb-dl-dir: Factor out the mounting part
deb-dl-dir: Fix skipping of removed files
repository: Add a sanity test to check missing sources
base-apt: Introduce BASE_REPO_FEATURES
repository: Fix failures due to missing section
scripts/ci_build.sh: Enable deb-src caching
rootfs: Fix possible overwrite of existing resolv.conf
rootfs: Handle failures when postprocess is rerun

meta-isar/conf/local.conf.sample | 4 ++
meta/classes/deb-dl-dir.bbclass | 61 +++++++++++++++++-
meta/classes/dpkg-gbp.bbclass | 8 ++-
meta/classes/dpkg.bbclass | 8 ++-
meta/classes/image-tools-extension.bbclass | 4 +-
meta/classes/image.bbclass | 43 ++++++++++++-
meta/classes/repository.bbclass | 13 +++-
meta/classes/rootfs.bbclass | 62 +++++++------------
.../isar-bootstrap/isar-bootstrap.inc | 12 +++-
meta/recipes-devtools/base-apt/base-apt.bb | 3 +
scripts/ci_build.sh | 1 +
11 files changed, 166 insertions(+), 53 deletions(-)

--
2.17.1

------=_Part_423_1050609166.1606144098076-- ------=_Part_422_381553291.1606144098076--