[PATCH] debianize: Switch version-existing check to dpkg-parsechangelog

[PATCH] debianize: Switch version-existing check to dpkg-parsechangelog

[Jan Kiszka]

From: Jan Kiszka <jan.kiszka@siemens.com>

This also reduces the check to the version, ignoring the package name.

Suggested-by: Henning Schild <henning.schild@siemens.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 meta/classes/debianize.bbclass | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta/classes/debianize.bbclass b/meta/classes/debianize.bbclass
index e77be232..764477c8 100644
--- a/meta/classes/debianize.bbclass
+++ b/meta/classes/debianize.bbclass
@@ -34,9 +34,8 @@ ${PN} (${changelog_v}) UNRELEASED; urgency=low
  -- ${MAINTAINER}  ${date}
 EOF
 	if [ -f ${WORKDIR}/changelog ]; then
-		if head -1 "${WORKDIR}"/changelog | \
-			grep -q -e "^${PN} (${changelog_v})"
-		then
+		latest_version=$(dpkg-parsechangelog -l ${WORKDIR}/changelog -S Version)
+		if [ "${latest_version}" = "${changelog_v}" ]; then
 			# entry for our version already there, use unmodified
 			rm ${S}/debian/changelog
 		else
-- 
2.16.4

Re: [PATCH] debianize: Switch version-existing check to dpkg-parsechangelog

[Baurzhan Ismagulov]

On Wed, Apr 29, 2020 at 09:36:40AM +0200, Jan Kiszka wrote:
> This also reduces the check to the version, ignoring the package name.

I had applied this as well, it doesn't affect v4, does it?

With kind regards,
Baurzhan.

Re: [PATCH] debianize: Switch version-existing check to dpkg-parsechangelog

[Henning Schild]

Am Thu, 7 May 2020 23:02:05 +0200
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Wed, Apr 29, 2020 at 09:36:40AM +0200, Jan Kiszka wrote:
> > This also reduces the check to the version, ignoring the package
> > name.  
> 
> I had applied this as well, it doesn't affect v4, does it?

This one is fine. Stand alone as it is.

Henning

> With kind regards,
> Baurzhan.
>