From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7340524753523834880 Date: Wed, 28 Feb 2024 21:02:13 -0800 (PST) From: srinu To: isar-users Message-Id: In-Reply-To: <26ed2ebb-b893-4cf2-9d8d-aa04fd68acc9@siemens.com> References: <20240228072206.3556467-1-srinuvasan.a@siemens.com> <26ed2ebb-b893-4cf2-9d8d-aa04fd68acc9@siemens.com> Subject: Re: [PATCH] meta/classes/debianize: Add copyright file to debian folder MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_20596_1026682005.1709182933974" X-TUID: cAbV9tz4FCdZ ------=_Part_20596_1026682005.1709182933974 Content-Type: multipart/alternative; boundary="----=_Part_20597_79143112.1709182933974" ------=_Part_20597_79143112.1709182933974 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thursday, February 29, 2024 at 6:40:24=E2=80=AFAM UTC+5:30 Jan Kiszka wr= ote: On 28.02.24 08:22, srinuvasan.a via isar-users wrote:=20 > From: Srinuvasan A =20 >=20 > In downstream layer we uses copyright files for most of the packages,=20 > this is very important for our OSS clearing.=20 >=20 > User can add the copyright to the required recipe, then the generated=20 > packages from the recipes contains the debian/copyright file.=20 >=20 > Added example copyright file in example-raw recipe.=20 >=20 > Signed-off-by: Srinuvasan A =20 > ---=20 > .../recipes-app/example-raw/example-raw_0.3.bb | 3 ++-=20 > .../example-raw/files/default-copyright.tmpl | 15 +++++++++++++++=20 > meta/classes/debianize.bbclass | 4 ++++=20 > 3 files changed, 21 insertions(+), 1 deletion(-)=20 > create mode 100644=20 meta-isar/recipes-app/example-raw/files/default-copyright.tmpl=20 >=20 > diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb=20 b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb=20 > index ffa14340..b4dfaa4d 100644=20 > --- a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb=20 > +++ b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb=20 > @@ -9,7 +9,8 @@ DEBIAN_DEPENDS =3D "adduser, apt (>=3D 0.4.2)"=20 >=20 > SRC_URI =3D "file://README \=20 > file://postinst \=20 > - file://rules"=20 > + file://rules \=20 > + file://default-copyright.tmpl"=20 >=20 > inherit dpkg-raw=20 >=20 > diff --git=20 a/meta-isar/recipes-app/example-raw/files/default-copyright.tmpl=20 b/meta-isar/recipes-app/example-raw/files/default-copyright.tmpl=20 > new file mode 100644=20 > index 00000000..9c04255a=20 > --- /dev/null=20 > +++ b/meta-isar/recipes-app/example-raw/files/default-copyright.tmpl=20 > @@ -0,0 +1,15 @@=20 > +Format:=20 https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/=20 > +Upstream-Name: ${PN}=20 > +Upstream-Contact: Mentor Embedded =20 > +Source: https://github.com/MentorEmbedded/industrial-core=20 > +=20 > +Files: *=20 > +Copyright: 2022, Siemens=20 > +License: Siemens=20 > + .=20 > + This material contains trade secrets or otherwise confidential=20 information=20 > + owned by Siemens Industry Software Inc.or its affiliates (collectively,= =20 > + "Siemens"), or its licensors. Access to and use of this information is= =20 strictly=20 > + limited as set forth in the Customer's applicable agreements with=20 Siemens.=20 > + .=20 > + Unpublished work. Copyright 2023 Siemens=20 Somehow I can't imagine you actually want to have this merged into an=20 open source project, do you? ;)=20 Jan This PR we proposed for our downstream layer, here we have n no.of=20 recipes which contains the LICENSE, based on the LICENSE variable we are installing this copyright file=20 into the packages, and this would really=20 needed for our OSS clearing Do you have any thoughts to address this one in ISAR?=20 > diff --git a/meta/classes/debianize.bbclass=20 b/meta/classes/debianize.bbclass=20 > index 7de98673..5b9cd9dc 100644=20 > --- a/meta/classes/debianize.bbclass=20 > +++ b/meta/classes/debianize.bbclass=20 > @@ -112,6 +112,10 @@ deb_debianize() {=20 > else=20 > deb_create_rules=20 > fi=20 > + # Add the copyright if unpacked sources does not contain copyright file= =20 > + if [ ! -f ${S}/debian/copyright.tmpl ] && [ -f=20 ${WORKDIR}/default-copyright.tmpl ]; then=20 > + install -v -m 644 ${WORKDIR}/default-copyright.tmpl=20 ${S}/debian/copyright=20 > + fi=20 > # prepend a changelog-entry unless an existing changelog file already=20 > # contains an entry with CHANGELOG_V=20 > deb_add_changelog=20 --=20 Siemens AG, Technology=20 Linux Expert Center=20 ------=_Part_20597_79143112.1709182933974 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On Thursday, February 29, 2024 at 6:40:2= 4=E2=80=AFAM UTC+5:30 Jan Kiszka wrote:
On 28.02.24 08:22, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuv...@s= iemens.com>
>=20
> In downstream layer we uses copyright files for most of the pack= ages,
> this is very important for our OSS clearing.
>=20
> User can add the copyright to the required recipe, then the gene= rated
> packages from the recipes contains the debian/copyright file.
>=20
> Added example copyright file in example-raw recipe.
>=20
> Signed-off-by: Srinuvasan A <sr= inuv...@siemens.com>
> ---
> .../recipes-app/example-raw/example-raw_0.3.bb | 3 ++-
> .../example-raw/files/default-copyright.tmpl | 15 ++++++++= +++++++
> meta/classes/debianize.bbclass | 4 ++++
> 3 files changed, 21 insertions(+), 1 deletion(-)
> create mode 100644 meta-isar/recipes-app/example-raw/files/defa= ult-copyright.tmpl
>=20
> diff --git a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb<= /a> b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb
> index ffa14340..b4dfaa4d 100644
> --- a/meta-isar/recipes-app/example-raw/example-raw_0.3.bb
> +++ b/meta-isar/recipes-app/example-raw/example-raw_0.3.bb
> @@ -9,7 +9,8 @@ DEBIAN_DEPENDS =3D "adduser, apt (>=3D 0.4.2)= "
> =20
> SRC_URI =3D "file://README \
> =09 file://postinst \
> -=09 file://rules"
> +=09 file://rules \
> +=09 file://default-copyright.tmpl"
> =20
> inherit dpkg-raw
> =20
> diff --git a/meta-isar/recipes-app/example-raw/files/default-cop= yright.tmpl b/meta-isar/recipes-app/example-raw/files/default-copyright.tmp= l
> new file mode 100644
> index 00000000..9c04255a
> --- /dev/null
> +++ b/meta-isar/recipes-app/example-raw/files/default-copyright.= tmpl
> @@ -0,0 +1,15 @@
> +Format: https://www.debi= an.org/doc/packaging-manuals/copyright-format/1.0/
> +Upstream-Name: ${PN}
> +Upstream-Contact: Mentor Embedded <embedded...@mentor.com>
> +Source: https://github.com/MentorEmbedded= /industrial-core
> +
> +Files: *
> +Copyright: 2022, Siemens
> +License: Siemens
> + .
> + This material contains trade secrets or otherwise confidential= information
> + owned by Siemens Industry Software Inc.or its affiliates (coll= ectively,
> + "Siemens"), or its licensors. Access to and use of this inform= ation is strictly
> + limited as set forth in the Customer's applicable agreements w= ith Siemens.
> + .
> + Unpublished work. Copyright 2023 Siemens

Somehow I can't imagine you actually want to have this merged into an
open source project, do you? ;)

Jan

=C2=A0 =C2=A0 This PR we propos= ed for our downstream layer, here we have n no.of recipes which contains th= e LICENSE,
=C2=A0 =C2=A0 based on the LICENSE variable we are ins= talling this copyright file into the packages, and this would really=C2=A0<= /div>
=C2=A0 =C2=A0 needed for our OSS clearing

<= div>=C2=A0 =C2=A0 =C2=A0Do you have any thoughts to address this one in ISA= R?=C2=A0


> diff --git a/meta/classes/debianize.bbclass b/meta/classes/debia= nize.bbclass
> index 7de98673..5b9cd9dc 100644
> --- a/meta/classes/debianize.bbclass
> +++ b/meta/classes/debianize.bbclass
> @@ -112,6 +112,10 @@ deb_debianize() {
> =09else
> =09=09deb_create_rules
> =09fi
> +=09# Add the copyright if unpacked sources does not contain cop= yright file
> +=09if [ ! -f ${S}/debian/copyright.tmpl ] && [ -f ${WOR= KDIR}/default-copyright.tmpl ]; then
> +=09=09install -v -m 644 ${WORKDIR}/default-copyright.tmpl ${S}/= debian/copyright
> +=09fi
> =09# prepend a changelog-entry unless an existing changelog fil= e already
> =09# contains an entry with CHANGELOG_V
> =09deb_add_changelog

--=20
Siemens AG, Technology
Linux Expert Center

------=_Part_20597_79143112.1709182933974-- ------=_Part_20596_1026682005.1709182933974--