From: Jan Kiszka <jan.kiszka@siemens.com>
To: "[ext] Su, Bao Cheng" <baocheng.su@siemens.com>,
"Schild, Henning" <henning.schild@siemens.com>,
Baurzhan Ismagulov <ibr@radix50.net>
Cc: "isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH] image-postproc-extension: empty mechine-id
Date: Thu, 11 Jul 2019 07:34:22 +0200 [thread overview]
Message-ID: <c0a604ca-2bac-d628-ef29-d8d998d69381@siemens.com> (raw)
In-Reply-To: <10e6cb8c30024cecae35c0b1a0f9dbb9@siemens.com>
On 11.07.19 06:06, [ext] Su, Bao Cheng wrote:
> On 7/10/2019 7:44 PM, Schild, Henning (CT RDA IOT SES-DE) wrote:
>> Am Wed, 10 Jul 2019 10:48:31 +0200
>> schrieb Baurzhan Ismagulov <ibr@radix50.net>:
>>
>>> Hello Bao Cheng,
>>>
>>> On Mon, Jul 08, 2019 at 10:57:36AM +0000, Su, Bao Cheng wrote:
>>>> According to manpage of debian machine-id @
>>>> https://manpages.debian.org/buster/systemd/machine-id.5.en.html,
>>>> /etc/machine-id should be empty instead of removing.
>>>>
>>>> Also according to above manpage, the dbus machine-id is copied to
>>>> /etc/machine-id if systemd machine-id is empty. However, the dbus
>>>> machine-id is also created during isar building, which stays the
>>>> same for every machine using the same image.
>>>>
>>>> So here instead of removing, empty this file, and the mechine id
>>>> will be regenerated at the first boot. Also remove the dbus
>>>> machine-id to prevent copying.
>>>
>>> Thanks, applied to next.
>>
>> Mhh the commit message looks pretty ugly. Probably because v2 was not
>> actually done with git format-patch.
>>
>> I would suggest to clean that up and force-push next.
>>
> yeah I saw the ugly message from the github.com. Do I have the
> permissions to force-push the next branch? or do I need re-send the
> patch to mailing list?
>
Baurzhan, please re-commit this one. Rewriting next is now less critical as it
used to be.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2019-07-11 5:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 3:37 Su, Bao Cheng
2019-07-08 6:47 ` Claudius Heine
2019-07-08 10:57 ` Su, Bao Cheng
2019-07-10 8:48 ` Baurzhan Ismagulov
2019-07-10 9:19 ` Su, Bao Cheng
2019-07-10 11:44 ` Henning Schild
2019-07-11 4:06 ` Su, Bao Cheng
2019-07-11 5:34 ` Jan Kiszka [this message]
2019-07-11 10:25 ` Baurzhan Ismagulov
2019-07-11 16:37 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0a604ca-2bac-d628-ef29-d8d998d69381@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=henning.schild@siemens.com \
--cc=ibr@radix50.net \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox