From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7077563473267261440 X-Received: by 2002:a2e:bf17:0:b0:248:8d0:1f7e with SMTP id c23-20020a2ebf17000000b0024808d01f7emr16068211ljr.272.1647885121513; Mon, 21 Mar 2022 10:52:01 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6512:3f8e:b0:448:2012:773d with SMTP id x14-20020a0565123f8e00b004482012773dls2850702lfa.3.gmail; Mon, 21 Mar 2022 10:52:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz7yl+wvTz0ECroYPZp99qTRwaTJA5pelv+efbJ+DtNZ7C1b6cfxRBkBE+CU7pRIhhm6uW4 X-Received: by 2002:a05:6512:c01:b0:448:6aec:65c5 with SMTP id z1-20020a0565120c0100b004486aec65c5mr15874481lfu.193.1647885120485; Mon, 21 Mar 2022 10:52:00 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1647885120; cv=pass; d=google.com; s=arc-20160816; b=GPTpUW27PMCT84zj0OKj4RqR6aQUh5uXQev7RlKNqk2Y9LNC3bji7KkEWdYvlHLCTk UJVt5zWt/EfDijT0cEJ0LQAyA1l4Ok2uu5BlwsEB0UlOqWA7QvC3NnQFg6JxiGDCk2bB me+/iGvZUBcMbJoC1WMJFmFWgBmB05UkJwnuuUXYChuyjQ2DKfYwHs9PsNbC41vQRZDR v+3CsBnz3dRbX3AYHZEgSOEfpbe7lRKv0TntztG9eoIHR27hi5LaJJg5vU0Sh3J2468u YydgGNMk+vkyTZ5cp4kxRtZMBinFLeW1g17/e2aIh2HN18icGiCccalTRAE+CaWs+gzv lkfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=AoaCZdbc6lx/YwX6+tlmj9il38zee+aPrtgN1SeGrOs=; b=sUOn/4LKf2wx+Fpci+yDpYi8+Qch0SOtj/jPd1duiFfGYj4hSeOQVScaZL0MYJtP3j BSQ+1ElxVG7gUZC7Nr8eZWeeY9IsexiSmYapdaqLiHa9ifE9WSbH+iQ/vA+LgbFI1SK3 u+ctsYBrXZzo9mcd5gzFXpMsNfeulZiHVrFUajI29kX5zFvACC52gtBdF9vJ3oUfdCzO 0lK3M8BIaGBTVdhXpGF7x06t30zcmW0dZbR4LkcZOxx41SOrlMgBJB/kU2tiuVYqL/SA tPol3O8h/3McRR07cDloh9IChlNyC+21dKnj/VliMznGUT3v3C+N7xamMPerrs0vywgw U/7A== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=te2nLogX; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0d::62c as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on062c.outbound.protection.outlook.com. [2a01:111:f400:fe0d::62c]) by gmr-mx.google.com with ESMTPS id h20-20020a0565123c9400b0044a24244804si345337lfv.12.2022.03.21.10.52.00 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Mar 2022 10:52:00 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0d::62c as permitted sender) client-ip=2a01:111:f400:fe0d::62c; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=te2nLogX; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0d::62c as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ceTd6Pa+sHg+oFJjdqXlo4lg9mnrWTPxwb1RaOa0JMQfHNc2xzvT1UI5QaCkYA9XNPvkhIyZxle6hlZkBkfIrYXYq1wuHNAY7Xp6F81faj4o+mWGVVlY1vp5CHU40i9fVYEB784IcR0Gt9rz1sD0iXBU6AAFIiYAgBk5hD8fgdXuU8mWtsvjIZLjtj6BTZCcuHrNEQVL+HwS2WRo9bwbbSOo23HKsKNKHZiJPE0xW7HLAcXskpifqXfCWdO2J1z166ONFxccDAhTbote5AFRccTtuCk+PhDYnGxBOt9mtRHvvLVcQ9yZ/zDPSUAjcHIwhAxQRe0GviFyPlHcaaOi0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AoaCZdbc6lx/YwX6+tlmj9il38zee+aPrtgN1SeGrOs=; b=B0ltlnfAwUSUMW+ux3KziRjMRpCVvGNr+WrYKcWUHEUdwIw7WzFifa0AayZEyfQWsk8TtNqHLLDovRvMwj8TDAS67SIY3IG7j6i7MQmtaGO4+pXeOGhTc7tXIzTOOgU8vOFcc/bFJYt62bM9tKKudeBMkkT0bMfrjsD1grAGZL9BPJ/UwwP13U33flg0tH7MsSE2TosnLvRHz1Bs+yp3XFDPB40mXkd/MNimDXZFO+cTIP69hJFWpV1oQMbadAf7OdnYGv8St5MusyAYItGU5LDbx5MMkQn679Ogm4+2geGOIGAEk9ieVEGpQ7MrIbYfzR4uyrh+n97abcjKJFsq+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.70) smtp.rcpttodomain=googlegroups.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AoaCZdbc6lx/YwX6+tlmj9il38zee+aPrtgN1SeGrOs=; b=te2nLogXJnJnRPvknAIapFOCCXzHzjmJNUD6CVmpf5gmo4luhj0Kxbf/6P0H+j1K+rLAdUzXIz7LUOkEotYnSl5JFalMZDdkTt3go6aUhIS7oPR3LkYmI0GQVJr8B4PmeS9gJiu6KucM04Y8/LkkED3GUnzwVvGdu4goujZ1xl+3CN6tu2Y8oLl+2aQKRh8d4+Np5l59I1rPRRGcFrpWr1PoH/qnXEoShoMp16e8qHVj2FSTxgl126LyqLDXPGyg2w1NdQZk43glGO5czKAGd5A4JmW9FzXZnE3lKhtpvs5KZf92MGmXbQMcXGoDQN15qwg6Ql7trOa+pxSFhRkDow== Received: from SV0P279CA0013.NORP279.PROD.OUTLOOK.COM (2603:10a6:f10:11::18) by DU0PR10MB5265.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:349::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.19; Mon, 21 Mar 2022 17:51:58 +0000 Received: from HE1EUR01FT041.eop-EUR01.prod.protection.outlook.com (2603:10a6:f10:11:cafe::2f) by SV0P279CA0013.outlook.office365.com (2603:10a6:f10:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.19 via Frontend Transport; Mon, 21 Mar 2022 17:51:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.70) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.70 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.70; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.70) by HE1EUR01FT041.mail.protection.outlook.com (10.152.1.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5081.15 via Frontend Transport; Mon, 21 Mar 2022 17:51:57 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SJA.ad011.siemens.net (194.138.21.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 21 Mar 2022 18:51:57 +0100 Received: from [167.87.32.40] (167.87.32.40) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Mon, 21 Mar 2022 18:51:56 +0100 Message-ID: Date: Mon, 21 Mar 2022 18:51:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/1] add support to set KBUILD_BUILD_TIMESTAMP for custom kernels Content-Language: en-US To: "Moessbauer, Felix (T CED SES-DE)" , "isar-users@googlegroups.com" References: <20220321144017.3684886-1-felix.moessbauer@siemens.com> <33854e3c-f3a6-b667-5e67-18c22b646619@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.32.40] X-ClientProxiedBy: DEMCHDC89YA.ad011.siemens.net (139.25.226.104) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5668650-9f92-4f13-0cf9-08da0b637e8e X-MS-TrafficTypeDiagnostic: DU0PR10MB5265:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vvsqtJKFi6nP4/pmAJAxVv9eCie6dYyU3O3IjykrwM9PMemUvW04XZTtsR+MPwy3Lt1mJZO2PsFY1RjpXfP911fbMsY/5XxmnJt45gg/58Dbn6PTm2pBJMxjES0JUOlH1dDkfxxlREgCKnYa5Ujuy5qrp38nmq4Ofuf06vvLmafCicXcJrdg9grv64S9g3uqzIfFk00PH3I7lK46LlScw4XTxqSSK7gR7GLQsSZ4RhG7L3vM3uN8m55Ixz+huBIdZn/ppwqljjV5q9zNWYKUuugMK+GDNDtHNEhbbfZqcv0XcyC/bY2/e1n38kindCieRfdSajvmQnGKavKcrIFwEg41f6Zk9L3ZXqtsbsGgbNHN9ZH9y8G8WJxrjyGEeCqZKg2sFJLSVHtK/3Btg/7Nr/YgjuSpIApvOhHeVPV3z7d12kucS1ZZAX+hZ26Q0/E/b40HjnJwFRjMNKBJkHh7hBY+7TmAcWjYSblcSL0ORn3TCElMSQCnk0VFXyRBuNK5qIkBMZwN/fx9Q8HoJFZbqZltl/aiI3Oek5ViQ+i5S1UQARwsZH8Mv30XO1KeICF8pQMG1Rhud6fMkuj07vVbUo55wkGPRnzSIenzGr2y+/af0fb0ihgYKYqXlmHqkaQbw4ZTfPs+qE4TiBxPw9P9EXBG/CKoh2He/OnGo/6L+Ua+YAr6iet0G3K8odRsfRSd6qYRnPV9M6A4E83yGw2+QR5JdWm2kIVMIZOjZap7AfIb3/oTPLDToTOx3S5BReSOfrWRBEKwz5u4iiwuWjb94rvOEz9DOjsfxX8M1uyr8G7h3xeWMBdGtstk0/cQYjKn X-Forefront-Antispam-Report: CIP:194.138.21.70;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(83380400001)(36756003)(110136005)(31686004)(6706004)(956004)(2616005)(16576012)(70206006)(26005)(186003)(336012)(40460700003)(16526019)(8676002)(5660300002)(86362001)(82310400004)(8936002)(82960400001)(7636003)(47076005)(498600001)(356005)(44832011)(7596003)(31696002)(36860700001)(70586007)(2906002)(966005)(53546011)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 17:51:57.8471 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5668650-9f92-4f13-0cf9-08da0b637e8e X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.70];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT041.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB5265 X-TUID: y125njgsiMq3 On 21.03.22 18:33, Moessbauer, Felix (T CED SES-DE) wrote: > Hi Jan, > >> -----Original Message----- >> From: Kiszka, Jan (T CED) >> Sent: Monday, March 21, 2022 6:18 PM >> To: Moessbauer, Felix (T CED SES-DE) ; isar- >> users@googlegroups.com >> Subject: Re: [PATCH 1/1] add support to set KBUILD_BUILD_TIMESTAMP for >> custom kernels >> >> On 21.03.22 15:40, Felix Moessbauer wrote: >>> This patch adds the infrastructure to overwrite the >>> KBUILD_BUILD_TIMESTAMP environment variable for custom kernel builds. >>> By that, we improve the support for reproducible kernel builds. >>> >> >> Agreed. >> >>> Setting this to a fixed string further helps to profit from ccache >>> caching on repeated builds. >> >> Hmm, but the practical impact of this variable should have been limited /wrt >> ccache. I was seeing significant build-time reduction before the commit already. > > Yes, but of course depends on configuration. > >> >>> >>> Signed-off-by: Felix Moessbauer >>> --- >>> meta/recipes-kernel/linux/files/debian/isar/build.tmpl | 1 + >>> meta/recipes-kernel/linux/files/debian/isar/common.tmpl | 2 ++ >>> meta/recipes-kernel/linux/linux-custom.inc | 3 +++ >>> 3 files changed, 6 insertions(+) >>> >>> diff --git a/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>> b/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>> index b7749cec..32d2eb23 100644 >>> --- a/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>> +++ b/meta/recipes-kernel/linux/files/debian/isar/build.tmpl >>> @@ -34,6 +34,7 @@ print_settings() { >>> # --------------- >>> # ARCH=${ARCH} >>> # CROSS_COMPILE=${CROSS_COMPILE} >>> +# KBUILD_BUILD_TIMESTAMP=${KBUILD_BUILD_TIMESTAMP} >>> EOF >>> } >>> >>> diff --git a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>> b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>> index b7752fb6..ffe84745 100644 >>> --- a/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>> +++ b/meta/recipes-kernel/linux/files/debian/isar/common.tmpl >>> @@ -7,6 +7,7 @@ ARCH=${KERNEL_ARCH} >>> KERNEL_PKG_IMAGE=linux-image-${KERNEL_NAME_PROVIDED} >>> KERNEL_PKG_KERN_HEADERS=linux-headers-${KERNEL_NAME_PROVIDED} >>> KERNEL_PKG_LIBC_HEADERS=linux-libc-dev >>> +KBUILD_BUILD_TIMESTAMP="${KBUILD_BUILD_TIMESTAMP}" >>> >>> # Constants >>> KCONF=.config >>> @@ -36,6 +37,7 @@ main() { >>> >>> # variables to be exported >>> export ARCH >>> + export KBUILD_BUILD_TIMESTAMP >>> >>> # are we cross-compiling? >>> BUILD_ARCH=$(dpkg-architecture -qDEB_BUILD_ARCH) diff --git >>> a/meta/recipes-kernel/linux/linux-custom.inc >>> b/meta/recipes-kernel/linux/linux-custom.inc >>> index 8a5dbf82..f8e87453 100644 >>> --- a/meta/recipes-kernel/linux/linux-custom.inc >>> +++ b/meta/recipes-kernel/linux/linux-custom.inc >>> @@ -33,6 +33,8 @@ KERNEL_HEADERS_DEBIAN_DEPENDS ?= "libc6, \ >>> >>> KERNEL_LIBC_DEV_DEPLOY ?= "0" >>> >>> +KBUILD_BUILD_TIMESTAMP ??= "LANG=C $(date)" >> >> Can't we use SOURCE_DATE_EPOCH like the rest? > > This variable is still not honored by the kernel (AFAIK). > Also the kernel documentation only mentions KBUILD_BUILD_TIMESTAMP. > There is a patch from 2015 which has not been applied [1]. > > We could do the mapping in ISAR, but I prefer to have it explicit. > > [1] https://patchwork.kernel.org/project/linux-kbuild/patch/1443741332.2730.75.camel@decadent.org.uk/ > Then how does the regular Debian kernel set a stable date? We should align to that and surely not force the user to set anything manually (that is my interpretation of the behavior of the current patch). Jan -- Siemens AG, Technology Competence Center Embedded Linux