From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6543570718688280576 X-Received: by 10.28.135.140 with SMTP id j134mr1974407wmd.6.1525365020415; Thu, 03 May 2018 09:30:20 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:98f6:: with SMTP id w109-v6ls3716821wrb.2.gmail; Thu, 03 May 2018 09:30:19 -0700 (PDT) X-Google-Smtp-Source: AB8JxZo1UKXNRb+DjSnoH5EswJPSU5FK3lKcw1WtFLsjBV4MR3bNY7J78oI62DpvGThMda1AhVcI X-Received: by 2002:adf:82a6:: with SMTP id 35-v6mr2062334wrc.30.1525365019780; Thu, 03 May 2018 09:30:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525365019; cv=none; d=google.com; s=arc-20160816; b=MWdENbo1iQLSWlcnPFZYqgCzRK9VdKsubNxjS6Re3Ci9+yOJu4x7nbx0oD+0BH5EqT 2kfh2sosDbvLMLF/00Rgnyp2DTRk63RUckmKEpzBd6hP0/7ogw68hdEgXzGwdXExMEoV f/G/Moya+EO9SMr4ux7djAcupclNeyvMJHdGGVKJPL2Ggd6EFXgG3rifPTJ1FeDUL4yf 5Unr7dp7c6RyUwsvC/Q9ISCb7wEhBRabpSmeQbHZvc7eFHzl93G0H1awEOtlx9vbtp1C QlnvYtoDPCR7iazyuEb7SAcxikRbht3maa/1etCdMxtZ9OefoqztTWBVoEuzbRfVyIPi om/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=R/kRC4asoCWnFWYPyYE37aoOlsp+Qg8HIGStZ0GJ+qo=; b=rNCVRxW3xqsKviRQXjIvmjScjFY0KQc0bhKK9Bcal4eZ+22GGWQsXLgzjWkLm/XK0m 14WiKNdeHrsHfQA0zKLi7u93w1DIx7oBg2BWyZ2m9KQQrgTbID6CYagm5nESz2r1aqUW ZDZJxcOosEdzG2ObjExRrGhgbpdksvYBXNHUysL2nh5LNsF9jPqtPeYzeKIeZUYMxVkY WkpxTY5wOMCduYUZL1ak4w0GN1XyvtBjVb/5qSrxOlDnq/ia7h4Fo8saldT/UZDXwnJj 4OY948+K8Il7DmyC0wT4DZyNKs4HOmdGWBBvdd9F8Au8U3MjaLzI2vYg54spDMxptyzV HA8Q== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id m80-v6si107851wmb.1.2018.05.03.09.30.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 May 2018 09:30:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id w43GUFVQ027625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 3 May 2018 18:30:17 +0200 Subject: Re: [PATCH 1/1] meta-isar/isar-image-base: make kernel optional To: Henning Schild Cc: isar-users@googlegroups.com References: <20180412143614.31202-1-claudius.heine.ext@siemens.com> <20180412143614.31202-2-claudius.heine.ext@siemens.com> <20180413103820.GC6488@yssyq.radix50.net> <20180503175819.15695d54@md1pvb1c.ad001.siemens.net> <41086dec-f797-faa1-8b8b-6fdeaf83f211@ilbers.de> <20180503182709.44044eeb@md1pvb1c.ad001.siemens.net> From: Alexander Smirnov Message-ID: Date: Thu, 3 May 2018 19:30:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180503182709.44044eeb@md1pvb1c.ad001.siemens.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 75qrvliE90v3 On 05/03/2018 07:27 PM, Henning Schild wrote: > Am Thu, 3 May 2018 19:18:42 +0300 > schrieb Alexander Smirnov : > >> On 05/03/2018 06:58 PM, Henning Schild wrote: >>> Am Fri, 13 Apr 2018 12:38:20 +0200 >>> schrieb Baurzhan Ismagulov : >>> >>>> On Thu, Apr 12, 2018 at 04:36:14PM +0200, >>>> claudius.heine.ext@siemens.com wrote: >>>>> diff --git a/meta-isar/recipes-core/images/isar-image-base.bb >>>>> b/meta-isar/recipes-core/images/isar-image-base.bb index >>>>> 6b0030b..d39a25e 100644 --- >>>>> a/meta-isar/recipes-core/images/isar-image-base.bb +++ >>>>> b/meta-isar/recipes-core/images/isar-image-base.bb @@ -16,7 +16,7 >>>>> @@ PV = "1.0" inherit image >>>>> inherit isar-bootstrap-helper >>>>> >>>>> -IMAGE_INSTALL += "linux-image-${KERNEL_NAME}" >>>>> +IMAGE_INSTALL += "${@ ("linux-image-" + d.getVar("KERNEL_NAME", >>>>> True)) if d.getVar("KERNEL_NAME", True) else ""}" >>>> >>>> If I want to generate an NFS rootfs w/o the kernel and an SD image >>>> with one, how would I proceed? Do I understand correctly, the >>>> latter recipe would list this line, and the former would not? >>> >>> I think the answer would be with two image recipes that >>> inherit/override each other. So the main one that is probably >>> derived from isar-image-base and would be called product-nfs.bb and >>> product-wic.bb would overwrite some variables from the -nfs version. >>> >>> That patch should be merged, i already heard from someone else who >>> now cherry-picked that into their fork. >> >> Started test build, will apply afterwards. >> >> But, I've looked at this patch again, and I think that this line >> should go to image class instead of recipe, it's already generic >> enough. Otherwise you have to copy this magic expression to every new >> image recipe (if you not inherit isar-image-base). > > Ok, i just wanted to vote for the cause, not the implementation. > This patch will stay as it is, for sure :-) Alex