Re: [PATCH v3 1/8] isar-boostrap-helper: move 'HOST_ARCH' and 'HOST_DISTRO' to base.bbclass

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi,

On 24/04/2019 11.27, [ext] claudius.heine.ext@siemens.com wrote:
> From: Claudius Heine <ch@denx.de>
> 
> This also sets the 'HOST_DISTRO' to 'DISTRO' per default. (jessie
> support was dropped.)
> 
> Signed-off-by: Claudius Heine <ch@denx.de>
> ---
>   meta/classes/base.bbclass                  |  9 +++++++++
>   meta/classes/isar-bootstrap-helper.bbclass | 12 ------------
>   2 files changed, 9 insertions(+), 12 deletions(-)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index 9a1837f..ca80bf8 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -20,6 +20,15 @@
>   
>   THISDIR = "${@os.path.dirname(d.getVar('FILE', True))}"
>   
> +def get_deb_host_arch():
> +    import subprocess
> +    host_arch = subprocess.check_output(
> +        ["dpkg", "--print-architecture"]
> +    ).decode('utf-8').strip()
> +    return host_arch
> +HOST_ARCH ??= "${@get_deb_host_arch()}"
> +HOST_DISTRO ??= "${DISTRO}"

I did find in issue here when debugging.
In case of raspbian-stretch HOST_DISTRO needs to be 'debian-stretch'.

I corrected that for the next version of this patchset.

Currently the same issue in CI issue now reoccurs with the 
'isar-bootstrap/buildchroot/sdkchroot: refactor PF and WORKDIR' patch 
though.

I am currently investigating that.

Claudius

> +
>   die() {
>   	bbfatal "$*"
>   }
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
> index 38d90fb..59c447b 100644
> --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -7,18 +7,6 @@
>   
>   IMAGE_TRANSIENT_PACKAGES ??= ""
>   
> -def get_deb_host_arch():
> -    import subprocess
> -    host_arch = subprocess.check_output(
> -        ["dpkg", "--print-architecture"]
> -    ).decode('utf-8').strip()
> -    return host_arch
> -
> -#Debian Distribution for SDK host
> -HOST_DISTRO ?= "debian-stretch"
> -#Determine SDK host architecture if not explicitly set
> -HOST_ARCH ?= "${@get_deb_host_arch()}"
> -
>   HOST_DISTRO_APT_SOURCES += "conf/distro/${HOST_DISTRO}.list"
>   
>   def reverse_bb_array(d, varname):
> 

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de