public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH 1/1] always add architecture to binary packages in manifest
@ 2025-10-13 12:15 'Felix Moessbauer' via isar-users
  2025-10-23  7:57 ` Zhihang Wei
  0 siblings, 1 reply; 2+ messages in thread
From: 'Felix Moessbauer' via isar-users @ 2025-10-13 12:15 UTC (permalink / raw)
  To: isar-users
  Cc: christoph.steiger, gernot.hillier, cedric.hombourger, Felix Moessbauer

The manifest file contains the source / binary package relation and is
helpful for license clearing. However, the binary package is only
annotated with an architecture specified (:<arch>) if it otherwise
cannot be uniquely identified on the generating system. As the consumer
of that data is on a different system, this is not helpful. We now
explicitly add the architecture specifier so that downstream consumers
do not have to guess.

Despite this slightly changes the output format, we don't consider this
a breaking change, as the downstream consume anyways could not know
which packages get the architecture specifier and which not, as this
only depends on the package list of the target rootfs.

Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
---
 meta/classes/rootfs.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index 12227db1..65779248 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -399,7 +399,7 @@ rootfs_generate_manifest () {
     mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}
     sudo -E chroot --userspec=$(id -u):$(id -g) '${ROOTFSDIR}' \
         dpkg-query -W -f \
-            '${source:Package}|${source:Version}|${binary:Package}|${Version}\n' > \
+            '${source:Package}|${source:Version}|${Package}:${Architecture}|${Version}\n' > \
         '${ROOTFS_MANIFEST_DEPLOY_DIR}'/'${ROOTFS_PACKAGE_SUFFIX}'.manifest
 }
 
-- 
2.51.0

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251013121540.388740-1-felix.moessbauer%40siemens.com.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] always add architecture to binary packages in manifest
  2025-10-13 12:15 [PATCH 1/1] always add architecture to binary packages in manifest 'Felix Moessbauer' via isar-users
@ 2025-10-23  7:57 ` Zhihang Wei
  0 siblings, 0 replies; 2+ messages in thread
From: Zhihang Wei @ 2025-10-23  7:57 UTC (permalink / raw)
  To: Felix Moessbauer, isar-users
  Cc: christoph.steiger, gernot.hillier, cedric.hombourger

Applied to next, thanks.

Best regards,
Zhihang

On 10/13/25 14:15, 'Felix Moessbauer' via isar-users wrote:
> The manifest file contains the source / binary package relation and is
> helpful for license clearing. However, the binary package is only
> annotated with an architecture specified (:<arch>) if it otherwise
> cannot be uniquely identified on the generating system. As the consumer
> of that data is on a different system, this is not helpful. We now
> explicitly add the architecture specifier so that downstream consumers
> do not have to guess.
>
> Despite this slightly changes the output format, we don't consider this
> a breaking change, as the downstream consume anyways could not know
> which packages get the architecture specifier and which not, as this
> only depends on the package list of the target rootfs.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> ---
>   meta/classes/rootfs.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index 12227db1..65779248 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -399,7 +399,7 @@ rootfs_generate_manifest () {
>       mkdir -p ${ROOTFS_MANIFEST_DEPLOY_DIR}
>       sudo -E chroot --userspec=$(id -u):$(id -g) '${ROOTFSDIR}' \
>           dpkg-query -W -f \
> -            '${source:Package}|${source:Version}|${binary:Package}|${Version}\n' > \
> +            '${source:Package}|${source:Version}|${Package}:${Architecture}|${Version}\n' > \
>           '${ROOTFS_MANIFEST_DEPLOY_DIR}'/'${ROOTFS_PACKAGE_SUFFIX}'.manifest
>   }
>   

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c18ea478-10c4-40b6-81a1-7e7696385100%40ilbers.de.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-10-23  7:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-13 12:15 [PATCH 1/1] always add architecture to binary packages in manifest 'Felix Moessbauer' via isar-users
2025-10-23  7:57 ` Zhihang Wei

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox