public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: isar-users@googlegroups.com
Cc: Alexander Smirnov <asmirnov@ilbers.de>,
	Henning Schild <henning.schild@siemens.com>
Subject: [PATCH 1/2] meta: dpkg-base: rename 'install' to 'deploy_deb'
Date: Fri, 15 Sep 2017 13:31:17 +0200	[thread overview]
Message-ID: <c19b463dc33a5cade9cef8cae3ccd89c7541c038.1505474867.git.henning.schild@siemens.com> (raw)

Issue:
The task name 'install' is a well known name from OE, gentoo, and other
similar build-systems. But in Isar it is used in a completely different
context, that might confuse Isar users. And we can not use the name for
what people would expect, as long as it is taken.

Change:
Rename the task.

Impact:
This patch does not change the behaviour of Isar. It just addresses the
issue.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 doc/technical_overview.md      | 2 +-
 meta/classes/dpkg-base.bbclass | 8 ++++----
 meta/classes/image.bbclass     | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/technical_overview.md b/doc/technical_overview.md
index f8ed9ee..c73cf08 100644
--- a/doc/technical_overview.md
+++ b/doc/technical_overview.md
@@ -190,7 +190,7 @@ Both consist of the following steps:
 	without compiling anything
 
 
-5. Task `do_install`: install successfully built packages
+5. Task `do_deploy_deb`: install successfully built packages
    `${WORKDIR}/*.deb` to deploy directory `${DEPLOY_DIR_DEB}`
 
 ## 3.5 Populate Target Filesystem
diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass
index 2402858..9ded3ae 100644
--- a/meta/classes/dpkg-base.bbclass
+++ b/meta/classes/dpkg-base.bbclass
@@ -27,10 +27,10 @@ do_build() {
 }
 
 # Install package to dedicated deploy directory
-do_install() {
+do_deploy_deb() {
     install -m 644 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/
 }
 
-addtask install after do_build
-do_install[dirs] = "${DEPLOY_DIR_DEB}"
-do_install[stamp-extra-info] = "${MACHINE}"
+addtask deploy_deb after do_build
+do_deploy_deb[dirs] = "${DEPLOY_DIR_DEB}"
+do_deploy_deb[stamp-extra-info] = "${MACHINE}"
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 590725c..5bf9524 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -28,4 +28,4 @@ do_populate() {
 }
 
 addtask populate before do_build
-do_populate[deptask] = "do_install"
+do_populate[deptask] = "do_deploy_deb"
-- 
2.13.5


             reply	other threads:[~2017-09-15 11:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 11:31 Henning Schild [this message]
2017-09-15 11:31 ` [PATCH 2/2] meta: dpkg-raw: rename 'populate_package' to 'install' Henning Schild
2017-09-19 15:15 ` [PATCH 1/2] meta: dpkg-base: rename 'install' to 'deploy_deb' Alexander Smirnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c19b463dc33a5cade9cef8cae3ccd89c7541c038.1505474867.git.henning.schild@siemens.com \
    --to=henning.schild@siemens.com \
    --cc=asmirnov@ilbers.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox