From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6465966180629741568 X-Received: by 10.28.165.70 with SMTP id o67mr295712wme.10.1505475067979; Fri, 15 Sep 2017 04:31:07 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.11.203 with SMTP id 194ls277909wml.6.canary-gmail; Fri, 15 Sep 2017 04:31:07 -0700 (PDT) X-Google-Smtp-Source: AOwi7QBvAmqaON5Gr1ugJw655oXTDImwvwp0FZW/ge+S0E8zX6mSqpDJPq0uf95FDvau0xJd4V2V X-Received: by 10.28.35.142 with SMTP id j136mr298320wmj.1.1505475067602; Fri, 15 Sep 2017 04:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505475067; cv=none; d=google.com; s=arc-20160816; b=MQ+k+6+G+mf7mRozJPvDRnBb0NADA10VzXWxfHfg+IFLSdo8g5VUsnLf7Srofsb56c B5Iz8XL5A4nKXpG810BAjaGN/KjevpzhFT1atcX9ojrsPA89nNQAnii3aVIsesckhheG WjYizLx4BAbxwd/+bqphUpnEkSYcnXNY5EI+fuLIevbUjH0cxiI8TddC0Q/bHMnTsPfh 9KfnFeHgMgS35tcd33uwGcjVPEAeCdb8ln5/duWpA95ttELNLVyzHulRTTP20MGke8ar yEf8qF+EP/JCpXMEH888NJ1/69ndikEhX2JMJEm0ja6tlMxqZaZSPTJtjshtEQGKm2ov JRug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=d4OaYIOnd1aLExfOICI+oCNMZwKwlJ6A/SrCmWDdJ/s=; b=xZfKA9ebnhpMQgTobqdvfvVGB4BwdTSMCizL7gG/Jxu/D1YiCl/PtRr1fwxg6brzH9 v3GQXtRg/zg6BKDN4cZDvu6qaZThJ48vDrjtTHl9w/e4p0BMQ0FDthI7l9YYrvlhsVPM AY1zRZ94qhekKzLDr9Q2HvU2sqtRZVogLjWenGcNnpD5xlKS/4ZleRTf3JQKM9WYM7jU 5QBZuOqlEb0Q29H9Ow/BkLdpVvH3JgR7gJD9izVsTxtMbjkPaXORHomY3KpOSwf00clF LpM3M40NA7dO24Fr2p7fCwyVzltw109u3Zr9AQ0MgdzQ3cmy4c5hWcoEBXeyroPQQJLe DMdg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id a21si13092wme.2.2017.09.15.04.31.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Sep 2017 04:31:07 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.28 is neither permitted nor denied by best guess record for domain of henning.schild@siemens.com) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id v8FBV77b016472 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Sep 2017 13:31:07 +0200 Received: from md1em3qc.ww002.siemens.net ([139.25.68.40]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id v8FBV7DE020267; Fri, 15 Sep 2017 13:31:07 +0200 From: Henning Schild To: isar-users@googlegroups.com Cc: Alexander Smirnov , Henning Schild Subject: [PATCH 1/2] meta: dpkg-base: rename 'install' to 'deploy_deb' Date: Fri, 15 Sep 2017 13:31:17 +0200 Message-Id: X-Mailer: git-send-email 2.13.5 X-TUID: 1/+A3qYt5xY2 Issue: The task name 'install' is a well known name from OE, gentoo, and other similar build-systems. But in Isar it is used in a completely different context, that might confuse Isar users. And we can not use the name for what people would expect, as long as it is taken. Change: Rename the task. Impact: This patch does not change the behaviour of Isar. It just addresses the issue. Signed-off-by: Henning Schild --- doc/technical_overview.md | 2 +- meta/classes/dpkg-base.bbclass | 8 ++++---- meta/classes/image.bbclass | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/technical_overview.md b/doc/technical_overview.md index f8ed9ee..c73cf08 100644 --- a/doc/technical_overview.md +++ b/doc/technical_overview.md @@ -190,7 +190,7 @@ Both consist of the following steps: without compiling anything -5. Task `do_install`: install successfully built packages +5. Task `do_deploy_deb`: install successfully built packages `${WORKDIR}/*.deb` to deploy directory `${DEPLOY_DIR_DEB}` ## 3.5 Populate Target Filesystem diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass index 2402858..9ded3ae 100644 --- a/meta/classes/dpkg-base.bbclass +++ b/meta/classes/dpkg-base.bbclass @@ -27,10 +27,10 @@ do_build() { } # Install package to dedicated deploy directory -do_install() { +do_deploy_deb() { install -m 644 ${WORKDIR}/*.deb ${DEPLOY_DIR_DEB}/ } -addtask install after do_build -do_install[dirs] = "${DEPLOY_DIR_DEB}" -do_install[stamp-extra-info] = "${MACHINE}" +addtask deploy_deb after do_build +do_deploy_deb[dirs] = "${DEPLOY_DIR_DEB}" +do_deploy_deb[stamp-extra-info] = "${MACHINE}" diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index 590725c..5bf9524 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -28,4 +28,4 @@ do_populate() { } addtask populate before do_build -do_populate[deptask] = "do_install" +do_populate[deptask] = "do_deploy_deb" -- 2.13.5