From: Uladzimir Bely <ubely@ilbers.de>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Cc: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Subject: Re: [PATCH] multiarch: Add missing space in BPN append
Date: Mon, 18 Mar 2024 16:06:05 +0300 [thread overview]
Message-ID: <c1d3938868687d6d3cb3201f9f7b940360da6585.camel@ilbers.de> (raw)
In-Reply-To: <20240314085620.3866335-1-amikan@ilbers.de>
On Thu, 2024-03-14 at 10:56 +0200, Anton Mikanovich wrote:
> Adding values must be done with a leading space.
>
> Fixes: f50237eb059c ("multiarch: Fix SRC_URI:remove ignoring")
> Reported-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta/classes/multiarch.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/multiarch.bbclass
> b/meta/classes/multiarch.bbclass
> index d92421d8..5783b0bf 100644
> --- a/meta/classes/multiarch.bbclass
> +++ b/meta/classes/multiarch.bbclass
> @@ -51,7 +51,7 @@ python multiarch_virtclass_handler() {
> v = d.getVar(var, expand=False)
> if v is not None and '${PN}' in v:
> d.setVar(var + ':remove', v)
> - d.appendVar(var, v.replace('${PN}', '${BPN}'))
> + d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}'))
>
> # When building compat/native, the corresponding suffix needs to
> be
> # propagated to all bitbake dependency definitions.
> --
> 2.34.1
>
Applied to next.
prev parent reply other threads:[~2024-03-18 13:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-14 8:56 Anton Mikanovich
2024-03-18 13:06 ` Uladzimir Bely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1d3938868687d6d3cb3201f9f7b940360da6585.camel@ilbers.de \
--to=ubely@ilbers.de \
--cc=adriaan.schmidt@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox