public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] multiarch: Add missing space in BPN append
@ 2024-03-14  8:56 Anton Mikanovich
  2024-03-18 13:06 ` Uladzimir Bely
  0 siblings, 1 reply; 2+ messages in thread
From: Anton Mikanovich @ 2024-03-14  8:56 UTC (permalink / raw)
  To: isar-users; +Cc: Anton Mikanovich, Adriaan Schmidt

Adding values must be done with a leading space.

Fixes: f50237eb059c ("multiarch: Fix SRC_URI:remove ignoring")
Reported-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
 meta/classes/multiarch.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/multiarch.bbclass b/meta/classes/multiarch.bbclass
index d92421d8..5783b0bf 100644
--- a/meta/classes/multiarch.bbclass
+++ b/meta/classes/multiarch.bbclass
@@ -51,7 +51,7 @@ python multiarch_virtclass_handler() {
             v = d.getVar(var, expand=False)
             if v is not None and '${PN}' in v:
                 d.setVar(var + ':remove', v)
-                d.appendVar(var, v.replace('${PN}', '${BPN}'))
+                d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}'))
 
     # When building compat/native, the corresponding suffix needs to be
     # propagated to all bitbake dependency definitions.
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] multiarch: Add missing space in BPN append
  2024-03-14  8:56 [PATCH] multiarch: Add missing space in BPN append Anton Mikanovich
@ 2024-03-18 13:06 ` Uladzimir Bely
  0 siblings, 0 replies; 2+ messages in thread
From: Uladzimir Bely @ 2024-03-18 13:06 UTC (permalink / raw)
  To: Anton Mikanovich, isar-users; +Cc: Adriaan Schmidt

On Thu, 2024-03-14 at 10:56 +0200, Anton Mikanovich wrote:
> Adding values must be done with a leading space.
> 
> Fixes: f50237eb059c ("multiarch: Fix SRC_URI:remove ignoring")
> Reported-by: Adriaan Schmidt <adriaan.schmidt@siemens.com>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
>  meta/classes/multiarch.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/multiarch.bbclass
> b/meta/classes/multiarch.bbclass
> index d92421d8..5783b0bf 100644
> --- a/meta/classes/multiarch.bbclass
> +++ b/meta/classes/multiarch.bbclass
> @@ -51,7 +51,7 @@ python multiarch_virtclass_handler() {
>              v = d.getVar(var, expand=False)
>              if v is not None and '${PN}' in v:
>                  d.setVar(var + ':remove', v)
> -                d.appendVar(var, v.replace('${PN}', '${BPN}'))
> +                d.appendVar(var, ' ' + v.replace('${PN}', '${BPN}'))
>  
>      # When building compat/native, the corresponding suffix needs to
> be
>      # propagated to all bitbake dependency definitions.
> -- 
> 2.34.1
> 

Applied to next.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-18 13:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-14  8:56 [PATCH] multiarch: Add missing space in BPN append Anton Mikanovich
2024-03-18 13:06 ` Uladzimir Bely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox