[PATCH] meta/classes/crossvars: use variable instead of getting value via d.getVar

[PATCH] meta/classes/crossvars: use variable instead of getting value via d.getVar

[srinuvasan.a via isar-users]

From: Srinuvasan A <srinuvasan.a@siemens.com>

Already we are getting COMPAT_DISTRO_ARCH value in compat_arch variable,
try to use the variable wherever it is applicable.

Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
---
 meta/classes/crossvars.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass
index 1a88d457..0a135a91 100644
--- a/meta/classes/crossvars.bbclass
+++ b/meta/classes/crossvars.bbclass
@@ -38,6 +38,6 @@ python __anonymous() {
     d.setVar('SCHROOT_DIR', schroot_dir + flavor_suffix)
     d.setVar('SCHROOT_DEP', sbuild_dep)
     if isar_can_build_compat(d):
-        sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH')
+        sdk_toolchain += " crossbuild-essential-" + compat_arch
     d.setVar('SDK_TOOLCHAIN', sdk_toolchain)
 }
-- 
2.34.1

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250117102737.259735-1-srinuvasan.a%40siemens.com.

Re: [PATCH] meta/classes/crossvars: use variable instead of getting value via d.getVar

['Jan Kiszka' via isar-users]

On 17.01.25 11:27, srinuvasan.a via isar-users wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Already we are getting COMPAT_DISTRO_ARCH value in compat_arch variable,
> try to use the variable wherever it is applicable.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/crossvars.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/crossvars.bbclass b/meta/classes/crossvars.bbclass
> index 1a88d457..0a135a91 100644
> --- a/meta/classes/crossvars.bbclass
> +++ b/meta/classes/crossvars.bbclass
> @@ -38,6 +38,6 @@ python __anonymous() {
>      d.setVar('SCHROOT_DIR', schroot_dir + flavor_suffix)
>      d.setVar('SCHROOT_DEP', sbuild_dep)
>      if isar_can_build_compat(d):
> -        sdk_toolchain += " crossbuild-essential-" + d.getVar('COMPAT_DISTRO_ARCH')
> +        sdk_toolchain += " crossbuild-essential-" + compat_arch
>      d.setVar('SDK_TOOLCHAIN', sdk_toolchain)
>  }

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks,
Jan

-- 
Siemens AG, Foundational Technologies
Linux Expert Center

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/5faf4687-1db9-491d-a7ff-fee207976c5e%40siemens.com.

Re: [PATCH] meta/classes/crossvars: use variable instead of getting value via d.getVar

[Uladzimir Bely]

On Fri, 2025-01-17 at 15:57 +0530, srinuvasan.a@siemens.com wrote:
> From: Srinuvasan A <srinuvasan.a@siemens.com>
> 
> Already we are getting COMPAT_DISTRO_ARCH value in compat_arch
> variable,
> try to use the variable wherever it is applicable.
> 
> Signed-off-by: Srinuvasan A <srinuvasan.a@siemens.com>
> ---
>  meta/classes/crossvars.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/crossvars.bbclass
> b/meta/classes/crossvars.bbclass
> index 1a88d457..0a135a91 100644
> --- a/meta/classes/crossvars.bbclass
> +++ b/meta/classes/crossvars.bbclass
> @@ -38,6 +38,6 @@ python __anonymous() {
>      d.setVar('SCHROOT_DIR', schroot_dir + flavor_suffix)
>      d.setVar('SCHROOT_DEP', sbuild_dep)
>      if isar_can_build_compat(d):
> -        sdk_toolchain += " crossbuild-essential-" +
> d.getVar('COMPAT_DISTRO_ARCH')
> +        sdk_toolchain += " crossbuild-essential-" + compat_arch
>      d.setVar('SDK_TOOLCHAIN', sdk_toolchain)
>  }

Applied to next, thanks.

-- 
Best regards,
Uladzimir.



-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c21efc8bafb479a60ad431ef9b00e4e6b53665f1.camel%40ilbers.de.