Re: [PATCH v2 0/5] Unify work space for packages

[Alexander Smirnov <asmirnov@ilbers.de>]

On 09/11/2017 11:00 AM, Henning Schild wrote:
> Am Mon, 11 Sep 2017 10:36:02 +0300
> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
> 
>> On 09/08/2017 07:15 PM, Henning Schild wrote:
>>> Am Fri, 8 Sep 2017 19:10:37 +0300
>>> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
>>>    
>>>> On 09/08/2017 07:06 PM, Henning Schild wrote:
>>>>> Looks good, except for the minor things i just found.
>>>>
>>>> Thanks for the quick response. Will fix according to your
>>>> comments.
>>>
>>> You are welcome.
>>>    
>>>> Could you please re-base your series on top of this?
>>>
>>> Sure. But i would prefer to do this rebase together with addressing
>>> issues found in the review. So please provide reviews to all
>>> patches, catch up on the nameing discussions etc. and give me a
>>> green light by replying here again.
>>>    
>>
>> There is nothing more from me. Only one possible topic - names of the
>> classes. Eventually we will have at least three pipelines:
>>
>>    - Build package in chroot (current Isar flow).
>>    - Pack custom files (your proposal).
>>    - Cross-compilation for custom packages.
>>
>> So, probably we can use following names (respectively):
>>
>>    - dpkg-native.bbclass
> 
> Would that be the current dpkg.bbclass? In that case i do not like the
> name since we cross-compile with it as well.
> 
>>    - dpkg-pack.bbclass
>>    - dpkg-cross.bbclass
> 
> If we ever decide to add custom building i think it would go into the
> class my patches introduce.
> 
> So i think we will have a debian and a custom way of building debian > packages, hence the names currently suggested. Maybe best discuss this
> in the thread already opened for that.

Ok.

> 
> Henning
>   
>> Alex
>>
>>>>>
>>>>> Am Fri, 8 Sep 2017 18:56:01 +0300
>>>>> schrieb Alexander Smirnov <asmirnov@ilbers.de>:
>>>>>       
>>>>>> Hi all,
>>>>>>
>>>>>> this series does the following:
>>>>>>     - Simplifies folders structure for multiconfig.
>>>>>>     - Unifies work space for packages.
>>>>>>     - Use unified canonical names for  build artifacts.
>>>>>>
>>>>>> The overal build tree with multiconfig looks like the following:
>>>>>> $ ls -1 tmp/work/
>>>>>>     debian-jessie-amd64
>>>>>>     debian-jessie-armhf
>>>>>>     debian-jessie-i386
>>>>>>     debian-stretch-amd64
>>>>>>     debian-stretch-armhf
>>>>>>     debian-stretch-i386
>>>>>>     debian-wheezy-armhf
>>>>>>     raspbian-jessie-armhf
>>>>>>
>>>>>> Package workdir looks now like the following:
>>>>>> $ ls -1 tmp/work/debian-jessie-amd64/hello-0.1+g7f35942-1-r0/
>>>>>> git
>>>>>> hello_0.1+g7f35942-1_amd64.changes
>>>>>> hello_0.1+g7f35942-1_amd64.deb
>>>>>> hello_0.1+g7f35942-1.dsc
>>>>>> hello_0.1+g7f35942-1.tar.gz
>>>>>> temp
>>>>>>
>>>>>> Changes since v1:
>>>>>>     - Split first patch into pieces.
>>>>>>     - Use variable in multistrap config.
>>>>>>     - Rename ext4 image to unified cacnonical name (patch 4).
>>>>>>
>>>>>> With best regards,
>>>>>> Alex
>>>>>>
>>>>>> Alexander Smirnov (5):
>>>>>>      image: Unify path to image rootfs
>>>>>>      isar: Change build folders tree
>>>>>>      stamps: Name stamps canonicaly and unified
>>>>>>      image: Name image canonicaly and unified
>>>>>>      class/dpkg: Unify workplace for packages
>>>>>>
>>>>>>     meta-isar/classes/rpi-sdimg.bbclass              |  2 +-
>>>>>>     meta-isar/recipes-core/images/isar-image-base.bb | 18
>>>>>> ++++++++----------
>>>>>> meta/classes/dpkg.bbclass                        | 15
>>>>>> +++++++++------ meta/classes/ext4-img.bbclass
>>>>>> | 12 ++++++------
>>>>>> meta/classes/image.bbclass                       | 11
>>>>>> ++++++----- meta/conf/isar-bitbake.conf                      | 5
>>>>>> ++++- meta/recipes-devtools/buildchroot/buildchroot.bb |  8
>>>>>> ++++---- scripts/start_vm                                 |  2
>>>>>> +- 8 files changed, 39 insertions(+), 34 deletions(-)
>>>>>       
>>>>   
>>>    
>>
> 

-- 
With best regards,
Alexander Smirnov

ilbers GmbH
Baierbrunner Str. 28c
D-81379 Munich
+49 (89) 122 67 24-0
http://ilbers.de/
Commercial register Munich, HRB 214197
General manager: Baurzhan Ismagulov