From: Anton Mikanovich <amikan@ilbers.de>
To: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Subject: Re: [PATCH] deb-dl-dir: Fix isar-apt packages checking on export
Date: Wed, 10 Jun 2026 10:38:36 +0300 [thread overview]
Message-ID: <c2b6fc31-5f55-4c53-bc4f-fff91c3bee14@ilbers.de> (raw)
In-Reply-To: <dff69322d5dd830e658a0e706c54b72e1cf5f990.camel@siemens.com>
10.06.2026 10:29, MOESSBAUER, Felix wrote:
> On Wed, 2026-06-10 at 09:38 +0300, Anton Mikanovich wrote:
>> To use variable inside of lock section it should be exported.
>> Otherwize it will be empty and isar-apt packages checking logic will
>> not work.
> Does this mean it was incorrect before our refactorings?
> If so, please add a fixes tag.
It was probably introduced in 86f1c6e.
Will add the tag.
>
>> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
>> ---
>> meta/classes-recipe/deb-dl-dir.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes-recipe/deb-dl-dir.bbclass b/meta/classes-recipe/deb-dl-dir.bbclass
>> index 620ddc96..fde4fc44 100644
>> --- a/meta/classes-recipe/deb-dl-dir.bbclass
>> +++ b/meta/classes-recipe/deb-dl-dir.bbclass
>> @@ -149,7 +149,7 @@ deb_dl_dir_export() {
>> export owner=$(id -u):$(id -g)
>> mkdir -p "${pc}"
>>
>> - isar_debs="$(${SCRIPTSDIR}/lockrun.py -r -f '${REPO_ISAR_DIR}/isar.lock' -c \
>> + export isar_debs="$(${SCRIPTSDIR}/lockrun.py -r -f '${REPO_ISAR_DIR}/isar.lock' -c \
>> "find '${REPO_ISAR_DIR}/${DISTRO}' -name '*.deb' -print")"
> We are running in a non ancient shell, so the quotes on the right side
> of the assignment are optional (better remove them to avoid the double
> quoting).
>
> isar_debs=$(...) instead of isar_debs="$(...)"
Ok, why not.
>
> Felix
>
>>
>> flock "${pc}".lock sudo -Es << 'EOSUDO'
>> --
>> 2.34.1
>>
>> --
>> You received this message because you are subscribed to the Google Groups "isar-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
>> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20260610063806.4010352-1-amikan%40ilbers.de.
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c2b6fc31-5f55-4c53-bc4f-fff91c3bee14%40ilbers.de.
prev parent reply other threads:[~2026-06-10 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 6:38 Anton Mikanovich
2026-06-10 7:29 ` 'MOESSBAUER, Felix' via isar-users
2026-06-10 7:38 ` Anton Mikanovich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2b6fc31-5f55-4c53-bc4f-fff91c3bee14@ilbers.de \
--to=amikan@ilbers.de \
--cc=felix.moessbauer@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox