From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6724322178273116160 X-Received: by 2002:a19:f711:: with SMTP id z17mr13029862lfe.4.1566241217637; Mon, 19 Aug 2019 12:00:17 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:b60e:: with SMTP id r14ls1793681ljn.13.gmail; Mon, 19 Aug 2019 12:00:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqw3vKlpEE4ajLWvhWkDCWy2eb0ZnWd+JewkP69OzwELgsO9cdoQNQs+z9VFHIETG7qh2k69 X-Received: by 2002:a2e:8116:: with SMTP id d22mr13546584ljg.178.1566241216993; Mon, 19 Aug 2019 12:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566241216; cv=none; d=google.com; s=arc-20160816; b=JoL/eqeBs2i8iYN/CDjGjAOOC2lu+LjOdu6ebuXMnhGkS4kwf1luMfo2nYi44tLAjK cf0IGR544lvQMK9/FOVKTRftpUhqGrg4eLC7a/jWiuElQ6Jt2EBT6HqPo4F7OcX6HxTz VoRQ51dNLaHKskKYfxsw+pqtran2deHFGJpOLY4u8OckGKsvfI+Hbl3foiZIiFz5DZ7F SqcPvoPn7Q/VEY2XfslHOZvM9WMWeikzNyG3cl1LdytJI3BnDJFM+U+dCHvz4JAmsatj U7IxRfnIw8VLVb7luRxbbWpU8LmZ2tqlqT1M1UsSTPh343GW2BTqVOxbHFaL7u3/rksp hsFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject; bh=tigWyWdbtXbvuok+xXd95SnPfQFp+Moxp1eXTgSvxFM=; b=0KQAELjVzVTHbgQlI17n2znE8nD0jhjRaUEmDrwP0W6FajfXjtqlgbxw4qewluyhsu McXVol3TEWeYgp0RbKoQF9hryGyRqg0yal0BTXPo0fQ9R9SNU/fXW6W4CK8pY6jLSVmd dGiKfE33OUkEE3r3UqdjQY8qXMxaIdR42sBkQwv6+pt4EWhkXeVNYS/2K/LlQ7GO3Yeh mwaAm4Vs62reK9O8+OqbTUFbcyVlxJF/blGuRGWWrH13FhBEk4+3SJ2z6FRD9q5S2iy9 0bVj36imMF7qjmg38+X6NXL/xUWaW0Kk7lq8ef8C0Aop+6UFLV7utUTyPNX0VMoyR8bz 0awg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id u10si833497lfk.0.2019.08.19.12.00.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 12:00:16 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x7JJ0FTj000519 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 21:00:15 +0200 Received: from [139.22.33.9] ([139.22.33.9]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x7JJ0FqX017415; Mon, 19 Aug 2019 21:00:15 +0200 Subject: Re: [PATCH v2] Set STAMPCLEAN variable From: Jan Kiszka To: Claudius Heine , isar-users References: <52fdf0b1-a06e-aaed-fd69-da515ebf0ec4@siemens.com> Message-ID: Date: Mon, 19 Aug 2019 21:00:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: PCIrNaPial9l On 14.08.19 16:17, [ext] Jan Kiszka wrote: > On 14.08.19 16:10, Claudius Heine wrote: >> Hi Jan, >> >> you probably mean v3. > > Yes, sorry. > >> >> On 14/08/2019 14.39, Jan Kiszka wrote: >>> This ensures that stamp files are cleaned when a task is rebuilt. Not >>> providing this pattern likely caused a lot of failures when doing >>> partial rebuilds. >>> >>> As we are at it, switch do_clean to STAMPCLEAN as well. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>>   meta/classes/base.bbclass | 4 ++-- >>>   meta/conf/bitbake.conf    | 1 + >>>   2 files changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >>> index ca80bf8..b6638ca 100644 >>> --- a/meta/classes/base.bbclass >>> +++ b/meta/classes/base.bbclass >>> @@ -206,8 +206,8 @@ python do_clean() { >>>       workdir = d.expand("${WORKDIR}") >>>       subprocess.check_call(["sudo", "rm", "-rf", workdir]) >>> -    stamppath = bb.data.expand(d.getVar('STAMP', False), d) >>> -    stampdirs = glob.glob(stamppath + ".*") >>> +    stampclean = bb.data.expand(d.getVar('STAMPCLEAN', False), d) >>> +    stampdirs = glob.glob(stampclean) >>>       subprocess.check_call(["sudo", "rm", "-rf"] + stampdirs) >>>   } >>> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf >>> index 3d18223..ee86ee0 100644 >>> --- a/meta/conf/bitbake.conf >>> +++ b/meta/conf/bitbake.conf >>> @@ -36,6 +36,7 @@ S = "${WORKDIR}/${P}" >>>   AUTOREV = "${@bb.fetch2.get_autorev(d)}" >>>   SRC_URI = "file://${FILE}" >>>   STAMP = "${TMPDIR}/stamps/${PF}" >>> +STAMPCLEAN = "${TMPDIR}/stamps/${PN}-*" >> >> What I did come across when looking at the commit messages of OE was, >> that they used to have all stamps in just one directory. They changed >> that, because they and problems when a recipe name 'recipe-1.2.3' >> removing stamps from a recipe named 'recipe-name-4.5.6'. >> >> Maybe we should really copy what current OE upstream does. >> >> Like this: >> >>    STAMPS_DIR ?= "${TMPDIR}/stamps" >>    STAMP = "${STAMPS_DIR}/${PN}/${PV}-${PR}" >>    STAMPCLEAN = "${STAMPS_DIR}/${PN}/*-*" > > I agree that aligning makes sense, but let's to that on top. > > Jan > This one breaks CI, likely because we over-clean stamps and then race in case of parallel builds. Will examine. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux