public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "Maxim Yu. Osipov" <mosipov@ilbers.de>
To: Claudius Heine <ch@denx.de>,
	Claudius Heine <claudius.heine.ext@siemens.com>,
	isar-users@googlegroups.com
Subject: Re: [PATCH 1/2] meta-isar: Separate images per MACHINE
Date: Fri, 15 Mar 2019 12:22:32 +0100	[thread overview]
Message-ID: <c351fdd4-5b43-5ae9-8432-5279992f9d3b@ilbers.de> (raw)
In-Reply-To: <155264550626.9286.14205828919186368830@ardipi>

Hi Claudius,

I've just replied to email you sent me.

On 3/15/19 11:25 AM, Claudius Heine wrote:

<snip>

>> PF .= "-${MACHINE}"
>> PROVIDES += "isar-image-base"
> 
> Well that is not what my initial suggestion was.
> 
> If you want to use my initial suggestion and use PROVIDES then of course
> you will have to do something like this:
> 
>    PN .= "-${MACHINE}"
>    PROVIDES += "isar-image-base"

This proposal doesn't work neither.

> If you use my latest suggestion then you would have something like this:
> 
>    PF .= "-${MACHINE}"
>    WORKDIR .= "-${MACHINE}"
> 
> If you sort of start combining my code then this will not work of
> course.
> 
> Please investigate yourself what code you write does. I don't provide copy
> paste stuff in reviews, just ideas. You might be lucky if they just work by
> copy-pasting, but you might not be and have to think a bit yourself to
> make it work. If I would do that, then I would have written the patch
> myself.


Thank you for your valuable opinion.

Maxim.


-- 
Maxim Osipov
ilbers GmbH
Maria-Merian-Str. 8
85521 Ottobrunn
Germany
+49 (151) 6517 6917
mosipov@ilbers.de
http://ilbers.de/
Commercial register Munich, HRB 214197
General Manager: Baurzhan Ismagulov

  reply	other threads:[~2019-03-15 11:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 20:27 Maxim Yu. Osipov
2019-03-12 20:27 ` [PATCH 2/2] doc/user_manual: Update after images per machine separation Maxim Yu. Osipov
2019-03-14  7:14   ` Jan Kiszka
2019-03-14 11:31     ` Baurzhan Ismagulov
2019-03-14 12:08       ` Jan Kiszka
2019-03-13 16:42 ` [PATCH 1/2] meta-isar: Separate images per MACHINE Maxim Yu. Osipov
2019-03-14  7:15   ` Jan Kiszka
2019-03-14  7:21   ` Claudius Heine
2019-03-14  7:28     ` Jan Kiszka
2019-03-14  8:07       ` Claudius Heine
2019-03-14  8:20         ` Claudius Heine
2019-03-14 12:22           ` Claudius Heine
2019-03-15  9:02     ` Maxim Yu. Osipov
2019-03-15 10:25       ` Claudius Heine
2019-03-15 11:22         ` Maxim Yu. Osipov [this message]
2019-03-15 14:28         ` Baurzhan Ismagulov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c351fdd4-5b43-5ae9-8432-5279992f9d3b@ilbers.de \
    --to=mosipov@ilbers.de \
    --cc=ch@denx.de \
    --cc=claudius.heine.ext@siemens.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox