public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: "'Quirin Gylstorff' via isar-users" <isar-users@googlegroups.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
	isar-users@googlegroups.com, felix.moessbauer@siemens.com,
	cedric.hombourger@siemens.com
Subject: Re: [RFC PATCH 4/5] rootfs Add dracut to initramfs generator
Date: Fri, 5 Sep 2025 14:42:53 +0200	[thread overview]
Message-ID: <c35ee255-803f-43de-835f-8f205bf3a65a@siemens.com> (raw)
In-Reply-To: <939b27f7-aca1-4703-bbfb-5cd9dc264d7f@siemens.com>



On 9/5/25 14:30, Jan Kiszka wrote:
> On 05.09.25 13:27, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   meta/classes/rootfs.bbclass | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>> index d3fb44c9..9e02dbd1 100644
>> --- a/meta/classes/rootfs.bbclass
>> +++ b/meta/classes/rootfs.bbclass
>> @@ -7,9 +7,15 @@ ROOTFS_ARCH ?= "${DISTRO_ARCH}"
>>   ROOTFS_DISTRO ?= "${DISTRO}"
>>   
>>   def initramfs_generator_cmd(d):
>> +    rootfs_packages =  d.getVar('ROOTFS_PACKAGES') or ''
>> +    if 'dracut' in rootfs_packages:
>> +        return 'rootfs'
>>       return 'update-initramfs'
>>   
>>   def initramfs_generator_cmdline(d):
>> +    initramfs_generator_cmd =  d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMD')
>> +    if 'dracut' in initramfs_generator_cmd:
>> +        return "dracut --force /initrd.img \"$kernel_version\""
>>       return "update-initramfs -u -v -k \"$kernel_version\""
>>   
>>   ROOTFS_PACKAGES ?= ""
> 
> OK, now I see why you defined functions. But initramfs_generator_cmd can
> still be simplified by taking the first word of initramfs_generator_cmdline.
ok i will change it in a v2.

Quirin
> 
> Jan
> 

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c35ee255-803f-43de-835f-8f205bf3a65a%40siemens.com.

  reply	other threads:[~2025-09-05 12:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools 'Quirin Gylstorff' via isar-users
2025-09-05 12:25   ` 'Jan Kiszka' via isar-users
2025-09-05 12:38     ` 'Jan Kiszka' via isar-users
2025-09-05 11:27 ` [RFC PATCH 2/5] add dracut to custom kernel builds 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds 'Quirin Gylstorff' via isar-users
2025-09-05 12:29   ` 'Jan Kiszka' via isar-users
2025-09-05 11:27 ` [RFC PATCH 4/5] rootfs Add dracut to initramfs generator 'Quirin Gylstorff' via isar-users
2025-09-05 12:30   ` 'Jan Kiszka' via isar-users
2025-09-05 12:42     ` 'Quirin Gylstorff' via isar-users [this message]
2025-09-05 12:44   ` 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 5/5] initramfs: allow to set the generator command 'Quirin Gylstorff' via isar-users
2025-09-05 12:32   ` 'Jan Kiszka' via isar-users
2025-09-05 12:41     ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:52       ` 'Jan Kiszka' via isar-users
2025-09-05 13:03         ` 'Quirin Gylstorff' via isar-users

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c35ee255-803f-43de-835f-8f205bf3a65a@siemens.com \
    --to=isar-users@googlegroups.com \
    --cc=cedric.hombourger@siemens.com \
    --cc=felix.moessbauer@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=quirin.gylstorff@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox