From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6950664923339816960 X-Received: by 2002:a17:906:ad81:: with SMTP id la1mr13800223ejb.74.1618386348058; Wed, 14 Apr 2021 00:45:48 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:515:: with SMTP id m21ls33088edv.1.gmail; Wed, 14 Apr 2021 00:45:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyN0pRfGPuczbaHPa1LY/edcdBD6RcN6hSdzS8RAlWr4zkrnrE43bCcQXFf1gQybC+0ts/z X-Received: by 2002:a05:6402:34c8:: with SMTP id w8mr41184716edc.235.1618386347251; Wed, 14 Apr 2021 00:45:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1618386347; cv=pass; d=google.com; s=arc-20160816; b=h8NmGLeBcSeef/DtjjlCKjwLORU1E6SfJxH+gW8iawURC/iDohGHb6bbKxGvQROzXp bcbgKPJBGSkKQAmZS+mgZ1FjJXNQ9IzmIYciklhj4sx1zpPNZLEvqyEl7CnLZmw3A7qN 0yWa2LyvdiF6+o9BBBBoL0DcanG4rb4HJEKYbnmcxxdsOOXMOIGBwMhv9KmM9tt28y8t Sk5uxpxKWo30QBnVcdnZEXjTzoMEUvaCUe+M31O4cCd/PBv2DN0J+5C3FtkQSDRERphK ZdHCBIztg3YemeujDKxYS24fP7HP3M4CLDigewvligN/r0ES3wM7DdCFZ95+gFwD9kdJ rrHA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:content-language:in-reply-to :user-agent:date:message-id:from:references:to:subject :dkim-signature; bh=h2YKjMpTTMKGvs/7KJzBp/WbkHpXL9jI0lTTlNsUdhw=; b=MYdK3STD/8Aiyc4wLGiSuga5wc0nDWbfjyUrbhVqgXtDavmxiZyTveI6RRAsvFvlmf IlLgIwg5B45EerHv3czy4GMKPsYh1zjuu+UyhH7jXHt7fvT+yJjuucW8TbzYvJ1iZvWO KPC7EUjz7Qu/QpyFMp0dI7QXXcQ0Ynepmi+ee0gTtkvqVRWT058pDBOabAQv2mue67I2 IxfVyw7dsRqWfziWFgsRrTdw9GtPdLvhM5Od3VVjo1E8UZD8nt3DIGDqhjsDAAwGpeSF DXGnLjht1p8wnoCeRg3eA+B1R82dFw1ZwloIwg0MSTL9A5ZNnYDE5EIZ2cUSgHB8Xntq FvPQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=RbyMdphf; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.20.81 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com. [40.107.20.81]) by gmr-mx.google.com with ESMTPS id y16si1330739edq.2.2021.04.14.00.45.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Apr 2021 00:45:47 -0700 (PDT) Received-SPF: pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.20.81 as permitted sender) client-ip=40.107.20.81; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.onmicrosoft.com header.s=selector1-siemens-onmicrosoft-com header.b=RbyMdphf; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of silvano.cirujano-cuesta@siemens.com designates 40.107.20.81 as permitted sender) smtp.mailfrom=silvano.cirujano-cuesta@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjoWCsZL1+sINdqcHvPqzubnkl+uJSS/wor9h/QNzw5yQTqzzXpR3HhmfYhuRO2JaKs0xoH42KNfpIhwzhRpN/I/nKRNKVjGq187keKIEw1nOCfrSEwSvYZOhp9adrJZGN4iCFe1u1ivt7qlmJW8AUwnsTLuOvj5Z5uC++Ghs2h748msjOVBef4j+NY2hd+oA5y3y5SN9i/nsVZyJlgOM/qRxfHBdOYlsWhRHUy/L6V8crtU/Eis6iuHqXREAtkOk9qT2Wn5pTrrxsUrP+atfP9UxkFl39AO7mphrGmP6gExquMcx9bEJsvD4pbzqlUikU6lEJur/4E70Iyij2z9uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2YKjMpTTMKGvs/7KJzBp/WbkHpXL9jI0lTTlNsUdhw=; b=Y3zj9AkjakfjNTGANPvju2mMqU4Y0iRkwElyQCdw5a29xPZklX8y8i5AkRO1rudDl0pDOeFAt74tErrr2azZjxWWUfPawpav3Nlk0mr2lHRTAn484jzUtnv6yErTAtMBxygYJ/oVYbiYTnLdOaqXfCBpbNoG/aZNSpyZElP3ckDGtg+fLoVPvVK8JTKHD0nr3TW+oSyOttUvunIKIZtRGMYSKs5wrPSPtVWLJAUB8pHFAMmw5xX82huurS0QHRNA387sDJxVPpjD1VxwuxyC76K0GcmnXv0sPnA1BxlGS425UTjinw8XtKBZA2Ex8Gxmy4kh/it73iASnVNmXWqTcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.onmicrosoft.com; s=selector1-siemens-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h2YKjMpTTMKGvs/7KJzBp/WbkHpXL9jI0lTTlNsUdhw=; b=RbyMdphfi9Vd2HfYO8qPH5tsNEDcqloYaTWs2Z97Ac/baapoTtbZ77bXu+LQXikAbVyDgVkU5uguk8BY3HAPvZ3f9hW+zm1jqqqonXxDBPnrGYhvOJYOL0GSQy1jysBwnlNj+vA+r/waLerlUU/p6WtMVtq5DGDwzXnc3HHihyc= Authentication-Results: googlegroups.com; dkim=none (message not signed) header.d=none;googlegroups.com; dmarc=none action=none header.from=siemens.com; Received: from AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12a::30) by AM8PR10MB4275.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:1ee::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Wed, 14 Apr 2021 07:45:46 +0000 Received: from AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM ([fe80::4807:51a1:30ab:908b]) by AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM ([fe80::4807:51a1:30ab:908b%7]) with mapi id 15.20.4020.022; Wed, 14 Apr 2021 07:45:46 +0000 Subject: Re: [PATCH] fix: remove unneeded unconditional recipes To: Jan Kiszka , isar-users@googlegroups.com References: <20210413152607.201401-1-silvano.cirujano-cuesta@siemens.com> From: Silvano Cirujano Cuesta Message-ID: Date: Wed, 14 Apr 2021 09:45:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2001:a61:3bff:3002:8e2c:20f9:9d99:194a] X-ClientProxiedBy: AM0PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:208:3e::32) To AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:12a::30) Return-Path: silvano.cirujano-cuesta@siemens.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2001:a61:3bff:3002:8e2c:20f9:9d99:194a] (2001:a61:3bff:3002:8e2c:20f9:9d99:194a) by AM0PR02CA0019.eurprd02.prod.outlook.com (2603:10a6:208:3e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16 via Frontend Transport; Wed, 14 Apr 2021 07:45:45 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 13e80abb-6ed0-4525-8896-08d8ff19503e X-MS-TrafficTypeDiagnostic: AM8PR10MB4275: X-LD-Processed: 38ae3bcd-9579-4fd4-adda-b42e1495d55a,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +Hx2CBE5m3jluLIkydDqlPrkQ5fX/L3NnHaCz6S4YJrkJEEaSHXYtUMFxnmJGA4cFfpcK5RC6mNUkgFfFOuRb+ioKYZch61cKn9QxeeqDvlSQJExvXP5IQBEnHwkfXyFHP+RTCH6IFiq0gRPFkBE1oYf91xsfRAWJ2m8eUmtREbTgw8h3Hsi4MUDz/cjtUCgMCHQmqtT+bVw6YiywEdwqtQavD5p+69XGc5z5kL1JUcVMgq7ztjFeqdXmlY7F8CiKSISAKhgTGJ7ITeSQM4h2tjDUNVTnzAEkUiByTSl0juWP9go5XltmjgV37hADUrUNN9bg2bEIfWYWdiTyQnm/KDv5D7SVEJ5CiwnDBiA0kE0uOAhM2rg7/2Z3GEj7J8wMm/5UU28n/PxtqGR6csxzYMrWueyUu4Mn/IKx6Fz4B9lu/MJwhvNEtR7cDUu/fs4ravw1ebDG9YGM1J3hxElQa2tXPDacgDVO5RY0H7gFtBCDKPamuW/SKmhnjw6Q9xQhVMJWupPyxezhF7SckJU8aMYs5yVMjd704OCG4PVg0qfZoRqWBqCIlJecYbswdrA5QCkTyelGuZeqgjE3WgSZJUs4Z/lMR/ZSiti4+A38POG4E/zhGRMTvxcU9ZcIKzr0pNNC5Q6P/vX1rW3DwbVlDZJVUZn3PeGCZrpe9Oxgl7MAGScasZCiWbUqXB4OZFn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(366004)(136003)(376002)(346002)(396003)(16526019)(38100700002)(66556008)(66946007)(66476007)(31696002)(86362001)(186003)(478600001)(53546011)(31686004)(6666004)(2616005)(2906002)(36756003)(8676002)(316002)(83380400001)(5660300002)(8936002)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?QXhuWk5YcThHT2VMRlExNys1OWpkMDhhbVBCb3oyMkhnRVdBamdDYUoxWFMx?= =?utf-8?B?RGhKeEhRaUdLZ2JZUGRuOEJSYkZrQVBmY2NWcEVDMXNhMlJiRDZPYytkVnNF?= =?utf-8?B?RUxWejBtNGhHamJ0RjRWTk1Qb0FROEFVZUtnNHN0cEdGdDVRSWY2dGdLa2ZF?= =?utf-8?B?SHBLcGVqRGhuNTQ3aGhUMURiRVRnMkc5MThPK2NoLytjOW53ZXpqZTBMbjRR?= =?utf-8?B?NHNvb1dqSDZTcE82a0g0WXo0WkRxV0V3eVp2MElsVTlzdStzVXFFYjhqWnNt?= =?utf-8?B?WFVMRFdYUDN1cWNwMEcySWdSQ1Q0TzJKY2pmcG12OXdINDYxR0ZnWTUzbE0w?= =?utf-8?B?VFM1UFBYbEFlTElIdUJQZ3ZFT0cxVWpvUWc5UDBDVGZCQkF5dFVMTS9IVDY0?= =?utf-8?B?RnJUNjgvaUhHQ2RIQThyOGtraXh1dkpTUnNqTFlHL0x0Z096a0UvVmVmSk9O?= =?utf-8?B?VFdTWit0TXhibFhDRFBvMWxaRkF3NlRDUUI1WUpoNVpRVmx3NkJVQ3ZWeXVm?= =?utf-8?B?YkxyR2ZZSC9BS3NhY285TXY0M24vVk8xRjdxWmcxSjNSQU5wTDNqN3lQWHNk?= =?utf-8?B?RVdnTVkyTWpjQ3I0MWphUmtwTks4dDFDWllmQjlzaGRlZzVzOGNpUTRxRVJx?= =?utf-8?B?dGcxcCttQnowRXd4aG9DR0NSZGFHVjN0ei9SY2dKRVhrWTdleDl1dTdxM1Nq?= =?utf-8?B?YUtDSlBMbU5Oa0x6WlZGUVhLalpnVlNldU9OQ1NaNWFkSzlZdGtTU25rT25m?= =?utf-8?B?SXJZMlJhMURyL3VUSXgzbC9OUklEUVgyT29mZlEyKzBJbS93aGZRMFRaTjNS?= =?utf-8?B?UGpkTjV2ZTl5ZThJSGFKNjNBbmUwaGppRkVmLzVveWZjQytsN3FTSlRUYVlV?= =?utf-8?B?WGoyZWkzUjMwWmlGK29oU1pzSFZTNzA4QS9MQ0JwakNXWWR3VmdzdmZ6ZlZC?= =?utf-8?B?NGpuQlo4dnFZR3phem9QQjg2RTBNeVkrMUlvZ081bGRxbkwySUJ1bzJKZko4?= =?utf-8?B?cWdwWlZqaWdGN2ZJTGFkN1I1eS9TL3h4VElMVEJhVTBxS1Z0TEtIdHBvalQ0?= =?utf-8?B?Y01oYjJsVFJHVjlMZ05PMUJtcXVqbGQ2dW5NVkNlK3F5MEQ4ZG5lT1RTS2VG?= =?utf-8?B?cDVWYUxieUw0b0xRYnZRZEFRV0taVVNOTzM5eUc0SDgwS1p2UTJQWFJKNTVt?= =?utf-8?B?endyU1RmR1RtNkJYMkJFM3kvNEZqUk0rUmlmOHlmczlJOWgwOGNhZ0VrSG5K?= =?utf-8?B?bG9iQUNPQWdMcmNtSzliLzBROXdKMmFJMjU3ZUpseHZDNUl3Q0tYbHNPZlVx?= =?utf-8?B?cW1FZDJRaDNMUDdCUWQxZVdIU1M4eGZlODJUbHRLL040YnlwV0xzS0hmZThQ?= =?utf-8?B?L0ExdHA3dWNrbzFPTk82Y2RWYmY4ZGRiZ3ZvQnZGdWZFZ0NWVHVRMVhBSmlU?= =?utf-8?B?WHpIUUkrWjNWRjU0NHI4akhqRVJrQ0VoY1hxUGpDcWJVZXhvM1JOVUlwbFBB?= =?utf-8?B?U2dDeUtJei96ZnBEWkpFWUI2ZUpacVRLSk4zQnlqeDhvZy96M3BUdHhEMmMy?= =?utf-8?B?V2JRby9yVndGS2psYkc1d3dScGpKRStBUEhLVFJYYzB2dnQzaUNjMEdvSWU1?= =?utf-8?B?UlJsUTU5S3FwL094bmc3cnZ0Q3dTTXkxVWVYMmc0KzA1MWdSVzRwMWV1WmF0?= =?utf-8?B?dFNtT05LSi9HYWhCa3l3anVzU2tFKy9Ia0dURU1yVDFlNjI2VE9xeVJ3UVZY?= =?utf-8?B?bk9xcElqekxxaU9jVmxUZGU1WXBaWVhBR0dQeDBxQW1UNlM3OEtDMldwRTFV?= =?utf-8?B?RzR4cE9xMWZDSjM3cDVwUUxoT2VnaC9QT0RPblR1SDZuQ1E4bjNZcElLK3Bu?= =?utf-8?Q?zg0zfXSBemT0x?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13e80abb-6ed0-4525-8896-08d8ff19503e X-MS-Exchange-CrossTenant-AuthSource: AM0PR10MB2708.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Apr 2021 07:45:46.0794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tKjLV8bTL8pbkdffveDHkW/rl2jfILEf2wYZsTzVH2Y08ScATthvO/KkVWGXPaejP3MZwhh+BlJ3hUsR0wVnvsc6XaCY7GxGAQt+TG6XlAcXgEZPH4YH0umPBRpZgCIQ X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR10MB4275 X-TUID: OgOiz42DK8GH On 13/04/2021 18:01, Jan Kiszka wrote: > On 13.04.21 17:26, [ext] Silvano Cirujano Cuesta wrote: >> Commit 9c3499adf91 introduced the unconditional inclusion of the recipes >> isar-exclude-docs and isar-disable-apt-cache, but they are only needed >> for container images. >> > > In fact, are those packages truly needed or just desirable, reasonable > defaults? I was yesterday about to write "reasonable defaults"... But after having faced some difficulties to find a robust implementation to keep it, I decided to reconsider it. After having slept over it, I think IT'S NOT EVEN A REASONABLE DEFAULT 8-o It's a storage optimization that is only being used in "slim" images. Having used debian "slim" images as a size reference brought me to introduce it. So I'll send a new patch completely removing it. If we want to later on offer that optimization as an optional feature, we can do so. Silvano > > In any case, it might be worth documenting those defaults as well. They > can be overwritten (IMAGE_INSTALL_remove), but the users should be made > aware of them. > > Jan > >> Signed-off-by: Silvano Cirujano Cuesta >> --- >> meta/classes/container-img.bbclass | 2 ++ >> meta/classes/image-container-extension.bbclass | 1 - >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/container-img.bbclass b/meta/classes/container-img.bbclass >> index 79ef3e8..887d49e 100644 >> --- a/meta/classes/container-img.bbclass >> +++ b/meta/classes/container-img.bbclass >> @@ -6,6 +6,8 @@ >> # This class provides the task 'containerize_rootfs' >> # to create container images containing the target rootfs. >> >> +IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache" >> + >> do_container_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" >> do_container_image[vardeps] += "CONTAINER_FORMATS" >> do_container_image(){ >> diff --git a/meta/classes/image-container-extension.bbclass b/meta/classes/image-container-extension.bbclass >> index f693627..e26604a 100644 >> --- a/meta/classes/image-container-extension.bbclass >> +++ b/meta/classes/image-container-extension.bbclass >> @@ -6,7 +6,6 @@ >> # This class extends the image.bbclass for containerizing the root filesystem. >> >> CONTAINER_FORMATS ?= "docker-archive" >> -IMAGE_INSTALL += "isar-exclude-docs isar-disable-apt-cache" >> >> containerize_rootfs() { >> local cmd="/bin/dash" >> > -- Silvano Cirujano Cuesta -- Siemens AG, T RDA IOT SES-DE Corporate Competence Center Embedded Linux