From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6592507174472122368 X-Received: by 2002:a19:544f:: with SMTP id i76-v6mr435496lfb.18.1535794278179; Sat, 01 Sep 2018 02:31:18 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ea09:: with SMTP id i9-v6ls459073lfh.27.gmail; Sat, 01 Sep 2018 02:31:17 -0700 (PDT) X-Google-Smtp-Source: ANB0VdY9dTJ//DfF19hlt9rMCoFqc/UCMZOlp0XBniZoSdMriTBidBc8UKqE763q149qomFYkHUo X-Received: by 2002:a19:18a7:: with SMTP id 39-v6mr436881lfy.4.1535794277734; Sat, 01 Sep 2018 02:31:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535794277; cv=none; d=google.com; s=arc-20160816; b=cN7y4N7zaQihTzx6Wsu+huwaOcY9MSzmPlImkNfEiRD7tHWhaU/4k9eeEtUqH6mI3m LPwIbV/wOsvaK2EJJtJodaHVbEl1EYnc8GTjou+K9+QSHob2rj3cegZ7gQR9dmB/slC4 kR8csVj6LiKYxo4BXBExvPcDwctoWgfFAayb3ePp41Rnv+OZ4iM9buSEk97ajK6C8i72 sW4Ks9aAhrBgSv57vTbKuM/8r+JgHywRP4emBqZUZ2+O6CigOZ0nIWKoUztnqBaCyQHf hDcMz6ImaU9pF0KsDx+8KK+cUsEK5kbhbtGLTeIGxjZutHEEjhO6poDhRJcabKWPS/Az rg6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=n8Ftez3GReNkGUVi+mRZOdBiTBErRpDwsQBv0gLh+vo=; b=w+IBhlYZ3UuIKUrZf6FlZwKMjsiuTez4es7sz9jGBs6XP1Qp9t/imSgcTCQn4qylTh VRV21AJupCoXiR+t8ke4zgRw3UIQFPrs452ruVPQ3SbtXLwlMDaiofPdAK5my4TPoc6W VEkhlLeW3591VEqkwfQ8mvIY7LMLvY5ePio9ajLVoN2fhGopfcQ/fkoCEyGe8tSWlxV/ U2UbYeY1ozB/yIKCuO8+2ZSYDBFDJj+6WS3Fyzsh69MngTC0x46Vf778OvYbLTHGcd9u gV4TUhrmnrzBdNdg94UgdF3Ks9l1tzYAtInxW9403y4hGckyA03mngGs8Um0yuBthkzf A7oA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Return-Path: Received: from mout.web.de (mout.web.de. [212.227.15.4]) by gmr-mx.google.com with ESMTPS id x16-v6si340356ljj.4.2018.09.01.02.31.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Sep 2018 02:31:17 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) client-ip=212.227.15.4; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@web.de designates 212.227.15.4 as permitted sender) smtp.mailfrom=jan.kiszka@web.de Received: from [192.168.1.10] ([95.157.57.47]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MGRI8-1g9Fem1khM-00DKmA; Sat, 01 Sep 2018 11:31:16 +0200 Subject: Re: [PATCH v3 1/3] dpkg: move installation of dependencies into dpkg_prepare To: Cedric Hombourger Cc: isar-users , Maksim Osipov References: <20180822154145.07d4a2ca@md1pvb1c.ad001.siemens.net> <1535264488-128-1-git-send-email-Cedric_Hombourger@mentor.com> <3681e5f1-6401-4453-980b-585049d14329@googlegroups.com> <1e560261-edee-203b-db74-4ed5d1a35541@siemens.com> <78c2e4d4-6fff-c312-323e-582b961460d5@siemens.com> <5dcaa3ae-76be-b3b5-e1b5-926783bf9808@web.de> From: Jan Kiszka Message-ID: Date: Sat, 1 Sep 2018 11:31:05 +0200 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:iqL6wz1XuYohp2ACGXzBlC0YUG+FPGpyOnB+YNxx4dRrUj/22Xl Zd12lpQ2tQ4Uw3jTYFt3dN8nlnD298VEXZN1sELHPuzH4vah6Y0YX3ZWT60wtYedLi1PdwK TLs895/mLsTg6owW5lgqfN/kKeZH2rmvYT427vUpvxo3aQs+SC++31M6MSd1qfy6vl5DPGa hEvKm943Mo1IN8X4uJsbw== X-UI-Out-Filterresults: notjunk:1;V01:K0:PrJLNeAz9oc=:3abExGLL/U7jaHqsjD+FJz d8Rrvp5BkQtvtZxMaiB59TdEKCPIfI9IR+Ww2p7NwEJdntSfJh47TvtNi/vhffX7Lhmjv+M41 A+c6eGUK4SetoakwdXhprDINyP7v6n1cYrIQy+QH5Uyxg4UDUSUGM1gCOw93GjP4ZWM7ld9se EpPjcXUslGbsXvZrwHGgnnKXtepEdnl70bBMyzMyy9YvnfgCoKzNBz3oh7k46BUncY+7AoGMx D7vO8qssE8VJPcqCihG1r+igcFe8u7HjGcs+5ma9yLjLpFcwO+QHNL74Ke19s8LEVOyv4uodT czk4HmGuoyuybcFeBVDPXtWkSFcrtKWgZfV0beAffx6wM95/fZYvZp8Ne+tnE3z8AeT8izjO8 D6/+FWDgtYeK15vsCpQuLf6M6iHZMevcpHtUguMssMf1AS+X3tf3vH674HD9JaelEVKlFq+xd 41wBBDS1TRB2//FcR1h0LinqGcsCJFr++EvXVNo+v07yuonniBbsr7Oydd3PibrerfZ3JWjjv NJu6/kL38rwQgUypNSeNxDQ5MT5e1DuUIK47eXb9mHVyeTGc0JZlJ04a2dV8nmdbb5cDoLQK+ DyC1okoRiMxq/qsKQFcp+3uKe8uW5eviuGtuvLhft1Wfg8V+N18+mTzPBXQ3KAz+d8OZq+08M qEReX6Sz5nZv4BvprgxyKvBUazm9cfbPA1IdfDdNPNfFIiWqJRm0gK9yKo8NKPyN04WzJskJ5 IM6nRjiO4oQTa/dBQcFgLCIp52h43vb+1wXjcRG86hNANUMRQDoZbb+G1D/pCAZydHZj1iFn2 G00sdxn X-TUID: ERL4UxH8roaB Hi Cedric, On 2018-09-01 10:44, Cedric Hombourger wrote: > Hi Jan, > > Please let me know if there is anything that I can help you with > I was going to review existing documentation and propose updates around > recipe creation / APIs > Thanks a lot, I would specifically appreciate your review. I've written some changes already and also started a RECIPE-API-CHANGELOG.md from the last release onward. Series is currently in CI, I will send later. Jan >> On Sep 1, 2018, at 8:58 AM, Jan Kiszka > > wrote: >> >> On 2018-08-31 11:05, [ext] Jan Kiszka wrote: >>> On 2018-08-31 10:41, Jan Kiszka wrote: >>>> On 2018-08-31 10:33, chombourger@gmail.com >>>> wrote: >>>>> >>>>> >>>>> On Friday, August 31, 2018 at 10:28:51 AM UTC+2, Jan Kiszka wrote: >>>>> >>>>> Re-reading the patch with my new knowledge: >>>>> >>>>> On 2018-08-26 08:21, Cedric Hombourger wrote: >>>>> > diff --git a/meta/recipes-kernel/linux-module/module.inc >>>>> b/meta/recipes-kernel/linux-module/module.inc >>>>> > index 3075f44..3a3cab1 100644 >>>>> > --- a/meta/recipes-kernel/linux-module/module.inc >>>>> > +++ b/meta/recipes-kernel/linux-module/module.inc >>>>> > @@ -17,7 +17,7 @@ AUTOLOAD ?= "0" >>>>> > >>>>> > � inherit dpkg >>>>> > >>>>> > -dpkg_runbuild_prepend() { >>>>> > +do_prepare_prepend() { >>>>> >>>>> Shouldn't that be dpgk_prepare_append()? >>>>> >>>>> >>>>> Wouldn't it be too late? >>>>> I am afraid that debian/control wouldn't be complete and prevent >>>>> installation of build dependencies >>>>> >>>> >>>> Right, we need that for the installation... >>>> >>>> I was wondering, though, if it wouldn't be cleaner to hook additions >>>> to the inner handler. >>>> >>>> Anyway, all this is not mature yet: >>>> >>>> - debianization does not require locking, only the dependency >>>> installation does >>>> >>>> - I'm quite sure something is broken now with dpkg-raw, because there is >>>> no lock involved, but we can pull packages that way as well >>>> >>> Yep, confirmed: We so far installed the dependencies of both regular >>> and raw packages in the build script under the lock. Now you pulled >>> that installation into deps.sh, but that script is not executed by >>> dpkg-raw, nor is there any lock on the related prepare step. >>> Can we fix this quickly? Or better revert and redo the series (given >>> the other issues)? >> >> I have to correct myself: dpkg-raw packages only have runtime >> dependencies, no Build-Depends. Thus they never installed anything >> into the buildchroot and also never used the build script - we are >> fine in this regard. >> >> I'll write a few patches to address the other issues. >> >> Jan >> >>> Jan >>>> - we should cleanly name the steps, as you suggested, so that users know >>>> what to overwrite / append /prepend >>>> >>>> Jan >