From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6691586504498610176 X-Received: by 2002:a19:f512:: with SMTP id j18mr10895203lfb.159.1566198593053; Mon, 19 Aug 2019 00:09:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:c317:: with SMTP id t23ls1240312lff.16.gmail; Mon, 19 Aug 2019 00:09:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxEOUtB4j/lHFGp3KxGgDlaGENbVZTVSWQZhnWuY1Qze6dRqXaDM1XVTwbIP7pb57HLVtH8 X-Received: by 2002:ac2:599b:: with SMTP id w27mr11659546lfn.75.1566198592635; Mon, 19 Aug 2019 00:09:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566198592; cv=none; d=google.com; s=arc-20160816; b=wVEFTGYaOsUvcPoki2/jF9OQejRXSrJoOljpaaL6nHv2BoM0u589B+8DzvauESpPQx xhzC1xipNMkyJnUAJO8I9IEH/iOmW1lEqdvmEzWRP1KflVb/0fP20wsPG80t00rHKQEC XBO/kyWCg/Q3Ho5tA9BxbFw2uM+vb1DwfqwDa1v3r7kyaovtxNruMQT/xFMNZ6zFVHHE IzLftvlCD9EPHFvj0ZeKpbQAO2/1yIPvugyQLwoWvDkJSSl4SGxj0tNQB9pdmDoHlA3a Z6sHfALY59yu/RXkAFf9sWcBEPLsdauOLryapji5tA+iRNxRNqswWD35imlMvfuPQe9+ AWUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=3UaSpCW/DHUQSj1Q023qilWxgPBxC3Xjl8/lEVLymu8=; b=fqG9yis6VsPVd9IckYpEcMr/Y8UiReTE15by3HOxXFVI9JB6zCyZkCmKBinVvsJvbn fAezPCD1w0pprhb0mQEtPrDBLTa1Xpui86ccgxyFiNaNlm0Ka2isdlq7Fr9LepwOirIP CeqtG7I/GUd40EtP37BtFFeKGhO+wP6nWkiwdURcyWfRZlW329JDLaBl684kV1inmi2y MLirxqAZsbNlovcX6cVGkvlhFIk9kUmHfAWo0xxKuaEaqQoCxN04/N4Kd2nQIODA0bOd +7z6l6U0RvwZ+LjTIHifPx7kL3YpLecwFiJ3ugqc+qmaGlzbCYO1M+71OfjtS2YDQWdT rVaA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id u10si744931lfk.0.2019.08.19.00.09.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Aug 2019 00:09:52 -0700 (PDT) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x7J79puK006454 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Aug 2019 09:09:51 +0200 Received: from [139.25.69.208] (linux-ses-ext02.ppmd.siemens.net [139.25.69.208]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7J79p4O029257; Mon, 19 Aug 2019 09:09:51 +0200 Subject: Re: [PATCH v4 2/8] split up isar-bootstrap helper and implement pre-process pipeline To: Jan Kiszka , isar-users@googlegroups.com Cc: Claudius Heine References: <20190523145521.23050-1-claudius.heine.ext@siemens.com> <20190523145521.23050-3-claudius.heine.ext@siemens.com> <9854b2df-897d-393a-e968-e23fccbb67a1@siemens.com> <4cccc136-83f6-a7ea-ce94-686fdab09b1d@siemens.com> From: Claudius Heine Message-ID: Date: Mon, 19 Aug 2019 09:09:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: dG1Wjuagcp22 On 19/08/2019 09.02, Jan Kiszka wrote: > On 19.08.19 08:59, Claudius Heine wrote: >> Hi Jan, >> >> On 14/08/2019 18.00, Jan Kiszka wrote: >>> On 23.05.19 16:55, [ext] claudius.heine.ext@siemens.com wrote: >>>> From: Claudius Heine >>>> >>>> This removes the isar-bootstrap-helper.bbclass and integrates its >>>> functionality into the rootfs.bbclass. >>>> >>>> It introduces the rootfs_install task that runs through multiple >>>> functions from command lists in order to allow easy integration of >>>> custom functions. >>>> >>>> The introduced functions are, in general order of execution: >>>> >>>>    rootfs_prepare: copy the isar-bootstrap rootfs base to workdir >>>>    rootfs_configure_*: basic configuration of the root file system, >>>>      before any custom packages where installed. (`/dev`, `/proc`, etc. >>>>      are not mounted). Functions are added to >>>> `ROOTFS_CONFIGURE_COMMAND`. >>>>    rootfs_do_mount: mount standard directories and repositories into >>>> the >>>>      rootfs >>>>    do_rootfs_install_*: downloading and installing packages. Functions >>>>    are added to `ROOTFS_INSTALL_COMMAND`. >>>> >>>> Signed-off-by: Claudius Heine >>>> --- >>>>   meta/classes/image.bbclass                    |  24 +-- >>>>   meta/classes/isar-bootstrap-helper.bbclass    | 132 -------------- >>>>   meta/classes/rootfs.bbclass                   | 172 >>>> +++++++++++++++++- >>>>   .../isar-bootstrap/isar-bootstrap.inc         |   5 + >>>>   .../buildchroot/buildchroot-host.bb           |  16 +- >>>>   .../buildchroot/buildchroot-target.bb         |   2 - >>>>   .../buildchroot/buildchroot.inc               |  26 ++- >>>>   meta/recipes-devtools/sdkchroot/sdkchroot.bb  |  48 ++--- >>>>   8 files changed, 228 insertions(+), 197 deletions(-) >>>>   delete mode 100644 meta/classes/isar-bootstrap-helper.bbclass >>>> >>> >>> [...] >>> >>>> diff --git a/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>>> b/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>>> index 73cd548..121992c 100644 >>>> --- a/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>>> +++ b/meta/recipes-devtools/buildchroot/buildchroot-host.bb >>>> @@ -7,6 +7,8 @@ DESCRIPTION = "Isar development filesystem for host" >>>>   PF = "${PN}-${HOST_DISTRO}-${HOST_ARCH}-${DISTRO_ARCH}" >>>>   require buildchroot.inc >>>> +ROOTFS_ARCH = "${HOST_ARCH}" >>>> +ROOTFS_DISTRO = "${HOST_DISTRO}" >>>>   BUILDCHROOT_PREINSTALL ?= "make \ >>>>                              debhelper \ >>>> @@ -18,15 +20,5 @@ BUILDCHROOT_PREINSTALL ?= "make \ >>>>                              automake \ >>>>                              devscripts \ >>>>                              equivs \ >>>> -                           libc6:${DISTRO_ARCH}" >>>> - >>>> -# According to the wiki page: >>>> -#     https://wiki.debian.org/CrossToolchains >>>> -BUILDCHROOT_PREINSTALL_append_armhf += "binutils-arm-linux-gnueabihf \ >>>> -                                        crossbuild-essential-armhf" >>>> -BUILDCHROOT_PREINSTALL_append_arm64 += "binutils-aarch64-linux-gnu \ >>>> -                                        crossbuild-essential-arm64" >>> >>> Where did binutils go after this patch? Don't we need them? Wondering >>> because there is no remark in the commit why they were removed. >> >> Well crossbuild-essential-* is added and just like 'build-essential' >> binutils is a dependency from it: >> >> crossbuild-essential-* > gcc-*-linux-gnueabi > gcc-8-*-linux-gnueabi > >> binutils-*-linux-gnueabi >> >> So that was just a removal of unneeded package names, that get >> installed anyway. > > That is what was missing in the commit... Well for me that was just some minor refactor on the side. But you are right, it should have probably been an additional commit because its an unrelated change. Sometimes it is difficult to separate each independent change from each other, when a lot of big changes where done all over. Claudius > > Jan > -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de