From: "MOESSBAUER, Felix" <felix.moessbauer@siemens.com>
To: "amikan@ilbers.de" <amikan@ilbers.de>,
"isar-users@googlegroups.com" <isar-users@googlegroups.com>
Cc: "developerdong@gmail.com" <developerdong@gmail.com>
Subject: Re: [PATCH] image: Fix quality check ignore for multiuser config
Date: Fri, 20 Oct 2023 15:32:04 +0000 [thread overview]
Message-ID: <c3d24a33cd9536e036189087716927e577b8fbb0.camel@siemens.com> (raw)
In-Reply-To: <20231020111539.1942570-1-amikan@ilbers.de>
On Fri, 2023-10-20 at 14:15 +0300, Anton Mikanovich wrote:
> If changing user, UID or GID information more then once, original
> files
> will be saved in temporary files which should be ignored during
> do_rootfs_quality_check task.
Do we include these files in the final image? I'm pretty sure we should
not as this is a reproducibility issue.
Felix
>
> Fixes #98
>
> Reported-by: Zhibin Dong <developerdong@gmail.com>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta/classes/image.bbclass | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index cc8e3443..73f1d52c 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -496,8 +496,11 @@ do_rootfs_quality_check() {
> args="${args} ! -path ${ROOTFSDIR}/etc/machine-id";;
> image_postprocess_accounts)
> args="${args} ! -path ${ROOTFSDIR}/etc/passwd \
> + ! -path ${ROOTFSDIR}/etc/passwd- \
> ! -path ${ROOTFSDIR}/etc/subgid \
> + ! -path ${ROOTFSDIR}/etc/subgid- \
> ! -path ${ROOTFSDIR}/etc/subuid \
> + ! -path ${ROOTFSDIR}/etc/subuid- \
> ! -path ${ROOTFSDIR}/etc/gshadow \
> ! -path ${ROOTFSDIR}/etc/gshadow- \
> ! -path ${ROOTFSDIR}/etc/shadow \
> --
> 2.34.1
>
prev parent reply other threads:[~2023-10-20 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 11:15 Anton Mikanovich
2023-10-20 15:32 ` MOESSBAUER, Felix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3d24a33cd9536e036189087716927e577b8fbb0.camel@siemens.com \
--to=felix.moessbauer@siemens.com \
--cc=amikan@ilbers.de \
--cc=developerdong@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox