From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7286543990069919744 X-Received: by 2002:a1c:ed17:0:b0:402:f8ea:be3e with SMTP id l23-20020a1ced17000000b00402f8eabe3emr6602026wmh.7.1696571962583; Thu, 05 Oct 2023 22:59:22 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:3c8c:b0:405:ca8d:5cc3 with SMTP id bg12-20020a05600c3c8c00b00405ca8d5cc3ls48618wmb.2.-pod-prod-04-eu; Thu, 05 Oct 2023 22:59:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHKH9OuPS1r1NpeCwtLvOB+jZsKezXALuXGkdSvN5LBNOXGHVaLoDxPLwr18fCLkE0GZcfa X-Received: by 2002:a05:6000:114d:b0:324:8502:6355 with SMTP id d13-20020a056000114d00b0032485026355mr6176203wrx.46.1696571960318; Thu, 05 Oct 2023 22:59:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1696571960; cv=pass; d=google.com; s=arc-20160816; b=MtqbbRk2/ysGGn+8k8S0lt4oTA1olqFthoeAXw4lSm/cRgfp4fBQgLC5/6d4mwGuIA j2QPOl/sPwo2N45wX8vbeaW5+WdzVpvjYd89MKarZ2JtlxID1R/ZzA2bULXw2gC1Z9uQ dhDIUuGSn5izS1M0TZH8cEGJxiqBd/RdSFfNka6XwRFLkjzgIpWgVWJwKMFOuR+Dk/PO 2el59pcVfv8d9onWv5sT/lPQJSo6o5q+9lVTSXQQDk+4ysgu1/VFt2V4NcntRMSRO5Gr SYQiLzTgJPNbQyZiqp8HiHWu9KpnoGd6UYlC1hShYBiV8gj4HzR5UHWBkdoIoqmed58L 9T3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=K59bIobPEiNC7OJ5CuObcZvPNjRVxu/YniAR7vCXaYg=; fh=qYjLjom2XYK2EGXTfM32+e6Y5m6bxV+vwmPCS15rMNY=; b=Y4nETvwhjV4VkMhIsYm7p9bQzvZBNrKG0m9B0IwIVI4E1rorrLT9CA/z1Ic9nKP7Fz EV+14Ma57+sK5a3LBLMzDpDB2rDYsrdW2fqi65faFPafd4X1rn+gfuJcFvj7lE47sIbs sywuZcwkf2q+LKHIGpy38OFgpXRzQRKcxrX1mXaljaNvfb32pRCFQb+TgbcMUHnWcH87 2gAP93xepihH7lheEbwXbJtrmc2kv3NL79EqDnCAwLE83TcsIAVBrUJHXrXulM0S3mRa irU418gK9MqD+APQH5jlFt3DmuBrXF9q2q/EuiQgGv7OjZHsDxPM7RtH6VftXBKTQlyW 28ow== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=aY+ioWgl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1b::621 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on20621.outbound.protection.outlook.com. [2a01:111:f400:7e1b::621]) by gmr-mx.google.com with ESMTPS id az19-20020adfe193000000b0032626963dfbsi32136wrb.5.2023.10.05.22.59.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Oct 2023 22:59:20 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1b::621 as permitted sender) client-ip=2a01:111:f400:7e1b::621; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=aY+ioWgl; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:7e1b::621 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFCFPdKNX0gs6bkPMGNm/o4RCbkel3I0bdLSA5C4HRpTr0IPdCnSZ7oHgYsrXurwzqhisR//KiskBJPwvE1RoV1igj/lCRozRzHJ46AmuRUEn0gkA0ezYyzFvGr9h3pYBJ9HfcIVpmzFmrABiLBo+nbvCugWUPZ44uSEfobXbAW3l0m5d45gaf6+7zSkxFPZRD/1JyHGS0hCBZkIdrpM5gTvUUMNT9GbkI3OrXyHfpVsL5lsBtL9hU7FVLi+97ndOeQfJi3UTBdzKD02IrUjXDdHLepL7DGF4XDlr0EO5zyK7gHiqxx1Nw5Eu7KgIdabnQpnrbKzWySiCedJbX18uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K59bIobPEiNC7OJ5CuObcZvPNjRVxu/YniAR7vCXaYg=; b=CtMW50/bVfszD7iAN9wsRtMguOLTXGCQcbJkyDCuCkeJQOmRFOqQ5JJ1ec54BTCD1psQYcRHvnsWL4T6Xsg+nnML3auokEm9iI899kSqYd7GNWMpVxLm7n85zuIYh7wVDHnM9ZG5pV2nuJFypJFXUcTpnAALM4f/YThswJRTwxCmY69Dq/e5Ha/5mTSjYkv6rhmHPu+zkyJeW5XcDwILMiKeFoNBLnNvopQf3NZ8w/K0Rk/yUETsNvJbqnQhO+tajZjK+Tfa2KKRcAg6Lv70mJpdyDDBfaGuECAJRDyubOUMazSgfL+W25wUO9AZYzmnSeMnaYJjio2+zi4tcOAjXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K59bIobPEiNC7OJ5CuObcZvPNjRVxu/YniAR7vCXaYg=; b=aY+ioWglE3PV80I6echWq8yf5OfpE4+UlsujhzhptNbOh/gCFDejnrMp1zOmE2HoGp0UqVuzt7OQMRq93RhYEibRYwVl9zDHcpDooEvFqHYqnHESaCLjoL8eop9u5R7dcbrcggJUxG6souSLtJucFd0iSDPtowRDQip2WFRLR0eGK3i7xO+1ijAe/1028oO+6wZMQWaZ1X9lnO78ir6PlnDgjlfB2Eojv9tTKj2p2DXKzXsghKE0gb2Dtm/Iw451+adu2kSRwSuI0w1PHxIIu+fYAVy71AmXJX8uIA2v3hPD1zrkIOZtMg7PSgjUJF/CpP3BMAYd4Jbrl/6vUG53AQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by PA4PR10MB5612.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:265::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.38; Fri, 6 Oct 2023 05:59:18 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::7f20:d403:b43d:12e2]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::7f20:d403:b43d:12e2%3]) with mapi id 15.20.6838.033; Fri, 6 Oct 2023 05:59:18 +0000 Message-ID: Date: Fri, 6 Oct 2023 07:59:16 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] Revert "base: Fix HOST_ARCH for native builds" Content-Language: en-US To: Uladzimir Bely , isar-users References: <23de6598a5b20bc289906493bc7563bacee8b916.1696530723.git.jan.kiszka@siemens.com> <97e458c5f21cc194466a1da58b51220390afa376.camel@ilbers.de> From: Jan Kiszka In-Reply-To: <97e458c5f21cc194466a1da58b51220390afa376.camel@ilbers.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0182.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::17) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|PA4PR10MB5612:EE_ X-MS-Office365-Filtering-Correlation-Id: f674425f-639b-4aac-9e0e-08dbc63160e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YbltND8pW7wa//ypDQWb3NoHqHYWtRq6ZRBiIbVlxvqx0ydgjv9SYO48htviU3G1w23NczTsBtJVeb189qSIMN9lWqzYSc7xfrsOnWd+755fsUZpwNSwdoyxlcUDtUOi5qXG1C93jnHaE0AJyBwQ8/VURHYKNCmwNpzJq/x+VhungCfwyxV/AbaxbTg2TN697Unj40dnek8ai9LThrDypgBs/5IWPh4KiqGtR08pcwAKz7CoTwodtkIuQcXVCLMbpr7B5Yi9oR9eHAGUw/EOlAZyc29sJIuwVc5+IJqzP1ObNrRXGHZxDHcTdY26BQedxSpRQgJmQyShpwsGi/oj3ZTHNrNqPxOzKTiH2YuDHN0Dac9lgwo1Si58UIkNPnvYQ8LwQZto/U7kGiL9bnaMZJI1CC+uAkdPwZFvMbCoGUxJL8X1gvZ3uf2n07jjMkF6NWocSTPoH/3EU6zMqRLebcSpmdPa2OR2/u/bVa+NoEfGiRgH8jFtoOA9krg9Cc717UTsgb7WhVQNsKCvdx9hbTYR2E6bXsX3JWOD6UcuiagxCKE3f45W5X+NYxaykKckx0LHniMmH74l+ErMS1+OhzWhV7qIcL7vPa1/fgkWha4z+iigd43u45Xt1qeF1LZG3kBDjv9+Nvf+TJXyp3eLt16YJforBYWr+5DEwOOdv+8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(376002)(346002)(39860400002)(366004)(230922051799003)(451199024)(1800799009)(186009)(64100799003)(41300700001)(2616005)(26005)(2906002)(5660300002)(36756003)(44832011)(83380400001)(8676002)(8936002)(38100700002)(53546011)(478600001)(31696002)(82960400001)(966005)(6486002)(6506007)(6512007)(86362001)(110136005)(31686004)(66946007)(66556008)(66476007)(316002)(403724002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0NIZEkyeEU0UTJLcDJiS1c3dis0bEQzUFlWeHZRUUFkd2k1ZDUxYStualNy?= =?utf-8?B?cU12V0dqdFg5bkZycHN1SVFwL0xuUXFiQklsL1hWOU5QVXVBeXdOcXZpY1lH?= =?utf-8?B?UVJxRmh4ZElIaGJUNEtuMFc1d3RqRzMyV1pjaVJGanZwdktHNGY2emwraWg1?= =?utf-8?B?MFVPRUhnTmpMVndab0M5V212VzZaQjMvOWlWeEREME55R2VxMGtlY1hVYkJK?= =?utf-8?B?T2h5TE4rM2xmZ2c4WVlHdEdGRm5KTUVONHZuNmpDTVFRUy9qemtXNmJEUkRL?= =?utf-8?B?T2dBU0xYZklPUWxuQWlZMnRtL2ZkN2lBamhhYjNWYWQ5aGlxNGRxbVV1VVRT?= =?utf-8?B?Vm95SlAvaW5FejdiYXN0d2lsOWJSWkQ4WGJjSGRaT3B3SVJpOFFZSnZyRnVq?= =?utf-8?B?MHVrS0plZTZPWVpuWThBL0tIOGN3OVVPWlY0YSs3WE92dy9JZEkyTVFsS1dS?= =?utf-8?B?SWxZMC9QZnNFb2lxNDJqUHBtdlNSVDk5TVVHdWthWTExS1ZFOHFINy9PVWF4?= =?utf-8?B?eFRreWRhczhqSm9EL2dtK01jT2VHY2FMc1J0WFQ2azRDUnJ1Rlk1MnJKckVk?= =?utf-8?B?bVYvNnk2NDRNWDU3dDZPdEY1cU9IWUhUZFY0emxua0dMVmxhZ0NhaEJoVnYw?= =?utf-8?B?bmdFTWcwN1B2Wjc0b1dMSUJLc1pDeVRHY0dIRG5EQ1JOUmVWaWRpT2VHZnBs?= =?utf-8?B?WVRlTmh6akdXMHIzUURWaDJNYlBUM05jb1dWK3k1R3h6QStjK2RDQjBQK2lz?= =?utf-8?B?cThmdDVjam9QT01DM2VDKytjSTF1YWgyN3M3V0ZBdEl1WGRqR3VoQWtXcVpK?= =?utf-8?B?MjIrZDNzUVVkQUdQWHo5S2Ezc1Y2dkFuVmw1QUl1MXRldnkxVTRxMW1iaHpn?= =?utf-8?B?REhQVlRVT3B5SlVsRW83STRVZVh5TkgwTzlEa3U0bmtnM3l2N2NNMURkWlRa?= =?utf-8?B?cmZYU2xmeGlxQTFJTnZxRnIxVTB2RVMxWFJuck5CZXNjemxJSUFFbWR2aGxs?= =?utf-8?B?cGhrQ29IaCs0WFhYZW5pcWw1YlVOaEZPVTdIZzZhcGJjSlFYOXRMa3pEWi9H?= =?utf-8?B?MllOSUNKWUVmYnhHK0hDZGZ6U25kZUsvZ2M4NTIvdUxRbjJKOHoyQ0dBZ29X?= =?utf-8?B?c3YwbmFHTTcvSG9tbFFvUlpibFh2OUQwOHp5VDlLYXdkaklXS0RuZUd6UVc2?= =?utf-8?B?QUlLdmZhL2lXV0EvUE9JLzVnK2dlZlNSOUNpY0gzY3UvQ09IYjVtVHJTWEhs?= =?utf-8?B?NVd0R3dZL1pXdXo3VnNJb2F2SnhFVWh3a0xVbzMwM2VxZlRaWE4vcGc1c25y?= =?utf-8?B?N0k4ZU1iUVpKV3ZSUTJPTFR3WFowOFBZZ0d3bnNOM3FhU2RqUHFxamRudGw4?= =?utf-8?B?SGIxa2xDVjcrVCtveVJCQWpmczQ3aElYaUZkOHRFNitNS3hrR2lVQUpVVDNY?= =?utf-8?B?ZWUrSkk3TjdRSTNNNURJbnc3M3BXanJLSHZFTmhtTzRrZSttMnZseWVoYmVW?= =?utf-8?B?ZDhDMXhpZ1JtWm1ySWdYUnJxTU9ZK1paL0t1TjU0TURBbDlkMU5Xa0d1V0Yv?= =?utf-8?B?RHJFbDQwRG0vT2hHYVV4N2FVaFJ0OGV1NFAvN0ZLRjJDMTVNZUhLWERqaWZF?= =?utf-8?B?T1IyV3Q2NDFnakZDMnYrS0p1M0Y3Zk9mb1d1MEtJdDdxZXI5Mk0zYmhlcEtZ?= =?utf-8?B?V3FYNFF2Q2VhcFUrVjJQNVo2QWRjeExPN0xzbkNBaFkrbDluckNEcndOd21t?= =?utf-8?B?WGF1RjliNXVyWDdMNlN0SGNENWNyc3VJQ0dHUGFqYnpUdzk3dUxEblB5TzRy?= =?utf-8?B?NnJXbW1uNWk3S2VZbVEydWJEWExEdU8yM1RoKzdvdFh5bVl1RVVZNEtEajY1?= =?utf-8?B?b1d4VFAzTXlIZkZhRzJhamlUbkYvbE9aKzFRUUVPQ09MNXJwUU15VTZCVzhi?= =?utf-8?B?anVpT1Z1NitUSnR3YmdKbUZENmlLM3loYXRXSzlGYmY2ZjZpVUpSWE5iSXlp?= =?utf-8?B?NWQ1R0VucVdaajRDT2s0Y3JQVU5kOHlqMmV2RHJsZnhxMEg0NjN1a3E1QnRH?= =?utf-8?B?ZGZLcVZPY3k2SjJGVVBBcjNEUzh1WDZoZXhhSUw3N2h5MXhvSm1mbzd5MkRj?= =?utf-8?B?ZnNmdjV4NWpYWWpQRi9DQXVaa3dpUldxZllBUVA0ZEhCWTc4OTlrd01Gc1pm?= =?utf-8?B?Y3c9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: f674425f-639b-4aac-9e0e-08dbc63160e8 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Oct 2023 05:59:18.6093 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JsdJVHNgKpr0OnmZgA59WC8JJpUDNS1khLF4EOyMBma+tl1hZYM0vgJb+mufBJ9TYB/OThpDMw1sbrcSJigRCQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR10MB5612 X-TUID: AgEtahMniMSI On 06.10.23 07:44, Uladzimir Bely wrote: > On Thu, 2023-10-05 at 20:31 +0200, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This reverts commit 7bc68bb27f562257977bb5f701564ab08d4c5b3a. >> >> It was the wrong assumption that HOST_ARCH should depend on >> ISAR_CROSS_COMPILE - too much code assumes that it is statically >> bound >> to the builder machine. Instead, code that needs effective builder >> arch should use BUILD_HOST_ARCH. >> >> Signed-off-by: Jan Kiszka >> --- >>  meta/classes/base.bbclass       | 6 ++---- >>  meta/classes/imagetypes.bbclass | 6 ++---- >>  2 files changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass >> index f315a9d5..88004120 100644 >> --- a/meta/classes/base.bbclass >> +++ b/meta/classes/base.bbclass >> @@ -49,15 +49,13 @@ def oe_import(d): >>  # We need the oe module name space early (before INHERITs get added) >>  OE_IMPORTED := "${@oe_import(d)}" >>   >> -def get_deb_host_arch(d): >> +def get_deb_host_arch(): >>      import subprocess >> -    if d.getVar("ISAR_CROSS_COMPILE") != "1": >> -        return d.getVar("DISTRO_ARCH") >>      host_arch = subprocess.check_output( >>          ["dpkg", "--print-architecture"] >>      ).decode('utf-8').strip() >>      return host_arch >> -HOST_ARCH ??= "${@get_deb_host_arch(d)}" >> +HOST_ARCH ??= "${@get_deb_host_arch()}" >>  HOST_DISTRO ??= "${DISTRO}" >>   >>  die() { >> diff --git a/meta/classes/imagetypes.bbclass >> b/meta/classes/imagetypes.bbclass >> index 205377b1..a3be0a1d 100644 >> --- a/meta/classes/imagetypes.bbclass >> +++ b/meta/classes/imagetypes.bbclass >> @@ -65,10 +65,8 @@ UBIFS_IMG ?= >> "${PP_DEPLOY}/${IMAGE_FULLNAME}.ubifs" >>   >>  # glibc bug 23960 >> https://sourceware.org/bugzilla/show_bug.cgi?id=23960 >>  # should not use QEMU on armhf target with mkfs.ubifs < v2.1.3 >> -python() { >> -    if d.getVar('DISTRO_ARCH') == 'armhf' and >> bb.utils.contains('IMAGE_BASETYPES', 'ubifs', True, False, d): >> -        d.setVar('ISAR_CROSS_COMPILE', '1') >> -} >> +THIS_ISAR_CROSS_COMPILE := "${ISAR_CROSS_COMPILE}" >> +ISAR_CROSS_COMPILE:armhf = "${@bb.utils.contains('IMAGE_BASETYPES', >> 'ubifs', '1', '${THIS_ISAR_CROSS_COMPILE}', d)}" >>   >>  IMAGE_CMD:ubifs() { >>      ${SUDO_CHROOT} /usr/sbin/mkfs.ubifs ${MKUBIFS_ARGS} \ > > To bring CI to working state again, we tend to apply this revert today. > (as soon as possible). Is it OK? Sure! Jan -- Siemens AG, Technology Linux Expert Center