From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6741467829768290304 X-Received: by 2002:adf:d08b:: with SMTP id y11mr12402307wrh.50.1569823576478; Sun, 29 Sep 2019 23:06:16 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:c143:: with SMTP id r64ls4524990wmf.0.canary-gmail; Sun, 29 Sep 2019 23:06:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqwSYO2tx6/blkvfS9HKVG9ZWqlJDx16kjCxwpg6PMoUQcpS/lRTd3cW4NXJyQvcwG6tt4ri X-Received: by 2002:a1c:6508:: with SMTP id z8mr16483840wmb.93.1569823575901; Sun, 29 Sep 2019 23:06:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569823575; cv=none; d=google.com; s=arc-20160816; b=YW9I4cmVxxbW9pT7aFZpmqYHLn5mIIFwcPmQjU446dJQ0OPBHyRNKfPpmL07smqyEp Y1c098imv2nvaY7V1Qgz750kE4+QUroroh9iH1qbXbQdR5St+liBxwzT2byYIsMcnumy 0ZE6euu8TMvBXT2qqe8ND07AzX5VpKZDwDY+W5ozbi+lKMJ8TugtBExIbd+mEjW9cH6e bvVa6wPasQOjwZ59A71ZpBOejQ1zYmyGGtwa2d792KuVSTN+KW2iTP1rua3bboshr7EB 4/1oz5ftrY4LBLIo3GeKpNfPWO5Nt3UrputWfACxIw61+K6ICI1he9dAhK9m2He4xDgw dCTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=EOrR87keCbXHFCe9zhA8WD8sUrGOSLPFLaq1oahPBq8=; b=JpRX0E2eyr+f8oMaHw+ulRfbAx4kXLV0gMFYwQEcveGv9aYufCKpILj0Jycb25HclL 1ZFcP4M7XL/FN4rzyFMVJF3dTWjrqzIxvnI6WyK21MxpaD8DaDf4+MXYNNzc4sSsO82O jZ2c1rOcbXNc5rsVlO5D9Vp1Yncw/nalvkP6kCESIcU5y5/lOWBGUiOEXITi6pBzwfKT IcjJ7yq2cMWTylN2U5pUMFA2W1jOemnfKWeeTOafaYVuGaS7B6C4eVi/D6a7CVczoNet crVsaRgkOIIvszXqCxB9R8wcVRW2OJ5y02tCaJH8JPLHxPrP5+3Dg0CN77WBRb526mFe jSnA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id p12si580674wmg.0.2019.09.29.23.06.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Sep 2019 23:06:15 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x8U66FBQ000496 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Sep 2019 08:06:15 +0200 Received: from [167.87.40.9] ([167.87.40.9]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x8U66Euh030858; Mon, 30 Sep 2019 08:06:14 +0200 Subject: Re: [PATCH v2] isar-init-build-env: Always set ISARROOT To: vijaikumar.kanagarajan@gmail.com, isar-users@googlegroups.com, henning.schild@siemens.com, claudius.heine.ext@siemens.com Cc: Vijai Kumar K References: <20190927213804.31651-1-Vijaikumar_Kangarajan@mentor.com> <20190927214352.32114-1-Vijaikumar_Kangarajan@mentor.com> From: Jan Kiszka Message-ID: Date: Mon, 30 Sep 2019 08:06:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190927214352.32114-1-Vijaikumar_Kangarajan@mentor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 6zBNtuH31e8H On 27.09.19 23:43, vijaikumar.kanagarajan@gmail.com wrote: > From: Vijai Kumar K > > When switching between two ISAR workspaces in the same shell > session, the ISARROOT setting of the previous workspace would be > picked up for the new workspace resulting in an incorrect > configuration. > > Always set ISARROOT irrespective of whether it is empty or not. > > Signed-off-by: Vijai Kumar K > --- > Changes in v2: > - Remove redundant code > > isar-init-build-env | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/isar-init-build-env b/isar-init-build-env > index b08bb59..404efcb 100755 > --- a/isar-init-build-env > +++ b/isar-init-build-env > @@ -42,13 +42,10 @@ if [ -z "$ZSH_NAME" ] && [ "$0" = "$THIS_SCRIPT" ]; then > exit 1 > fi > > -if [ -z "$ISARROOT" ]; then > - ISARROOT=$(dirname "$THIS_SCRIPT") > - ISARROOT=$(readlink -f "$ISARROOT") > -fi > +ISARROOT=$(dirname "$THIS_SCRIPT") > +ISARROOT=$(readlink -f "$ISARROOT") > unset THIS_SCRIPT > > -ISARROOT=$(readlink -f "$ISARROOT") > export ISARROOT > . "$ISARROOT/scripts/isar-buildenv-internal" "$1" && \ > TEMPLATECONF="$TEMPLATECONF" "$ISARROOT/scripts/isar-setup-builddir" || { > OE is doing the same, i.e. does not update OEROOT on second execution. This allows to set OEROOT prior to calling the script (https://github.com/openembedded/openembedded-core/commit/3327e2a9222004d8ac7974cb1d9fe77c81176cfc). Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux