From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6527286083495919616 X-Received: by 10.28.87.78 with SMTP id l75mr887576wmb.9.1520192959851; Sun, 04 Mar 2018 11:49:19 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.181.149 with SMTP id c21ls362812wre.1.gmail; Sun, 04 Mar 2018 11:49:19 -0800 (PST) X-Google-Smtp-Source: AG47ELuaiSUMWrp5jpt+ezGi3x7vdZIcn4Cb8ToI+9WzOtPaovP05XdVFI2P4T4n8qPreNMtDXHa X-Received: by 10.223.186.15 with SMTP id o15mr170531wrg.32.1520192959216; Sun, 04 Mar 2018 11:49:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1520192959; cv=none; d=google.com; s=arc-20160816; b=dBOh9Ej2wNdfrcGIF3GnnSnFRidH5UogMHh9R8hYy0qco0kao89uD0AMhsxkMdjv+N HZgFLhTDGIE0C3vJTY84odnB2W2Y7KZQLLS+RGe9hkJK2+yQtQE/krsgXlIrFDV/XwZH /+chqqxffEgWl1ZV2I8UGmDT0v32GM+aPPMeGqKT5yN2enSGDwNZK7nhdcTgWXjkmbCu G9kmBx3R9u03O+cZHfk9OMXqgoEB/RLk6vy1jZDj0ctpJgr1q+xxf6PzqynjK7GV9AMU rbhJT7qyEtnmcW02WbB9PBjkQ2ZDKI0p98ddQ3G+dcWMkdylDj+pRsW+iZVrFN8/nVCw erIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=KZ639H3wud3FlYjKbw1EcscOWRkiJlG/ObO6yUI7yxg=; b=xMtBXMqTKuTw66VjgzS7ok+sebBjeLMjpgdA2p9avhhQBsnJt4b3vOy96+eUFkaLDL o4N1y/xxxmW6Zm0DBBgpJ+iGXYll+mocE5NBro+TZONmj+eSz+ZS5V6zegA6hX1nCp+0 NP/URfDBU/Y0LSyPpLvU7/DFN4azDjgGHYtlfqCDto+CQiFiKF/Oq6bPdMIPJDJ6k8D2 Drrtv8rGBp6f5V+lM55LlWN1bRC5GuYRWBPyW8moALcbcPk+UTjNwcFLxYhnDSZw1Akf TbZPE6uStsRWPhgPVoFqlZimFnKHv+KVl8bSqDkSOLynyBff7P1vFS2albZU4GujOek2 ULpw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id u52si409043wrb.3.2018.03.04.11.49.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Mar 2018 11:49:19 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w24JnIMT019368 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 4 Mar 2018 20:49:18 +0100 Received: from [167.87.43.202] ([167.87.43.202]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w24JnHIp030039; Sun, 4 Mar 2018 20:49:18 +0100 Subject: Re: [PATCH] meta: image: detect broken symlinks To: Alexander Smirnov , isar-users@googlegroups.com References: <20180227172336.19786-1-henning.schild@siemens.com> <976515bd-b435-879f-9a57-84078d9c6149@ilbers.de> From: Jan Kiszka Message-ID: Date: Sun, 4 Mar 2018 20:49:17 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 58P0maQRGVzz On 2018-03-04 20:28, Alexander Smirnov wrote: > On 03/02/2018 07:30 PM, Alexander Smirnov wrote: >> On 02/27/2018 08:23 PM, Henning Schild wrote: >>> Switch get_image_name from os.path.lexists to os.path.exists because the >>> latter detects broken symlinks correctly. >>> >>> Issue: >>> If you build a kernel without CONFIG_BLK_DEV_INITRD the postinst hook >>> will >>> still call "linux-update-symlinks" and create a broken symlink. After >>> that os.path.lexists will return True and "sudo cp" in >>> do_copy_boot_files >>> will fail. >>> >> >> Applied, thanks. >> >> P.S.: fixed to upper case after semicolon in patch topic. > > Dropped from the next branch. The patch breaks 'start_vm' script, > $INITRD_IMAGE variable is no more valid with it. That smells fishy. Maybe the broken link test is papering over another issue. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux