Re: [PATCH] image: remove / entry from fstab template

[Florian Bezdeka <florian.bezdeka@siemens.com>]

On Tue, 2022-10-04 at 13:46 +0200, Henning Schild wrote:
> An fstab entry for / should usually not be required. It just makes a
> rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one
> that should know which fs to mount and how. That is done via a bootloader.
> 
> Should additional mount options be needed for a concrete image, an
> imager like wic might add an entry. i.e. for adding fspassno or
> x-systemd.growfs
> 
> So to make the rootfs more generic and to allow imagers to add their
> individual / lines, instead of having to modify an existing one, remove
> the line from the template.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

Hi all,

FYI: While trying to update Isar in one layer using LAVA tests we
recognized that there is now a breaking change:

Previously the rootfs was mounted rw on ext4 images because we had the
/ line in /etc/fstab, triggering systemd-remount logic.

As the entry for the root (/) has been removed in /etc/fstab remounting
does no longer happen. This breaks several LAVA tests here as well as
start-qemu scripts. Adding "rw" to the kernel cmdline would be one
option but we have a lot of LAVA job descriptions and even more start-
qemu scripts in downstream layers.

Felix already send out patches to OE (open embedded) to address that in
wic. Necessary Isar patches (wic update, ...) will follow soon. Thanks
a lot Felix for taking over.

Best regards,
Florian