From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7150622362639007744 X-Received: by 2002:a17:906:b04a:b0:84d:ac8:ec37 with SMTP id bj10-20020a170906b04a00b0084d0ac8ec37mr175227ejb.138.1672924084703; Thu, 05 Jan 2023 05:08:04 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:6402:4413:b0:43d:b3c4:cd21 with SMTP id y19-20020a056402441300b0043db3c4cd21ls1238396eda.2.-pod-prod-gmail; Thu, 05 Jan 2023 05:08:03 -0800 (PST) X-Google-Smtp-Source: AMrXdXuy5v1sfvyLhO0+O2dkKCp+0UjGSN+/lv2Sa6VI0pyWaArdi3mIM9eGbv1QLyyrTw0M9AfJ X-Received: by 2002:a05:6402:3706:b0:472:9af1:163f with SMTP id ek6-20020a056402370600b004729af1163fmr45555979edb.37.1672924083634; Thu, 05 Jan 2023 05:08:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672924083; cv=none; d=google.com; s=arc-20160816; b=AGHGKzQZvp8jNl1YzHrNYvUxTkM9mJplwQrF9OTJn/pVU4pRv36O7Vn2l1+IjwKmq8 Tz+hEhqaz0fz+kfbbn/yGXQcsrBvzVesAyLUhHZDNGBrndQmm6K+2EcIqHPm7httdDsy lCfS32KVX6Vc/jRRAVmCvzCbF9qE29MxA2OO2stE+wJIvML+f+1Rk4JXvuOi7MjW4inw EOkUTBybCljWfWTsVOaJVZHGMYBH6xDs/WwtsBRR1zkAYl8FsHR59BXRzUBjfkcf7Y0B 90H1BhIspkKFBlpztaZpXPqrsLXBNqpkFtFR2yjTUzHSZn4EPyr/ah3lGED2SFsF/xHv goWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=feedback-id:mime-version:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=GTlsWJppRcYZl/2r/0gc4FrI7Wq8cWGlRvlwOiYDl/Q=; b=0Z+GF0c46o+OzhlaFKj4L6Eu2twFge8xsApSP2HJLhTQ3HT48K/7JqBO6M/m+0bZZu TDtRpn6sUcyk9UkNranLZim9QdFaAksQ9N4hRg+AJzMcYoDjV2BUUCA4k9JoeZAerZTT e0ZUx0Y2/pghAAN9fQjXDBI7xfF4CTgnkk2b4IeqeLzQI5XJqmAqp7H8Rvy5upVWVbhY g9CoPPsV1gxpFhxIOtCbKW1kv4FsHVN9opNzfSvEGpBQplcu4cDfwEIIa65NiaEZoE9g CZmvG0N7wQnbZ4nehD5QbMcfEvvpiqJ/6mlcPzqJuI51zacAW11qV9T0BrOeC2PA847l kOgA== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b="n1u/hT3m"; spf=pass (google.com: domain of fm-68982-2023010513080384c250710d21782a5f-wgab_b@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-68982-2023010513080384c250710d21782a5f-WgaB_B@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net. [185.136.65.225]) by gmr-mx.google.com with ESMTPS id mm6-20020a170906cc4600b007c16d82962dsi1365545ejb.0.2023.01.05.05.08.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jan 2023 05:08:03 -0800 (PST) Received-SPF: pass (google.com: domain of fm-68982-2023010513080384c250710d21782a5f-wgab_b@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) client-ip=185.136.65.225; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b="n1u/hT3m"; spf=pass (google.com: domain of fm-68982-2023010513080384c250710d21782a5f-wgab_b@rts-flowmailer.siemens.com designates 185.136.65.225 as permitted sender) smtp.mailfrom=fm-68982-2023010513080384c250710d21782a5f-WgaB_B@rts-flowmailer.siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 2023010513080384c250710d21782a5f for ; Thu, 05 Jan 2023 14:08:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=florian.bezdeka@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=GTlsWJppRcYZl/2r/0gc4FrI7Wq8cWGlRvlwOiYDl/Q=; b=n1u/hT3mzS6CWnS9fsveYznY2eFwDV5qp+HRDEcDLqdHpmR6DBwOuWO4PTS4a6VVftfu1G 3XE/kQh6EIkadrggmfctAJGxsqchzSAqNYZpQVxxL6hD1MLIMcu5zt3PjNC03Qerdgi1BRHh 9yP+RASsVqeFAoMIrDJR4/nPHSBVQ=; Message-ID: Subject: Re: [PATCH] image: remove / entry from fstab template From: Florian Bezdeka To: isar-users@googlegroups.com Cc: Felix Moessbauer , Jan Kiszka , Anton Mikanovich , Henning Schild Date: Thu, 05 Jan 2023 14:08:02 +0100 In-Reply-To: <20221004114629.27275-1-henning.schild@siemens.com> References: <20221004114629.27275-1-henning.schild@siemens.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-TUID: 5IccRG6pXAq5 On Tue, 2022-10-04 at 13:46 +0200, Henning Schild wrote: > An fstab entry for / should usually not be required. It just makes a > rootfs less portable (USB vs. NFS, vs. SSD). The kernel is the one > that should know which fs to mount and how. That is done via a bootloader= . >=20 > Should additional mount options be needed for a concrete image, an > imager like wic might add an entry. i.e. for adding fspassno or > x-systemd.growfs >=20 > So to make the rootfs more generic and to allow imagers to add their > individual / lines, instead of having to modify an existing one, remove > the line from the template. >=20 > Signed-off-by: Henning Schild Hi all, FYI: While trying to update Isar in one layer using LAVA tests we recognized that there is now a breaking change: Previously the rootfs was mounted rw on ext4 images because we had the / line in /etc/fstab, triggering systemd-remount logic. As the entry for the root (/) has been removed in /etc/fstab remounting does no longer happen. This breaks several LAVA tests here as well as start-qemu scripts. Adding "rw" to the kernel cmdline would be one option but we have a lot of LAVA job descriptions and even more start- qemu scripts in downstream layers. Felix already send out patches to OE (open embedded) to address that in wic. Necessary Isar patches (wic update, ...) will follow soon. Thanks a lot Felix for taking over. Best regards, Florian