From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6739560601010307072 X-Received: by 2002:a1c:1a4b:: with SMTP id a72mr7574264wma.44.1569414582316; Wed, 25 Sep 2019 05:29:42 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:828e:: with SMTP id 14ls2158597wrc.7.gmail; Wed, 25 Sep 2019 05:29:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqz8pu4m1ptOcldEWxVhXtlcxLogC9RyTAG3JCShtVtApMx3yAmY/5yeSoYsUKrneXJbHt8p X-Received: by 2002:adf:e388:: with SMTP id e8mr9398837wrm.306.1569414581736; Wed, 25 Sep 2019 05:29:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569414581; cv=none; d=google.com; s=arc-20160816; b=OJ/Nlp7Dj4XZ9j3LZeTSYw58lRzAGZOmY5kW0Y5z6jeo2/gmznyf0yOGOKXfN8vL2+ vfzSgn8HW9uZIRI10UiyK2+1vRlysftRbUw3f+cE5DIf98dpIpKaDB0gj2z/V0aftraI YBxcF7H9i0J081PZYo2IWexopq8k/zdUQH1CCnKrSRLHiy7jnd4xScTA4LWZwOiSyt6R idssULcrW9rKSWV6BIWKbw/GdShxKEHJ/aRhlc3lFwexgaVuymcZllbZBIPIPST08S70 uIhfxFUzUg6qjwDbM1shCArQ2rPsRUijvRBDQuEHh2GON0nGocGj506nTRAuDNUiL1Iy ckOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=VMebvjGZCBaHwyRE9wM0IDLqr93lYXdk+DOuwuqSBSw=; b=E6mq3np2tAoGmgHx7mBxT2bToyZ+bRCeVz8I6j5nrDoO3q7JlSLtHQ7HsATZESqHy2 32tgyBHT5CWLtE9K3ldeDFTLEq/Xt2P/De5o6axbqgse/6MmSqK8KbKrr7xJmEnFtPyN /IHG+8GlZmnxb9FAa/+yZG36YjImaZYSYLToIosZejYvKtzPqIZBsWlCgCZ0aCtkiwvm YubB8DE0vUMWfGdfOV74SzDYbjcAljFokCvLIrOpj7y91XVUNZgG8DjM6hmJEvVhrBw0 g2xyjcGXRuIRwx7lKvf3VG5V9fol+dYRaCBDMzBFx/qjXaqbe6fV0GLYhFQE8IwfSDo0 KuEA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id i21si349450wml.4.2019.09.25.05.29.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Sep 2019 05:29:41 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x8PCTfgU002595 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 25 Sep 2019 14:29:41 +0200 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x8PCTfkN015615 for ; Wed, 25 Sep 2019 14:29:41 +0200 Subject: Re: [PATCH v5 00/27] Pending patches, fix for isar-bootstrap, devshell To: isar-users@googlegroups.com References: <5c7c8de8-fa74-3f25-4da6-87860a44dbe8@siemens.com> <20190923102337.g6nnnorsuq4rtpth@yssyq.m.ilbers.de> <5010413d-441a-f040-df08-db0be9640b62@siemens.com> <20190925084111.m4ifrrdlhwdbo5rh@yssyq.m.ilbers.de> <4afcdaab-c9fd-fa27-82af-1da1b3c750ea@siemens.com> <20190925092230.37iinm52lo2ggx4n@yssyq.m.ilbers.de> <2e518348-0cb8-6983-20bd-1d0ccdefed0f@siemens.com> <20190925105243.7xd6iyupuvydfibg@yssyq.m.ilbers.de> <3d2856a1-633d-dc5d-7592-b2eb5028e922@siemens.com> <20190925120805.4x6qhqpkbnzk5663@yssyq.m.ilbers.de> From: Jan Kiszka Message-ID: Date: Wed, 25 Sep 2019 14:29:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190925120805.4x6qhqpkbnzk5663@yssyq.m.ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: /xwQ9v5zgDLe On 25.09.19 14:08, Baurzhan Ismagulov wrote: > On Wed, Sep 25, 2019 at 01:05:46PM +0200, Jan Kiszka wrote: >> Yes, that sounds reasonable. Will update and test as well. > > ci_build.sh "-f -r -s" worked, continuing the tests with the version below. > The fix for get_distro_needs_gpg_support looks unrelated to the fix you cite below. Below just unbroke the feature. I will send you a proper separate patch. Jan > With kind regards, > Baurzhan. > > > From: Jan Kiszka > Date: Mon, 26 Aug 2019 08:26:03 +0200 > Subject: [PATCH] isar-bootstrap: Fix keyring generation > > Due to immediate expansion, APT_KEYS_DIR and DISTRO_BOOTSTRAP_KEYRING > were set to invalid WORKDIR, rather than the value relevant when running > do_generate_keyrings in recipe build context. > > Signed-off-by: Jan Kiszka > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > index b49c161..24de667 100644 > --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > @@ -169,6 +169,7 @@ def get_distro_needs_https_support(d, is_host=False): > def get_distro_needs_gpg_support(d): > apt_keys = d.getVar("DISTRO_BOOTSTRAP_KEYS") or "" > apt_keys += " " + (d.getVar("THIRD_PARTY_APT_KEYS") or "") > + apt_keys += " " + (d.getVar("BASE_REPO_KEY") or "") > if apt_keys != " ": > return "gnupg" > return "" > @@ -188,8 +189,8 @@ def get_distro_components_argument(d, is_host): > else: > return "" > > -APT_KEYS_DIR := "${WORKDIR}/aptkeys" > -DISTRO_BOOTSTRAP_KEYRING := "${WORKDIR}/distro-keyring.gpg" > +APT_KEYS_DIR = "${WORKDIR}/aptkeys" > +DISTRO_BOOTSTRAP_KEYRING = "${WORKDIR}/distro-keyring.gpg" > > do_generate_keyrings[cleandirs] = "${APT_KEYS_DIR}" > do_generate_keyrings[dirs] = "${DL_DIR}" > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux