From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7325014627589292032 X-Received: by 2002:a17:90b:790:b0:28c:4c8d:5574 with SMTP id l16-20020a17090b079000b0028c4c8d5574mr6006972pjz.49.1705488354819; Wed, 17 Jan 2024 02:45:54 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:90a:fd95:b0:290:7da:705f with SMTP id cx21-20020a17090afd9500b0029007da705fls102180pjb.1.-pod-prod-00-us; Wed, 17 Jan 2024 02:45:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFSbn14kt5PD/hGpO3p0rr0XF/gPa976h0DXH9u/AUcdEguq3wLx+8kbgBwutThl7rNBAiD X-Received: by 2002:a17:90a:c7c5:b0:28e:79f9:b6c3 with SMTP id gf5-20020a17090ac7c500b0028e79f9b6c3mr934402pjb.15.1705488353449; Wed, 17 Jan 2024 02:45:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705488353; cv=pass; d=google.com; s=arc-20160816; b=TWeHpNnY+wxmwjo62qix0Tqi32fHn3TWb2bxysBNtbI1tJmT8LnbF3UF8AXrYCy3Vz KnyMcVxN6IToRlwV5itPEvWrLqBd1boK1PoekoPeQui3kQfNSCOtmeWP+ibzNerTN5af N07kleW6Rd8qnBWUtHuwx7Uz6fix0kOBGMEksKYFE2smLqJUNgwm0oXcZLb3qMbL9ZAR 81Kp/v3XSmOxGLDv9h0Q8M3qktyMaPBSWiIij+m3h7XiYnmYO5MDocJlRt19ZEoDRMro b/qrVm+kvGwbqkkvhK1kRKF5i7xTvnZHMSf6ANxiGgM7w+zFFlXGO2Ur2RmlnvQvmhz5 dMDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-transfer-encoding:in-reply-to:from:references :to:content-language:subject:user-agent:date:message-id :dkim-signature; bh=xPzImCYoQcSyf+TZUaYGOpX2TWmPU5TMPBhNaF0iUj0=; fh=ez+yYIN2+t1/A1KtVD1essDQ6+anTTnZTbSXjuK9WaU=; b=XuO2/Ysk0ZB8Vn+bO1Bw5Gve7qwMUrDpbFxOuCAYKOpaQpIHbo4PD9Q7UsyEk4+Hd3 aWs7gOOW0A+55amhva0FXrqQb6zK+eOhBHKh3TOf8mmdnYU4PGdlpaU+TIuishLbN7QD zQuaezMuZ4cXdaINuxEkkLqdA07tgrC0+0LNQh9g4FpH+9iIp7d9x+KeMp9iCLJxOt4w Y/GpPlIMLvNadJ48kn7cNN/cXuHk/nk8zkNMbnEl3FUecNM6OTNDElP5gFrVD8kj+VP2 CLOQs5smDx+zbfL8jVh/7hmbtxVf8hKpBxVtBRxGuleubV52GR67J76jftsYjSJO0zmW iQ0w== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="CMER/zG8"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::619 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0619.outbound.protection.outlook.com. [2a01:111:f400:fe0e::619]) by gmr-mx.google.com with ESMTPS id y23-20020a17090aa41700b0028ff720a0d2si68699pjp.0.2024.01.17.02.45.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jan 2024 02:45:53 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::619 as permitted sender) client-ip=2a01:111:f400:fe0e::619; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b="CMER/zG8"; arc=pass (i=1 spf=pass spfdomain=siemens.com dkim=pass dkdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 2a01:111:f400:fe0e::619 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MN8a/j6SWHGrjUcQJDRT9Mij8I7JjV/2cGVF0A75JL/iSu5ouHjaOYfTUEDdGf0Qz9LQm6Fr+RH8APbbkKUR2RHRvJ6R9COMJzvFMBriS5Vc8LpD+f0SVqsqY187B27s1h2P1jUZyytiHjejWYZxECCoyPtJtnZsjT22NHotMzGi9/Je+fbVVyrxEeiWvogk3C5XcO+XtXHZIlrTKJHuwZGFKCmxfxP+R7sFr2MiVbvi9iNu3HTX0GNoSy8+uydq0vt6JLt9IT//EDBoSSP+4uYwnzpN2LWEjEgBUSNy62T+4ZhsDrOt+1NWDde8Go5wBG3IDyqzqUabUSJXKH1Saw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xPzImCYoQcSyf+TZUaYGOpX2TWmPU5TMPBhNaF0iUj0=; b=IMCWMjpTVAhgrx+WKUNbnTbTneUaIDBolG1bB7HYPewaGEWVyjWc6aYCWBC8/yVvewqaL63hm7tSahSq8RFHa8W+OFGcCWyWO5hKrXcNAvzi6a1/NkvmNeap3OHVii6s3J9IfY4fXk1YpjrtWj5Ss2L/OJSccPQUxXh0HuT3OH1PQNI4eTBs946b93+nu3TOiKnXsgTRLfXzlD4nqxn75Mx780YJ4Q4nQAD8OiOCYdk6pYh9U82NP7solOMq/m79oPifgxkE2G7Jb0iHDTvuibBoMdWsgFMt1vAsyFVnWnu6ZVJme0LZ79gV3OJWpRgWoCOmyXI43jOwaJPpYXmA4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=siemens.com; dmarc=pass action=none header.from=siemens.com; dkim=pass header.d=siemens.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xPzImCYoQcSyf+TZUaYGOpX2TWmPU5TMPBhNaF0iUj0=; b=CMER/zG8VeqF5F4E1jqQjZymLWOddvlQ2xfCC6vJ2r1PGw3+HPWBDNqTJrZZUcaGNSUu3+sQeRQx4qu5tf6Y0hG+O6AHxCwGdxxySv0zGoO5OOR2Lb4IYwmY8OdDZHZCcYK8T7T/xT0mYTQq0yMYtRFelDCCD1XmWgbNRatsEBwKCjk6c9BbetIC4rbD2LvYTKZ8xaBgyKHIQs5QTc3UEmOHdcPy4lXcAxfEyLgjjIxl04lDQ1Dier99KF0BVLBpdii1YMAVSK6Bpl/EGTImFXfMey/ukJ2rFCMOCr5i8q197mExWS8bYwS6m5DD04Oh45qUsSUvvhwhNGDI1eQEgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=siemens.com; Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) by GV2PR10MB6186.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:76::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.26; Wed, 17 Jan 2024 10:45:47 +0000 Received: from AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe]) by AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM ([fe80::8d16:7fbb:4964:94fe%3]) with mapi id 15.20.7181.026; Wed, 17 Jan 2024 10:45:47 +0000 Message-ID: Date: Wed, 17 Jan 2024 11:45:45 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] fix dependencies of devshell tasks Content-Language: en-US To: Felix Moessbauer , isar-users@googlegroups.com References: <20240117103730.241499-1-felix.moessbauer@siemens.com> From: Jan Kiszka In-Reply-To: <20240117103730.241499-1-felix.moessbauer@siemens.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ce::20) To AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:588::19) Return-Path: jan.kiszka@siemens.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS4PR10MB6181:EE_|GV2PR10MB6186:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e1874cd-5091-4fe6-1364-08dc174976a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7YlN6iXw3CjnYYsHvrlxRxoBSNh9qtLIc6MunzDhDuhGwjVHkFIxPcfAOlz0CKq/1Cy42PA6I+vvzZdsgmlJgt8YMTJL3xinPu6Zx/IZvjeqv2Fd11xeXfli2uo+FHo/lTXDc5WOh/K1lp7wuL6/vELsMLECDYW8otTRe1bP0/+Dtl4ctexxktKITj0IZcJu2Dy0tubLG5Wy/10Z87G3nZHO7p1GAX8xpwDKr21Ca6JbNMdZjKMgea25CfEIeGiPupIO/gi4C4VpnliPC7Dwvyc/JHlSS1u8LPPPZCMU4WckYRvCpjZtHqEFAtBYyKKDppOomkjojwWL8ofhTnxEsl9UX61t/1NMLB0E7RWY1fFmwrxllIV8lw1tyS9KMQa+I/71Ly+zJC/lIRZi7RfiTCYYC8QqNj6PPXGRsJAxZiCHAdw/Q75dh8bj2oVIDuNBB8g7C7MsYVIXZuw6adFRBmdFtoP1+5AkKBMLm9Mgnd93eEM6yP85/GXIWu3LGU4bwhDfazmMOLEgnjyaygDgMX+89CP9E/SAiq7QkWvzl6d9Vc+G6SkbLexLHtQao/1lDRyKRMXlEIHsWdsHn0g2PzBk8cY5LyxXGkxJRjCeaxlayl6h8eXUmx5Kb6xYOBkJXu9uMspE8fO1myZ3GRhq9g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(366004)(136003)(346002)(39860400002)(376002)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(2906002)(41300700001)(36756003)(31696002)(86362001)(53546011)(38100700002)(82960400001)(6506007)(66946007)(8676002)(66476007)(6512007)(6486002)(83380400001)(478600001)(316002)(5660300002)(44832011)(2616005)(8936002)(66556008)(26005)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0pxU0h5SittT1JlRUlCMjVaaWRvM054WkRqbFZONlFPRTVkeElxNWl5L3R2?= =?utf-8?B?cFRva2hFbFlTbWdOZGxkMXFpeUJraHo2RGEwU0tmWDJua3FyMVJqY1AzaEsw?= =?utf-8?B?bGdJcTZTV21jQnc0Y2dYV3FHSmV5WWg1RUorQUN6dGwwUjdnaVNxVGt4cUJX?= =?utf-8?B?anZjUXNDVDA2ekpEZ1paQWNieHVxdjZLOTJwZDkxZjFDd2ZVMnJlalVjNWhv?= =?utf-8?B?SFgxRkxxRWdRS0FLbVovQUVYMytJUktsOUJUWlFJSVRnSWpBY2gyU2JUUzU4?= =?utf-8?B?ZFBTK3FzOEpSRVlMUG45bklhT2FCNWtVb3VjZ1VDemUzclF4cWViZXMyQzY5?= =?utf-8?B?YXpOdlUvT1FCSDZDMXhxMjU1M20wSUIwc1QrdUlZK0xub0RZQzVlY0xyNDNF?= =?utf-8?B?WWkvVGRwbDZaSlAwTCtOSDlSMngrUnRWcDhKTms1N3hpUjZzYklTK2JGd3hV?= =?utf-8?B?NzJxc2xkdEpHcGNFWWhNdWlLbGJIKzd6aHdhcjFWdjlZMU9uNDJraFJYOFlB?= =?utf-8?B?SlFyV0FRUWNmVWlGZStLOVdTMlNYMXhPTmFvSU0wdlNvYVBGeGRiRWFnTVhM?= =?utf-8?B?cGZOajh3d2pSenJzNXhsRFFMNmtCZUVCOXNSZ0dXU1d6aGRBVG43V3ZLcmhU?= =?utf-8?B?NE1VNlhyaXllYlVCTlI5S2tqWElBY3hpeThiZW5mMERrTE1wSi9ZWlZjQlJD?= =?utf-8?B?VG5nZlRrdjJ3djc1akEwMm04NU1LSGFaQUZGV3hNSzFxcnlMT2s1ckgvSjh5?= =?utf-8?B?QVZoR1BEeHRkb0ova3Rqd3VHMlJtVEtBeXI1QSt0djdCZ1lYTUljdWFhTGFS?= =?utf-8?B?L0lEYmNWYnZGZ2dhTHBoNXE0QThSK05rL1V5TWxyQTN4T24vUzFxVC9UUzN3?= =?utf-8?B?NGplNzFPK0JKMUYxTVp5SnVuMXhCOS9qWkM4VE5KNVdiQ2xEaWxleWV3TE9N?= =?utf-8?B?VjREVGpsSmtRdVRQQzRDdnVadHFjR2lNUXF2bys4RHJiZW9CeE1GUFlsdGU3?= =?utf-8?B?aUN6eElXWjhVK0VVamNEcSt1MnVRNndraUZYZHFjc3BGN3VGYnlpT2liM2Jq?= =?utf-8?B?M0c5NmNUTVFFclFtVys0NFVhYm1hcXlXVVEwb29aaVZjRU45R3JrWHpyRnVC?= =?utf-8?B?TFYvNzl2ZnJ4OFhrdVl5YS82aUY1WjB6Y0NnWU1WMWQwUHNUS1FpMEtMTy9I?= =?utf-8?B?d0pPVkYyUzZQQ2VCUkdRVmtlL2QraGpuUWQxaWFsdVlWVGNqVzVncUJZZjJF?= =?utf-8?B?anE5SHQyZEdiaEltWTBPUkx4em42NitMSWszUnE2U05nN3psMDkveXYzMVVq?= =?utf-8?B?dHdpQ0FWcUcxTkdlcHBaNHpMeVhaQk5aY09KTzdKbUhYMHNIUzVjTnJYaGtj?= =?utf-8?B?RkIzcGxxZk1oeFdtWkpQMWpzOE84WjZqbWsxb0pBT1ZQdDRrcEo3dU1pNFZW?= =?utf-8?B?ZW9VL3BNSC9HNmFJMThEWHMyWXFJYkxJd1p3K1UrK0FobkkxU1BkanBocGcw?= =?utf-8?B?eHFkSktLZW1LbTg2NDlIU3A3NklZTElGUjdUYkJDc1paa3FFTzF1ZlhJUVlx?= =?utf-8?B?aHNFTExIKzJZOTRMNk56cXgxWmsyMVpRY0hnSzhtSkVsVjAyTjhaYkJ1SC8v?= =?utf-8?B?aE1wQnlvRVgxQ2xkTGNFWS83NnNOWDRLMXhmc2dDbXcyekkxTzdrdUMvWDNh?= =?utf-8?B?ZzVzZ0RRWlh6ekp0N2wzTVFVSWI3dEhwUE5LYW8rODd0QUdXeFQ4eWNMUnox?= =?utf-8?B?eXZsaXZKd0I1cDA1MnVDREpLUm5TdHhmeDUwT2VSQ3ZURXFEa3p0WGxhMTdZ?= =?utf-8?B?QVBOQW9WcE9QRzFBaENaaFpERWROcytIemZiTU5RUjArVW12bjFPWDY0MzZI?= =?utf-8?B?Q0QvVWNuUVd3WTFzcUE3SVVuWnNrWjFZSDlObFpDTXQvZW9WbXpSOHd5aHNr?= =?utf-8?B?V2dlMXFRRk5JdVROaUtSOW55WUd5ODJWMXV5RGFUYlpFbVpuY2IxQ0NTZ1R5?= =?utf-8?B?OGJNRXl1TEwzSjBkRTJsSUVrWTBBdENZK0xWbE1wTFZqeklFSDNleVpEVkt4?= =?utf-8?B?VW5sU3BlM2I1MUQ3UTVUMnIvNjNkRWg0WC8xK1RqcU85SmdYaCtkcHpUYTBH?= =?utf-8?B?M0FlZk9VRE4vRzJjaktSaWZXdlZFaEdhT0llaitYNXVwKzZhdDIrY1FzeU40?= =?utf-8?B?NEE9PQ==?= X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e1874cd-5091-4fe6-1364-08dc174976a5 X-MS-Exchange-CrossTenant-AuthSource: AS4PR10MB6181.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2024 10:45:47.1458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Wc7NsFs8aJycmXbjA+o8SqzcRAXySWbs4YJav8/bkQ6Gp4Z5hOHDjzyZnGEmBmUi//BWHUlQTycdCpEa6/OZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR10MB6186 X-TUID: KlBo4CEOUJVm On 17.01.24 11:37, 'Felix Moessbauer' via isar-users wrote: > In 21a0560 the local_isarapt task was introduced, which needs to run > before the devshell. By that, the dependencies of the devshell tasks > got updated as well. However, the do_prepare_build also needs to run > before the devshell, as otherwise the preparation logic is not > executed. > > This commit re-introduces (adds) this dependency again. > > Signed-off-by: Felix Moessbauer > --- > meta/classes/dpkg-base.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/dpkg-base.bbclass b/meta/classes/dpkg-base.bbclass > index 7b054d3f..95ca3db8 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -323,7 +323,7 @@ python do_devshell() { > bb.build.exec_func('schroot_delete_configs', d) > } > > -addtask devshell after do_local_isarapt > +addtask devshell after do_local_isarapt do_prepare_build > DEVSHELL_STARTDIR ?= "${S}" > do_devshell[dirs] = "${DEVSHELL_STARTDIR}" > do_devshell[nostamp] = "1" > @@ -335,7 +335,7 @@ python do_devshell_nodeps() { > > # devshell may be placed after do_instell_builddeps in downstream classes. > # devshell_nodeps will always stay right after do_prepare_build. > -addtask devshell_nodeps after do_local_isarapt > +addtask devshell_nodeps after do_local_isarapt do_prepare_build > do_devshell_nodeps[dirs] = "${DEVSHELL_STARTDIR}" > do_devshell_nodeps[nostamp] = "1" > do_devshell_nodeps[network] = "${TASK_USE_SUDO}" Reviewed-by: Jan Kiszka Seems the comment above was not read while doing the previous change. ;) Jan -- Siemens AG, Technology Linux Expert Center