From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6795913180323250176 X-Received: by 2002:a2e:98c6:: with SMTP id s6mr30685473ljj.14.1582549508635; Mon, 24 Feb 2020 05:05:08 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:ac2:4d0e:: with SMTP id r14ls1012348lfi.10.gmail; Mon, 24 Feb 2020 05:05:08 -0800 (PST) X-Google-Smtp-Source: APXvYqxmlmeXJxgmyXaz5lZI2iiavdemIc92lsi6rNu5CCQtQ76+reSsyaW9HkGUlF9b3IBDQhx9 X-Received: by 2002:ac2:52a5:: with SMTP id r5mr27458161lfm.19.1582549507776; Mon, 24 Feb 2020 05:05:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1582549507; cv=none; d=google.com; s=arc-20160816; b=0iod7v/G/krE/d+QK26irfNkhBeyrPl16W+e3XSEQrnvaK4qXptCfq8z1ecADlv2vr FKbGZ2MDmdzG9iFn86yF2TuCTLu1njL0z6QVWoHtp2sCAWx91QmwT5nj0/c4lmziFtHL WdMhsG+qbiikhXgx6hjLqiLRCmzLCKSw5WkmxoQqQs7h1Eid2iGgLdGSf+JIbG7Uf4ue rYBYTzhU3VUFpYwUaKAys1f93m76h8XvH83SjS5V4a770bR8WK2Ec8kfzK0Vz8oY2QmJ FQ8z8iG0R/82GIrSBF3I8ejmI1tH/I/pCnceP0nllR3Cw+WVLagdKd1Txdm9IOnmkQqz F9qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=A6EGJagtwxcHJGemM0pzq9bmA27Oi8crNlXvg76zw2Q=; b=krOBvOPtUZzCx7jMEJQCwJqILtW3lCzM3/ODAL61fLK82C5GqLAZ3Xd4FeVo6zm075 vMR8MB7Tn4OuNN61xEUxLGy6yPSd2OAAaYAYXFcDsoBeHxfD6B+Qa5fmrtBXuWkyOgt0 P4bCkyrS5dgkvZyklxkHjirlkXQtm95IjWIEFrjjv11kZTlHdV/lJo7TtJxGYC0fKbkL nJZhye9loF8e3fyYmjZ9b4mRvMVZlGtmJCd4ZU7CxcBnfBfsKWmzv6hIKJje5gIbfhUb 2NSLtl8MhSbcjYsvu7X3Ho0mI4a8dh86F34O5TQIN7hIGDpYeqUlW5KoZmnZJkLJILBA Sr9g== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id a11si864578lff.0.2020.02.24.05.05.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Feb 2020 05:05:07 -0800 (PST) Received-SPF: pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of quirin.gylstorff@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=quirin.gylstorff@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id 01OD568T021523 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 24 Feb 2020 14:05:07 +0100 Received: from [139.25.68.236] ([139.25.68.236]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 01OD56VB028586; Mon, 24 Feb 2020 14:05:06 +0100 Subject: Re: [RFC 1/2] meta/classes: Add remove packages to rootfs postprocessing To: Jan Kiszka , isar-users@googlegroups.com, henning.schild@siemens.com References: <20200221145348.24250-1-Quirin.Gylstorff@siemens.com> <20200221145348.24250-2-Quirin.Gylstorff@siemens.com> From: Gylstorff Quirin Message-ID: Date: Mon, 24 Feb 2020 14:04:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: NCat6hFYZyrN On 2/21/20 7:28 PM, Jan Kiszka wrote: > On 21.02.20 15:53, Q. Gylstorff wrote: >> From: Quirin Gylstorff >> >> Remove non-essential packages to reduce the amount of packages >> to be cleared. It can also to used to reduce the foot print >> of a image. > > Lacks documentation: This does not remove non-essential packages by > itself. It provides a configuration channel > (ROOTFS_PACKAGES_FORCE_REMOVE) to request arbitrary package removals. > That should be clearly described, along with the warning about this > weapon (expert tool). > > Do you also have a set of removal candidates to share with users? > You mean something like this: This function allows to remove non essential debian packages even if there are dependencies to them. The feature can be activate in a image or sdk rootfs by adding `remove_packages` to the variable ROOTFS_FEATURES. The packages you want to remove are added to `ROOTFS_PACKAGES_FORCE_REMOVE` separated by a space. e.g. ROOTFS_PACKAGES_FORCE_REMOVE = "example_package". The following package are installed and are non-essential [1]: adduser, apt, debian-archive-keyring, gcc-8-base, gpgv, libapt-pkg5.0, libffi6, libgmp10, libgnutls30, libhogweed4, libidn2-0, libnettle6, libp11-kit0, libsemanage-common, libsemanage1, libsepol1, libstdc++6, libtasn1-6, libunistring2, libustr-1.0-1, lsb-base, passwd, tzdata Also removable are: e2fsprogs[2] The removal of a package depends on the given use-case and should be executed by a expert user as it can leave the system non-functional. [1]: https://wiki.debian.org/BusterPriorityRequalification [2]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=474540 >> >> Signed-off-by: Quirin Gylstorff >> --- >>   meta/classes/image.bbclass  |  2 +- >>   meta/classes/rootfs.bbclass | 13 +++++++++++++ >>   2 files changed, 14 insertions(+), 1 deletion(-) >> >> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >> index 6bcc6cd..62d6f46 100644 >> --- a/meta/classes/image.bbclass >> +++ b/meta/classes/image.bbclass >> @@ -60,7 +60,7 @@ image_do_mounts() { >>   } >>   ROOTFSDIR = "${IMAGE_ROOTFS}" >> -ROOTFS_FEATURES += "copy-package-cache clean-package-cache >> finalize-rootfs generate-manifest" >> +ROOTFS_FEATURES += "copy-package-cache clean-package-cache >> finalize-rootfs generate-manifest remove_packages" >>   ROOTFS_PACKAGES += "${IMAGE_PREINSTALL} ${IMAGE_INSTALL}" >>   ROOTFS_MANIFEST_DEPLOY_DIR ?= "${DEPLOY_DIR_IMAGE}" >> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass >> index 64eaef7..0329f55 100644 >> --- a/meta/classes/rootfs.bbclass >> +++ b/meta/classes/rootfs.bbclass >> @@ -187,6 +187,19 @@ rootfs_postprocess_clean_package_cache() { >>           /usr/bin/apt-get clean >>       sudo rm -rf "${ROOTFSDIR}/var/lib/apt/lists/"* >>   } >> +ROOTFS_POSTPROCESS_COMMAND += >> "${@bb.utils.contains('ROOTFS_FEATURES', 'remove_packages', >> 'rootfs_rm_packages', '', d)}" >> +rootfs_rm_packages () { >> +    if [ -n "${ROOTFS_PACKAGES_FORCE_REMOVE}" ]; then >> +        RMPKGS=$(sudo -E chroot "${ROOTFSDIR}" \ >> +              dpkg-query \ >> +              -f '${Package}\n' \ >> +              -W ${ROOTFS_PACKAGES_FORCE_REMOVE} 2>/dev/null || true) >> +    fi >> +    if [ -n "${RMPKGS}" ]; then >> +        sudo -E chroot "${ROOTFSDIR}" \ >> +            dpkg --purge --force-depends ${RMPKGS} >> +    fi >> +} >>   ROOTFS_POSTPROCESS_COMMAND += >> "${@bb.utils.contains('ROOTFS_FEATURES', 'generate-manifest', >> 'rootfs_generate_manifest', '', d)}" >>   rootfs_generate_manifest () { >> > > Jan > -- Quirin Gylstorff Siemens AG Corporate Technology Research in Digitalization and Automation Smart Embedded Systems CT RDA IOT SES-DE Otto-Hahn-Ring 6 81739 Muenchen, Germany Mobile: +49 173 3746683 mailto:quirin.gylstorff@siemens.com www.siemens.com/ingenuityforlife Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Jim Hagemann Snabe; Managing Board: Joe Kaeser, Chairman, President and Chief Executive Officer; Roland Busch, Lisa Davis, Klaus Helmrich, Cedrik Neike, Michael Sen, Ralf P. Thomas; Registered offices: Berlin and Munich, Germany; Commercial registries: Berlin Charlottenburg, HRB 12300, Munich, HRB 6684; WEEE-Reg.-No. DE 23691322 Important notice: This e-mail and any attachment thereof contain corporate proprietary information. If you have received it by mistake, please notify us immediately by reply e-mail and delete this e-mail and its attachments from your system. Thank you.