Re: [URGENT][PATCH v3 0/2] Correctly determine kernel and initrd versions

[Alexander Smirnov <asmirnov@ilbers.de>]

On 10/18/2017 04:47 PM, Alexander Smirnov wrote:
> 
> 
> On 10/18/2017 04:23 PM, Claudius Heine wrote:
>> Hi,
>>
>> On 10/18/2017 02:08 PM, Alexander Smirnov wrote:
>>> Hi all,
>>> On 10/18/2017 01:13 PM, Alexander Smirnov wrote:
>>>> Hello all,
>>>>
>>>> IMPORTANT: lets try to review this series ASAP, becuase Isar build is
>>>> broken again due to recent update of Raspbian kernel version in apt.
>>>> Instead of yet-another-version update I'd like to commit proper
>>>> solution.
>>>>
>>>> In current Isar implementation, multiconfig file contains hardcoded
>>>> version for boot files: kernel and initrd. This is used for both:
>>>>
>>>>   - Add respective package to multistrap config.
>>>>   - Copy boot files to deploy directory.
>>>>
>>>> This series drops this hardcoded versions, so now Isar is able to
>>>> determine version of boot files during building.
>>>>
>>>> Changes since v2:
>>>>   - Avoid races in 'deploy/images' folder creation.
>>>>
>>>> Changes since v1:
>>>>   - Differentiate 'do_copy_boot_files' stamps.
>>>>   - Update start_vm script accordingly.
>>>>   - Check if symlinks 'vmlinuz' and 'initrd.img' exist before reading
>>>>     them. If symlink doesn't exist, this function skips it.
>>>
>>> any feedback on this?
>>
>> Just about Hennings readlink remark. You might want to try 'readlink 
>> -m' instead of 'readlink -e'. It appears that the target of your 
>> symlink didn't exist, so 'readlink -e' returns nothing.
> 
> I've tried '-m', but there is another problem:
> 
> 1. If symlink references absolute path, then readlink returns this 
> absolute path, i.e.:
> 
> $ ln -s /boot/abc l1
> $ readlink -m l1
> /boot/abc/
> 
> 2. If symlink references relative path, so the absolute path is added:
> 
> $ ln -s boot/abc l2
> $ readlink -m l2
> /home/asmirnov/Work/isar/isar/boot/abc/
> 
> 
> So then I propose to use basename and concatenate absolute path like:
> 
> KERNEL_IMAGE=$(basename $(readlink -m ...))
> cp ${IMAGE_ROOTFS}/boot/$KERNEL_IMAGE ...
> 

Due to series is urgent, will do this in separate patch.

Alex