From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6477538949418975232 X-Received: by 10.28.138.130 with SMTP id m124mr902443wmd.27.1508346924207; Wed, 18 Oct 2017 10:15:24 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.223.181.129 with SMTP id c1ls1388103wre.9.gmail; Wed, 18 Oct 2017 10:15:24 -0700 (PDT) X-Google-Smtp-Source: ABhQp+TIe+O9YAgJvtVidKHT+q2Y6apyL+X/k+JtVz37aPXU3T/FeWtI8ADlEElt/3UGN1Ni1A3d X-Received: by 10.28.217.201 with SMTP id q192mr948887wmg.20.1508346923938; Wed, 18 Oct 2017 10:15:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1508346923; cv=none; d=google.com; s=arc-20160816; b=dnUMXJnki0JrRDma1BW7sZorZjHcVShZDqUw2NmN6XEnxwPsArly1Rnv9GUI2uPp0G XLRDY6atq1jECwF38brm91SdF7QjNnormQ+mtVMZicqDSDKXW1Q4I8+It1y+65q9RAup 5W5WjqWq2ua7R9qTKSWHL13SY3Zc3Hm1lFn5Al30cunCL3Lqk0YV0X1lKCUYQkDjXcsp id4R1wF6eh1vCnp+6KiUImUh7pLPg44RwhB0xJOhXFhjRZ5x/2ft1b3NiZVW4T8dIP7V eL5/4RZkM7kYLUU5VZUf0VwWhaxdn1ECffylmFdFZWPk6c84RMRVi4XpPDHfjdRm/TA6 n93A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject :arc-authentication-results; bh=IfJO4oP0ZJvZVhQIUCJD0CPMzuHrxl6r5cZSJZOgitE=; b=e7r6CuB+DxhDMMeBVa9YvHRxa4UpZIkTlFZKM5VtnmyFLXcqDXgnejAV3yg2ArdM0n Y7XIlX7SS9V/3k5VpxMD+rSTU2FmT4u1hw2huIoICDNwwUB8sfrM4EIjjZPw9jx8Ux/Q NJcDEzhemWb16u6mGR9ZG56aZm/gNBmd7B1vH6rowXzZMiYtaemjeF9L9LEJ+4VO3P2X W+0pYL/+IWEcQINaf6rphNuz+iBNV3/lUp5hfSPQSHvN4wHUFJRqKlZB7MmsTouAGysw Nh7Q42jrhqH/nzecCTZTfDnkDm3G5pQxX0xw53PqiJozXmKvo/uV11ENxI1OA2iy0jzK DDNg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id l9si661140wrf.4.2017.10.18.10.15.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Oct 2017 10:15:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v9IHFKRb004632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 18 Oct 2017 19:15:22 +0200 Subject: Re: [URGENT][PATCH v3 0/2] Correctly determine kernel and initrd versions From: Alexander Smirnov To: Claudius Heine , isar-users@googlegroups.com References: <20171018101325.12358-1-asmirnov@ilbers.de> <435959dc-da9c-6cb3-92b6-e275d446c153@ilbers.de> <462a48a1-571f-d25f-ebcc-c3d311605ba0@siemens.com> <8f89e657-1496-7a12-a6ca-f8c51aad8b97@ilbers.de> Message-ID: Date: Wed, 18 Oct 2017 20:15:15 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8f89e657-1496-7a12-a6ca-f8c51aad8b97@ilbers.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 5mWBByW7w36E On 10/18/2017 04:47 PM, Alexander Smirnov wrote: > > > On 10/18/2017 04:23 PM, Claudius Heine wrote: >> Hi, >> >> On 10/18/2017 02:08 PM, Alexander Smirnov wrote: >>> Hi all, >>> On 10/18/2017 01:13 PM, Alexander Smirnov wrote: >>>> Hello all, >>>> >>>> IMPORTANT: lets try to review this series ASAP, becuase Isar build is >>>> broken again due to recent update of Raspbian kernel version in apt. >>>> Instead of yet-another-version update I'd like to commit proper >>>> solution. >>>> >>>> In current Isar implementation, multiconfig file contains hardcoded >>>> version for boot files: kernel and initrd. This is used for both: >>>> >>>> - Add respective package to multistrap config. >>>> - Copy boot files to deploy directory. >>>> >>>> This series drops this hardcoded versions, so now Isar is able to >>>> determine version of boot files during building. >>>> >>>> Changes since v2: >>>> - Avoid races in 'deploy/images' folder creation. >>>> >>>> Changes since v1: >>>> - Differentiate 'do_copy_boot_files' stamps. >>>> - Update start_vm script accordingly. >>>> - Check if symlinks 'vmlinuz' and 'initrd.img' exist before reading >>>> them. If symlink doesn't exist, this function skips it. >>> >>> any feedback on this? >> >> Just about Hennings readlink remark. You might want to try 'readlink >> -m' instead of 'readlink -e'. It appears that the target of your >> symlink didn't exist, so 'readlink -e' returns nothing. > > I've tried '-m', but there is another problem: > > 1. If symlink references absolute path, then readlink returns this > absolute path, i.e.: > > $ ln -s /boot/abc l1 > $ readlink -m l1 > /boot/abc/ > > 2. If symlink references relative path, so the absolute path is added: > > $ ln -s boot/abc l2 > $ readlink -m l2 > /home/asmirnov/Work/isar/isar/boot/abc/ > > > So then I propose to use basename and concatenate absolute path like: > > KERNEL_IMAGE=$(basename $(readlink -m ...)) > cp ${IMAGE_ROOTFS}/boot/$KERNEL_IMAGE ... > Due to series is urgent, will do this in separate patch. Alex