public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] kas: correct TTY services variable for target-bootstrapper
@ 2025-12-13 14:06 'Badrikesh Prusty' via isar-users
  2025-12-15  7:23 ` 'MOESSBAUER, Felix' via isar-users
  0 siblings, 1 reply; 3+ messages in thread
From: 'Badrikesh Prusty' via isar-users @ 2025-12-13 14:06 UTC (permalink / raw)
  To: isar-users; +Cc: Badrikesh Prusty

Replace incorrect INSTALLER_TTY_SERVICES with
TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
for the target bootstrapper.
Fix isar-installer not launching on the user-configured TTY from the
kas menu system.

Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
---
 kas/installer/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kas/installer/Kconfig b/kas/installer/Kconfig
index ccac6471..5e733f9e 100644
--- a/kas/installer/Kconfig
+++ b/kas/installer/Kconfig
@@ -92,7 +92,7 @@ config KAS_INCLUDE_INSTALLER_ADD_DEVICE_INFO_COLLECTOR
 	default "kas/installer/add-device-info-collector.yaml"
     depends on INSTALLER_ADD_DEVICE_INFO_COLLECTOR
 
-config INSTALLER_TTY_SERVICES
+config TARGET_BOOTSTRAPPER_TTY_SERVICES
 	string "TTY Service to use"
 	default "getty@tty1 serial-getty@ttyS0" if !INSTALL_UNATTENDED
 	default "serial-getty@ttyS0" if INSTALL_UNATTENDED
-- 
2.47.3

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251213140654.1142110-1-badrikesh.prusty%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kas: correct TTY services variable for target-bootstrapper
  2025-12-13 14:06 [PATCH] kas: correct TTY services variable for target-bootstrapper 'Badrikesh Prusty' via isar-users
@ 2025-12-15  7:23 ` 'MOESSBAUER, Felix' via isar-users
  2025-12-15 10:28   ` 'Heinisch, Alexander' via isar-users
  0 siblings, 1 reply; 3+ messages in thread
From: 'MOESSBAUER, Felix' via isar-users @ 2025-12-15  7:23 UTC (permalink / raw)
  To: Prusty, Badrikesh, isar-users; +Cc: Heinisch, Alexander

On Sat, 2025-12-13 at 09:06 -0500, 'Badrikesh Prusty' via isar-users
wrote:
> Replace incorrect INSTALLER_TTY_SERVICES with
> TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY services
> for the target bootstrapper.
> Fix isar-installer not launching on the user-configured TTY from the
> kas menu system.

Hi,

please add a fixes tag and include the original patch author (+CC
Alexander) in the review process.

Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in
unattended mode.")

Felix

> 
> Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> ---
>  kas/installer/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kas/installer/Kconfig b/kas/installer/Kconfig
> index ccac6471..5e733f9e 100644
> --- a/kas/installer/Kconfig
> +++ b/kas/installer/Kconfig
> @@ -92,7 +92,7 @@ config KAS_INCLUDE_INSTALLER_ADD_DEVICE_INFO_COLLECTOR
>  	default "kas/installer/add-device-info-collector.yaml"
>      depends on INSTALLER_ADD_DEVICE_INFO_COLLECTOR
>  
> -config INSTALLER_TTY_SERVICES
> +config TARGET_BOOTSTRAPPER_TTY_SERVICES
>  	string "TTY Service to use"
>  	default "getty@tty1 serial-getty@ttyS0" if !INSTALL_UNATTENDED
>  	default "serial-getty@ttyS0" if INSTALL_UNATTENDED
> -- 
> 2.47.3
> 
> -- 
> You received this message because you are subscribed to the Google Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
> To view this discussion visit https://groups.google.com/d/msgid/isar-users/20251213140654.1142110-1-badrikesh.prusty%40siemens.com.

-- 
Siemens AG
Linux Expert Center
Friedrich-Ludwig-Bauer-Str. 3
85748 Garching, Germany

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/341bdfbfb0940f5ec185fbf6690bea14b30d1181.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kas: correct TTY services variable for target-bootstrapper
  2025-12-15  7:23 ` 'MOESSBAUER, Felix' via isar-users
@ 2025-12-15 10:28   ` 'Heinisch, Alexander' via isar-users
  0 siblings, 0 replies; 3+ messages in thread
From: 'Heinisch, Alexander' via isar-users @ 2025-12-15 10:28 UTC (permalink / raw)
  To: Prusty, Badrikesh, isar-users, MOESSBAUER, Felix

On Mon, 2025-12-15 at 07:23 +0000, Moessbauer, Felix (FT RPD CED OES-
DE) wrote:
> On Sat, 2025-12-13 at 09:06 -0500, 'Badrikesh Prusty' via isar-users
> wrote:
> > Replace incorrect INSTALLER_TTY_SERVICES with
> > TARGET_BOOTSTRAPPER_TTY_SERVICES to configure the correct TTY
> > services
> > for the target bootstrapper.
> > Fix isar-installer not launching on the user-configured TTY from
> > the
> > kas menu system.

Good catch!
Seems I renamed last minute and failed to rename all assignments.

>
> Hi,
>
> please add a fixes tag and include the original patch author (+CC
> Alexander) in the review process.
>
> Fixes: d7bc3583 ("isar-installer: Fixing race between ttys in
> unattended mode.")
>
Second that!

> Felix
>
> >
> > Signed-off-by: Badrikesh Prusty <badrikesh.prusty@siemens.com>
> > ---
> >  kas/installer/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kas/installer/Kconfig b/kas/installer/Kconfig
> > index ccac6471..5e733f9e 100644
> > --- a/kas/installer/Kconfig
> > +++ b/kas/installer/Kconfig
> > @@ -92,7 +92,7 @@ config
> > KAS_INCLUDE_INSTALLER_ADD_DEVICE_INFO_COLLECTOR
> >     default "kas/installer/add-device-info-collector.yaml"
> >      depends on INSTALLER_ADD_DEVICE_INFO_COLLECTOR
> >
> > -config INSTALLER_TTY_SERVICES
> > +config TARGET_BOOTSTRAPPER_TTY_SERVICES
> >     string "TTY Service to use"
> >     default "getty@tty1 serial-getty@ttyS0" if
> > !INSTALL_UNATTENDED
> >     default "serial-getty@ttyS0" if INSTALL_UNATTENDED
> > --
> > 2.47.3
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "isar-users" group.
> > To unsubscribe from this group and stop receiving emails from it,
> > send an email to isar-users+unsubscribe@googlegroups.com.
> > To view this discussion visit
> > https://groups.google.com/d/msgid/isar-users/20251213140654.1142110-1-badrikesh.prusty%40siemens.com
> > .

--
Alexander Heinisch
Siemens AG
http://www.siemens.com/

-- 
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c6ed6ed4911ed82afabedfbc92b0f8053e496410.camel%40siemens.com.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-12-15 10:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-13 14:06 [PATCH] kas: correct TTY services variable for target-bootstrapper 'Badrikesh Prusty' via isar-users
2025-12-15  7:23 ` 'MOESSBAUER, Felix' via isar-users
2025-12-15 10:28   ` 'Heinisch, Alexander' via isar-users

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox