From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6450128683656019968 X-Received: by 10.99.37.193 with SMTP id l184mr3233448pgl.129.1502218748830; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.36.103.205 with SMTP id u196ls4136864itc.22.gmail; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) X-Received: by 10.98.192.10 with SMTP id x10mr3194716pff.4.1502218748732; Tue, 08 Aug 2017 11:59:08 -0700 (PDT) Received: by 10.202.60.137 with SMTP id j131msoia; Tue, 8 Aug 2017 08:06:32 -0700 (PDT) X-Received: by 10.31.141.72 with SMTP id p69mr2003552vkd.3.1502204792169; Tue, 08 Aug 2017 08:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1502204792; cv=none; d=google.com; s=arc-20160816; b=QC8p67GOSjON+IaB2zkDzQZkxe9W8bOcqzWj4GxTLbgsBCIonqUv1GXkmyeEjV/pwV SCHebvDs1maSjho72JTh+Xzgcn906+0147+mjl0ltOQ3uYYfVgM4HZoOnFq8VsFTyq1q A1cvhlRzAMwDMOUriNy4sxoztxMms6ncdA67dj7Jc2AbzH/FLISZ6N2DbengB5Ui1ym5 kmQJd7vrD33CSHcbDCiCepZDtQGz9UhJde6nuzp6DMOr32XTU2380DlT8blQbHHkiNqk hlmtp4GVQa7WOzsaXsBZwNTvZiYGVIEoKrd+crlYu8f4VEEDsZ7dtGSnOjD37Azy3wF6 DF/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=o1aj2r+Pp+FX8/MbezI+O2eBEkqPC70183pJPRYRf14=; b=aaR5+QekA32iJLe3Vp0P5wGcI2FV4If1IVHN/3I/09nORhA0TxTU7jZ6qujh4SrVcV qD7fIj0baPuXzps60Y3Y7ks/QpWvlI6nV4mIKzSUNGG6lLrtlptZbSl4T5Brcb8T0erZ vsk/dz4IWaMxv+qaNvAVw789SP6Dx7Uh/m45az51TZxUP1Vnh86RNAG/zlF5Qe10LvSZ l2Cs6fukAROJX6A84IK8c1meify4fbxw8q5Qbs/c7bE6lxf+YCfPbYR4IoIZQlmg6tt/ 1HeoqnJCI8Fq93aeN2aE/iSa3bAeObhsOQOOUsYgIF5MAqiQMf/nFb0zr508CpCeeL2A tShg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id u66si566968itd.1.2017.08.08.08.06.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 08:06:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of asmirnov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=asmirnov@ilbers.de Received: from [10.0.2.15] ([188.227.110.165]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id v78F6RVK023897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 8 Aug 2017 17:06:29 +0200 Subject: Re: [PATCH 11-16 of 16 v2 1/6] meta: dpkg rename install to package_write_deb To: isar-users@googlegroups.com References: <20170808164930.22ef5a22@md1em3qc> From: Alexander Smirnov Message-ID: Date: Tue, 8 Aug 2017 18:06:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170808164930.22ef5a22@md1em3qc> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: QEdJbLsUjJQX On 08/08/2017 05:49 PM, Henning Schild wrote: > Am Tue, 8 Aug 2017 16:06:11 +0300 > schrieb Alexander Smirnov : > >> 2017-08-03 22:15 GMT+03:00 Henning Schild >> : >> >>> This way we stay with OE names. The name "install" will be used to >>> populate ${D} in a later patch, also in line with OE. >>> >>> Signed-off-by: Henning Schild >>> --- >>> meta/classes/dpkg.bbclass | 9 ++++----- >>> meta/classes/image.bbclass | 2 +- >>> 2 files changed, 5 insertions(+), 6 deletions(-) >>> >>> diff --git a/meta/classes/dpkg.bbclass b/meta/classes/dpkg.bbclass >>> index ca0c5ab..97238b5 100644 >>> --- a/meta/classes/dpkg.bbclass >>> +++ b/meta/classes/dpkg.bbclass >>> @@ -23,12 +23,11 @@ do_build() { >>> sudo chroot ${BUILDCHROOT_DIR} /build.sh ${PP}/${SRC_DIR} >>> } >>> >>> - >>> # Install package to dedicated deploy directory >>> -do_install() { >>> +do_package_write_deb() { >>> >> >> Why it's 'package_write_deb'? If we speak about 'like-OE' style, in >> OE this function does (NOTE: I provide links to GitHub because they >> have line numbering): >> >> 1. package_write_deb: >> https://github.com/MentorEmbedded/poky/blob/master/meta/classes/package_deb.bbclass#L342 >> >> 2. It calls package_deb: >> https://github.com/MentorEmbedded/poky/blob/master/meta/classes/package_deb.bbclass#L51 >> >> So this function performs creating of deb package from built binaries. >> >> >> In general it's quite difficult to map Isar package building process >> to OE (some tasks like 'patch' are missed due to no meaning in this >> context): >> >> 1. Isar: fetch -> unpack -> (!) build (using dpkg) >> >> 2. OE: fetch -> unpack -> (!) configure -> compile -> install -> >> package_write_deb >> >> So all the tasks after (!) in OE are done in single task in Isar. >> That's one of the Isar main difference from OE, that package building >> is performed by native Debian tools and this process can't be >> break-down and one-to-one mapped to OE tasks. >> >> Regarding the function in patch, this is defenitely install and not >> package write, but we can specify what kind of install, for example: >> install_to_deploy, or populate_apt or etc... > > http://www.yoctoproject.org/docs/1.8/ref-manual/ref-manual.html#ref-tasks-package_write_deb > > Yes they also build the package in that step. But after that step > a .deb is in DEPLOY_DEB_DIR. In your link, this task *creates* Debian package and stores it to deploy directory, what is *not* true for Isar. I'd suggest to name tasks identically to OE *only* when they have identical meaning, otherwise there is no reason to do so. Isar is not OE, so not every task in Isar could be directly mapped to relevant OE one. Alex >> >> >>> install -m 755 ${BUILDROOT}/*.deb ${DEPLOY_DIR_DEB}/ >>> } >>> >>> -addtask install after do_build >>> -do_install[dirs] = "${DEPLOY_DIR_DEB}" >>> -do_install[stamp-extra-info] = "${MACHINE}" >>> +addtask package_write_deb after do_build >>> +do_package_write_deb[dirs] = "${DEPLOY_DIR_DEB}" >>> +do_package_write_deb[stamp-extra-info] = "${MACHINE}" >>> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass >>> index 3e4877c..f60ec11 100644 >>> --- a/meta/classes/image.bbclass >>> +++ b/meta/classes/image.bbclass >>> @@ -27,4 +27,4 @@ do_populate() { >>> } >>> >>> addtask populate before do_build >>> -do_populate[deptask] = "do_install" >>> +do_populate[deptask] = "do_package_write_deb" >>> -- >>> 2.13.0 >>> >>>