* [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
@ 2025-09-05 11:27 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:25 ` 'Jan Kiszka' via isar-users
2025-09-05 11:27 ` [RFC PATCH 2/5] add dracut to custom kernel builds 'Quirin Gylstorff' via isar-users
` (3 subsequent siblings)
4 siblings, 1 reply; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 11:27 UTC (permalink / raw)
To: isar-users, jan.kiszka, felix.moessbauer, cedric.hombourger
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
The packages doesn't use any artifacts provided by initramfs-tools.
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
meta/recipes-support/enable-fsck/enable-fsck_0.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
index 2d0ec950..8a11990f 100644
--- a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
+++ b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
@@ -9,7 +9,7 @@ inherit dpkg-raw
DESCRIPTION = "This service enables fsck on first boot"
-DEBIAN_DEPENDS = "systemd, sed, mount, initramfs-tools"
+DEBIAN_DEPENDS = "systemd, sed, mount"
SRC_URI = " \
file://enable-fsck.service \
--
2.50.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250905113014.2765493-2-Quirin.Gylstorff%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools
2025-09-05 11:27 ` [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools 'Quirin Gylstorff' via isar-users
@ 2025-09-05 12:25 ` 'Jan Kiszka' via isar-users
2025-09-05 12:38 ` 'Jan Kiszka' via isar-users
0 siblings, 1 reply; 16+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-09-05 12:25 UTC (permalink / raw)
To: Quirin Gylstorff, isar-users, felix.moessbauer, cedric.hombourger
On 05.09.25 13:27, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> The packages doesn't use any artifacts provided by initramfs-tools.
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/recipes-support/enable-fsck/enable-fsck_0.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
> index 2d0ec950..8a11990f 100644
> --- a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
> +++ b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
Recipe revision bump?
> @@ -9,7 +9,7 @@ inherit dpkg-raw
>
> DESCRIPTION = "This service enables fsck on first boot"
>
> -DEBIAN_DEPENDS = "systemd, sed, mount, initramfs-tools"
> +DEBIAN_DEPENDS = "systemd, sed, mount"
I have no idea anymore why I once added that dependency... Makes no
sense, indeed.
>
> SRC_URI = " \
> file://enable-fsck.service \
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/0915bd44-1174-4080-92c7-758e287d0732%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools
2025-09-05 12:25 ` 'Jan Kiszka' via isar-users
@ 2025-09-05 12:38 ` 'Jan Kiszka' via isar-users
0 siblings, 0 replies; 16+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-09-05 12:38 UTC (permalink / raw)
To: Quirin Gylstorff, isar-users, felix.moessbauer,
cedric.hombourger, Uladzimir Bely
On 05.09.25 14:25, 'Jan Kiszka' via isar-users wrote:
> On 05.09.25 13:27, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> The packages doesn't use any artifacts provided by initramfs-tools.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>> meta/recipes-support/enable-fsck/enable-fsck_0.2.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
>> index 2d0ec950..8a11990f 100644
>> --- a/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
>> +++ b/meta/recipes-support/enable-fsck/enable-fsck_0.2.bb
>
> Recipe revision bump?
>
>> @@ -9,7 +9,7 @@ inherit dpkg-raw
>>
>> DESCRIPTION = "This service enables fsck on first boot"
>>
>> -DEBIAN_DEPENDS = "systemd, sed, mount, initramfs-tools"
>> +DEBIAN_DEPENDS = "systemd, sed, mount"
>
> I have no idea anymore why I once added that dependency... Makes no
> sense, indeed.
>
Now I have: 2377b73d8f060bb03bed970853fc47a7197b7789 broke enable-fsck.
The current form does indeed no longer need the tools - but also has no
meaning anymore.
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e38a6f7d-f7eb-4db8-ba43-dd9c9151d4b1%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [RFC PATCH 2/5] add dracut to custom kernel builds
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools 'Quirin Gylstorff' via isar-users
@ 2025-09-05 11:27 ` 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds 'Quirin Gylstorff' via isar-users
` (2 subsequent siblings)
4 siblings, 0 replies; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 11:27 UTC (permalink / raw)
To: isar-users, jan.kiszka, felix.moessbauer, cedric.hombourger
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
meta/recipes-kernel/linux/linux-custom.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-kernel/linux/linux-custom.inc b/meta/recipes-kernel/linux/linux-custom.inc
index 01e9bff7..3415db35 100644
--- a/meta/recipes-kernel/linux/linux-custom.inc
+++ b/meta/recipes-kernel/linux/linux-custom.inc
@@ -31,7 +31,7 @@ KBUILD_DEPENDS ?= "build-essential:native, \
linux-image-${KERNEL_NAME_PROVIDED}:${DISTRO_ARCH} <kbuild !kernel>, \
rsync,"
-KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool, \
+KERNEL_DEBIAN_DEPENDS ?= "initramfs-tools | linux-initramfs-tool | dracut, \
kmod, \
linux-base (>= 4.3~),"
--
2.50.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250905113014.2765493-3-Quirin.Gylstorff%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 1/5] enable-fsck: remove dependency to initramfs-tools 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 2/5] add dracut to custom kernel builds 'Quirin Gylstorff' via isar-users
@ 2025-09-05 11:27 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:29 ` 'Jan Kiszka' via isar-users
2025-09-05 11:27 ` [RFC PATCH 4/5] rootfs Add dracut to initramfs generator 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 5/5] initramfs: allow to set the generator command 'Quirin Gylstorff' via isar-users
4 siblings, 1 reply; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 11:27 UTC (permalink / raw)
To: isar-users, jan.kiszka, felix.moessbauer, cedric.hombourger
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
This is in preparation to support additional initramfs generators
like dracut.
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
meta/classes/rootfs.bbclass | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index 7b7859b9..d3fb44c9 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -5,7 +5,16 @@ inherit deb-dl-dir
ROOTFS_ARCH ?= "${DISTRO_ARCH}"
ROOTFS_DISTRO ?= "${DISTRO}"
+
+def initramfs_generator_cmd(d):
+ return 'update-initramfs'
+
+def initramfs_generator_cmdline(d):
+ return "update-initramfs -u -v -k \"$kernel_version\""
+
ROOTFS_PACKAGES ?= ""
+ROOTFS_INITRAMFS_GENERATOR_CMD ?= "${@ initramfs_generator_cmd(d)}"
+ROOTFS_INITRAMFS_GENERATOR_CMDLINE ?= "${@ initramfs_generator_cmdline(d)}"
ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}"
# Features of the rootfs creation:
@@ -183,7 +192,7 @@ rootfs_disable_initrd_generation[weight] = "1"
rootfs_disable_initrd_generation() {
# fully disable initrd generation
sudo mkdir -p "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
- sudo cp -a ${ROOTFSDIR}/usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/update-initramfs
+ sudo cp -a ${ROOTFSDIR}/usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/${ROOTFS_INITRAMFS_GENERATOR_CMD}
}
ROOTFS_INSTALL_COMMAND += "rootfs_install_pkgs_update"
@@ -485,11 +494,12 @@ rootfs_generate_initramfs() {
export kernel_version=$(basename /boot/vmlinu[xz]-* | cut -d'-' -f2-); \
echo "Total number of modules: $mods_total"; \
echo "Generating initrd for kernel version: $kernel_version"; \
- update-initramfs -u -v -k "$kernel_version";'
+ ${ROOTFS_INITRAMFS_GENERATOR_CMDLINE};'
if [ -n "${INITRD_DEPLOY_FILE}" ]; then
if [ -f "${ROOTFSDIR}/initrd.img" ]; then
# debian (mkinitramfs)
- cp ${ROOTFSDIR}/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
+ sudo cp ${ROOTFSDIR}/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
+ sudo chown $(id -u):$(id -g) ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
else
# ubuntu (dracut)
cp ${ROOTFSDIR}/boot/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
--
2.50.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250905113014.2765493-4-Quirin.Gylstorff%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds
2025-09-05 11:27 ` [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds 'Quirin Gylstorff' via isar-users
@ 2025-09-05 12:29 ` 'Jan Kiszka' via isar-users
0 siblings, 0 replies; 16+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-09-05 12:29 UTC (permalink / raw)
To: Quirin Gylstorff, isar-users, felix.moessbauer, cedric.hombourger
On 05.09.25 13:27, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> This is in preparation to support additional initramfs generators
> like dracut.
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/classes/rootfs.bbclass | 16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index 7b7859b9..d3fb44c9 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -5,7 +5,16 @@ inherit deb-dl-dir
>
> ROOTFS_ARCH ?= "${DISTRO_ARCH}"
> ROOTFS_DISTRO ?= "${DISTRO}"
> +
> +def initramfs_generator_cmd(d):
> + return 'update-initramfs'
> +
> +def initramfs_generator_cmdline(d):
> + return "update-initramfs -u -v -k \"$kernel_version\""
Why functions, why not strings?
> +
> ROOTFS_PACKAGES ?= ""
> +ROOTFS_INITRAMFS_GENERATOR_CMD ?= "${@ initramfs_generator_cmd(d)}"
How about deriving the initramfs_generator_cmd string from
initramfs_generator_cmdline? It should be the first word of the latter.
> +ROOTFS_INITRAMFS_GENERATOR_CMDLINE ?= "${@ initramfs_generator_cmdline(d)}"
> ROOTFS_BASE_DISTRO ?= "${BASE_DISTRO}"
>
> # Features of the rootfs creation:
> @@ -183,7 +192,7 @@ rootfs_disable_initrd_generation[weight] = "1"
> rootfs_disable_initrd_generation() {
> # fully disable initrd generation
> sudo mkdir -p "${ROOTFSDIR}${ROOTFS_STUBS_DIR}"
> - sudo cp -a ${ROOTFSDIR}/usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/update-initramfs
> + sudo cp -a ${ROOTFSDIR}/usr/bin/true ${ROOTFSDIR}${ROOTFS_STUBS_DIR}/${ROOTFS_INITRAMFS_GENERATOR_CMD}
> }
>
> ROOTFS_INSTALL_COMMAND += "rootfs_install_pkgs_update"
> @@ -485,11 +494,12 @@ rootfs_generate_initramfs() {
> export kernel_version=$(basename /boot/vmlinu[xz]-* | cut -d'-' -f2-); \
> echo "Total number of modules: $mods_total"; \
> echo "Generating initrd for kernel version: $kernel_version"; \
> - update-initramfs -u -v -k "$kernel_version";'
> + ${ROOTFS_INITRAMFS_GENERATOR_CMDLINE};'
> if [ -n "${INITRD_DEPLOY_FILE}" ]; then
> if [ -f "${ROOTFSDIR}/initrd.img" ]; then
> # debian (mkinitramfs)
> - cp ${ROOTFSDIR}/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
> + sudo cp ${ROOTFSDIR}/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
> + sudo chown $(id -u):$(id -g) ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
This huck is also new - reason?
> else
> # ubuntu (dracut)
> cp ${ROOTFSDIR}/boot/initrd.img ${DEPLOYDIR}/${INITRD_DEPLOY_FILE}
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/69b4beaf-9755-451a-b3d3-8ab99af8b463%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [RFC PATCH 4/5] rootfs Add dracut to initramfs generator
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
` (2 preceding siblings ...)
2025-09-05 11:27 ` [RFC PATCH 3/5] rootfs: Allow to overwrite the initramfs generation cmds 'Quirin Gylstorff' via isar-users
@ 2025-09-05 11:27 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:30 ` 'Jan Kiszka' via isar-users
2025-09-05 12:44 ` 'Quirin Gylstorff' via isar-users
2025-09-05 11:27 ` [RFC PATCH 5/5] initramfs: allow to set the generator command 'Quirin Gylstorff' via isar-users
4 siblings, 2 replies; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 11:27 UTC (permalink / raw)
To: isar-users, jan.kiszka, felix.moessbauer, cedric.hombourger
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
meta/classes/rootfs.bbclass | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
index d3fb44c9..9e02dbd1 100644
--- a/meta/classes/rootfs.bbclass
+++ b/meta/classes/rootfs.bbclass
@@ -7,9 +7,15 @@ ROOTFS_ARCH ?= "${DISTRO_ARCH}"
ROOTFS_DISTRO ?= "${DISTRO}"
def initramfs_generator_cmd(d):
+ rootfs_packages = d.getVar('ROOTFS_PACKAGES') or ''
+ if 'dracut' in rootfs_packages:
+ return 'rootfs'
return 'update-initramfs'
def initramfs_generator_cmdline(d):
+ initramfs_generator_cmd = d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMD')
+ if 'dracut' in initramfs_generator_cmd:
+ return "dracut --force /initrd.img \"$kernel_version\""
return "update-initramfs -u -v -k \"$kernel_version\""
ROOTFS_PACKAGES ?= ""
--
2.50.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250905113014.2765493-5-Quirin.Gylstorff%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 4/5] rootfs Add dracut to initramfs generator
2025-09-05 11:27 ` [RFC PATCH 4/5] rootfs Add dracut to initramfs generator 'Quirin Gylstorff' via isar-users
@ 2025-09-05 12:30 ` 'Jan Kiszka' via isar-users
2025-09-05 12:42 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:44 ` 'Quirin Gylstorff' via isar-users
1 sibling, 1 reply; 16+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-09-05 12:30 UTC (permalink / raw)
To: Quirin Gylstorff, isar-users, felix.moessbauer, cedric.hombourger
On 05.09.25 13:27, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/classes/rootfs.bbclass | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index d3fb44c9..9e02dbd1 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -7,9 +7,15 @@ ROOTFS_ARCH ?= "${DISTRO_ARCH}"
> ROOTFS_DISTRO ?= "${DISTRO}"
>
> def initramfs_generator_cmd(d):
> + rootfs_packages = d.getVar('ROOTFS_PACKAGES') or ''
> + if 'dracut' in rootfs_packages:
> + return 'rootfs'
> return 'update-initramfs'
>
> def initramfs_generator_cmdline(d):
> + initramfs_generator_cmd = d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMD')
> + if 'dracut' in initramfs_generator_cmd:
> + return "dracut --force /initrd.img \"$kernel_version\""
> return "update-initramfs -u -v -k \"$kernel_version\""
>
> ROOTFS_PACKAGES ?= ""
OK, now I see why you defined functions. But initramfs_generator_cmd can
still be simplified by taking the first word of initramfs_generator_cmdline.
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/939b27f7-aca1-4703-bbfb-5cd9dc264d7f%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 4/5] rootfs Add dracut to initramfs generator
2025-09-05 12:30 ` 'Jan Kiszka' via isar-users
@ 2025-09-05 12:42 ` 'Quirin Gylstorff' via isar-users
0 siblings, 0 replies; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 12:42 UTC (permalink / raw)
To: Jan Kiszka, isar-users, felix.moessbauer, cedric.hombourger
On 9/5/25 14:30, Jan Kiszka wrote:
> On 05.09.25 13:27, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>> meta/classes/rootfs.bbclass | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
>> index d3fb44c9..9e02dbd1 100644
>> --- a/meta/classes/rootfs.bbclass
>> +++ b/meta/classes/rootfs.bbclass
>> @@ -7,9 +7,15 @@ ROOTFS_ARCH ?= "${DISTRO_ARCH}"
>> ROOTFS_DISTRO ?= "${DISTRO}"
>>
>> def initramfs_generator_cmd(d):
>> + rootfs_packages = d.getVar('ROOTFS_PACKAGES') or ''
>> + if 'dracut' in rootfs_packages:
>> + return 'rootfs'
>> return 'update-initramfs'
>>
>> def initramfs_generator_cmdline(d):
>> + initramfs_generator_cmd = d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMD')
>> + if 'dracut' in initramfs_generator_cmd:
>> + return "dracut --force /initrd.img \"$kernel_version\""
>> return "update-initramfs -u -v -k \"$kernel_version\""
>>
>> ROOTFS_PACKAGES ?= ""
>
> OK, now I see why you defined functions. But initramfs_generator_cmd can
> still be simplified by taking the first word of initramfs_generator_cmdline.
ok i will change it in a v2.
Quirin
>
> Jan
>
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c35ee255-803f-43de-835f-8f205bf3a65a%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 4/5] rootfs Add dracut to initramfs generator
2025-09-05 11:27 ` [RFC PATCH 4/5] rootfs Add dracut to initramfs generator 'Quirin Gylstorff' via isar-users
2025-09-05 12:30 ` 'Jan Kiszka' via isar-users
@ 2025-09-05 12:44 ` 'Quirin Gylstorff' via isar-users
1 sibling, 0 replies; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 12:44 UTC (permalink / raw)
To: isar-users
On 9/5/25 13:27, 'Quirin Gylstorff' via isar-users wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/classes/rootfs.bbclass | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/meta/classes/rootfs.bbclass b/meta/classes/rootfs.bbclass
> index d3fb44c9..9e02dbd1 100644
> --- a/meta/classes/rootfs.bbclass
> +++ b/meta/classes/rootfs.bbclass
> @@ -7,9 +7,15 @@ ROOTFS_ARCH ?= "${DISTRO_ARCH}"
> ROOTFS_DISTRO ?= "${DISTRO}"
>
> def initramfs_generator_cmd(d):
> + rootfs_packages = d.getVar('ROOTFS_PACKAGES') or ''
> + if 'dracut' in rootfs_packages:
> + return 'rootfs'
This should be `dracut`. I will fix it in v2.
Quirin
> return 'update-initramfs'
>
> def initramfs_generator_cmdline(d):
> + initramfs_generator_cmd = d.getVar('ROOTFS_INITRAMFS_GENERATOR_CMD')
> + if 'dracut' in initramfs_generator_cmd:
> + return "dracut --force /initrd.img \"$kernel_version\""
> return "update-initramfs -u -v -k \"$kernel_version\""
>
> ROOTFS_PACKAGES ?= ""
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/157d8ab2-1fc3-48c4-8ad1-10243cea693e%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [RFC PATCH 5/5] initramfs: allow to set the generator command
2025-09-05 11:27 [RFC PATCH 0/5] Add support for dracut 'Quirin Gylstorff' via isar-users
` (3 preceding siblings ...)
2025-09-05 11:27 ` [RFC PATCH 4/5] rootfs Add dracut to initramfs generator 'Quirin Gylstorff' via isar-users
@ 2025-09-05 11:27 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:32 ` 'Jan Kiszka' via isar-users
4 siblings, 1 reply; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 11:27 UTC (permalink / raw)
To: isar-users, jan.kiszka, felix.moessbauer, cedric.hombourger
From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
This allows to exchange the initramfs generator.
Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
---
meta/classes/initramfs.bbclass | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
index 658ef0ac..f9c919de 100644
--- a/meta/classes/initramfs.bbclass
+++ b/meta/classes/initramfs.bbclass
@@ -10,6 +10,7 @@ INITRAMFS_INSTALL ?= ""
INITRAMFS_PREINSTALL ?= ""
INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
+INITRAMFS_GENERATOR_PKG ??= "initramfs-tools"
INITRD_DEPLOY_FILE = "${INITRAMFS_IMAGE_NAME}"
# Install proper kernel
@@ -26,6 +27,6 @@ DEPENDS += "${INITRAMFS_INSTALL}"
ROOTFSDIR = "${INITRAMFS_ROOTFS}"
ROOTFS_FEATURES = "generate-manifest"
-ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
+ROOTFS_PACKAGES = "${INITRAMFS_GENERATOR_PKG} ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
inherit rootfs
--
2.50.1
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/20250905113014.2765493-6-Quirin.Gylstorff%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 5/5] initramfs: allow to set the generator command
2025-09-05 11:27 ` [RFC PATCH 5/5] initramfs: allow to set the generator command 'Quirin Gylstorff' via isar-users
@ 2025-09-05 12:32 ` 'Jan Kiszka' via isar-users
2025-09-05 12:41 ` 'Quirin Gylstorff' via isar-users
0 siblings, 1 reply; 16+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-09-05 12:32 UTC (permalink / raw)
To: Quirin Gylstorff, isar-users, felix.moessbauer, cedric.hombourger
On 05.09.25 13:27, Quirin Gylstorff wrote:
> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>
> This allows to exchange the initramfs generator.
>
> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
> ---
> meta/classes/initramfs.bbclass | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
> index 658ef0ac..f9c919de 100644
> --- a/meta/classes/initramfs.bbclass
> +++ b/meta/classes/initramfs.bbclass
> @@ -10,6 +10,7 @@ INITRAMFS_INSTALL ?= ""
> INITRAMFS_PREINSTALL ?= ""
> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
> +INITRAMFS_GENERATOR_PKG ??= "initramfs-tools"
> INITRD_DEPLOY_FILE = "${INITRAMFS_IMAGE_NAME}"
>
> # Install proper kernel
> @@ -26,6 +27,6 @@ DEPENDS += "${INITRAMFS_INSTALL}"
>
> ROOTFSDIR = "${INITRAMFS_ROOTFS}"
> ROOTFS_FEATURES = "generate-manifest"
> -ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
> +ROOTFS_PACKAGES = "${INITRAMFS_GENERATOR_PKG} ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>
> inherit rootfs
Do we need extra safety belts for the case that users create custom
initramfs hooks and set the wrong INITRAMFS_GENERATOR_PKG?
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/c768a129-46d1-407e-86b8-e0a43632b390%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 5/5] initramfs: allow to set the generator command
2025-09-05 12:32 ` 'Jan Kiszka' via isar-users
@ 2025-09-05 12:41 ` 'Quirin Gylstorff' via isar-users
2025-09-05 12:52 ` 'Jan Kiszka' via isar-users
0 siblings, 1 reply; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 12:41 UTC (permalink / raw)
To: Jan Kiszka, isar-users, felix.moessbauer, cedric.hombourger
On 9/5/25 14:32, Jan Kiszka wrote:
> On 05.09.25 13:27, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> This allows to exchange the initramfs generator.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>> meta/classes/initramfs.bbclass | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/initramfs.bbclass
>> index 658ef0ac..f9c919de 100644
>> --- a/meta/classes/initramfs.bbclass
>> +++ b/meta/classes/initramfs.bbclass
>> @@ -10,6 +10,7 @@ INITRAMFS_INSTALL ?= ""
>> INITRAMFS_PREINSTALL ?= ""
>> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
>> +INITRAMFS_GENERATOR_PKG ??= "initramfs-tools"
>> INITRD_DEPLOY_FILE = "${INITRAMFS_IMAGE_NAME}"
>>
>> # Install proper kernel
>> @@ -26,6 +27,6 @@ DEPENDS += "${INITRAMFS_INSTALL}"
>>
>> ROOTFSDIR = "${INITRAMFS_ROOTFS}"
>> ROOTFS_FEATURES = "generate-manifest"
>> -ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>> +ROOTFS_PACKAGES = "${INITRAMFS_GENERATOR_PKG} ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>>
>> inherit rootfs
>
> Do we need extra safety belts for the case that users create custom
> initramfs hooks and set the wrong INITRAMFS_GENERATOR_PKG?
I am not sure if this will survive the next iteration. Reusing the
initramfs class for dracut initrd leads to major pains if using in
layers where the INITRAMFS_(PRE)INSTALL is set by *.conf.
My current plan is to split it up and create a base class.
Quirn
>
> Jan
>
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/f0106581-8925-422d-8488-a18523081b24%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 5/5] initramfs: allow to set the generator command
2025-09-05 12:41 ` 'Quirin Gylstorff' via isar-users
@ 2025-09-05 12:52 ` 'Jan Kiszka' via isar-users
2025-09-05 13:03 ` 'Quirin Gylstorff' via isar-users
0 siblings, 1 reply; 16+ messages in thread
From: 'Jan Kiszka' via isar-users @ 2025-09-05 12:52 UTC (permalink / raw)
To: Quirin Gylstorff, isar-users, felix.moessbauer, cedric.hombourger
On 05.09.25 14:41, Quirin Gylstorff wrote:
>
>
> On 9/5/25 14:32, Jan Kiszka wrote:
>> On 05.09.25 13:27, Quirin Gylstorff wrote:
>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>
>>> This allows to exchange the initramfs generator.
>>>
>>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>> ---
>>> meta/classes/initramfs.bbclass | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/
>>> initramfs.bbclass
>>> index 658ef0ac..f9c919de 100644
>>> --- a/meta/classes/initramfs.bbclass
>>> +++ b/meta/classes/initramfs.bbclass
>>> @@ -10,6 +10,7 @@ INITRAMFS_INSTALL ?= ""
>>> INITRAMFS_PREINSTALL ?= ""
>>> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>>> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
>>> +INITRAMFS_GENERATOR_PKG ??= "initramfs-tools"
>>> INITRD_DEPLOY_FILE = "${INITRAMFS_IMAGE_NAME}"
>>> # Install proper kernel
>>> @@ -26,6 +27,6 @@ DEPENDS += "${INITRAMFS_INSTALL}"
>>> ROOTFSDIR = "${INITRAMFS_ROOTFS}"
>>> ROOTFS_FEATURES = "generate-manifest"
>>> -ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL}
>>> ${INITRAMFS_INSTALL}"
>>> +ROOTFS_PACKAGES = "${INITRAMFS_GENERATOR_PKG}
>>> ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>>> inherit rootfs
>>
>> Do we need extra safety belts for the case that users create custom
>> initramfs hooks and set the wrong INITRAMFS_GENERATOR_PKG?
>
> I am not sure if this will survive the next iteration. Reusing the
> initramfs class for dracut initrd leads to major pains if using in
> layers where the INITRAMFS_(PRE)INSTALL is set by *.conf.
No, it's really about flagging / preventing unsupported combos. We will
continue to support initramfs-hooks for a longer while, backward
compatibility. But now user should not try to generate custom initramfs
with those hooks while having switched to a different generator.
>
> My current plan is to split it up and create a base class.
We will probably need completely different helpers to create custom
dracut modules, no?
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/e9c7ad61-0fed-4d9b-b63a-084186c3ccfd%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [RFC PATCH 5/5] initramfs: allow to set the generator command
2025-09-05 12:52 ` 'Jan Kiszka' via isar-users
@ 2025-09-05 13:03 ` 'Quirin Gylstorff' via isar-users
0 siblings, 0 replies; 16+ messages in thread
From: 'Quirin Gylstorff' via isar-users @ 2025-09-05 13:03 UTC (permalink / raw)
To: Jan Kiszka, isar-users, felix.moessbauer, cedric.hombourger
On 9/5/25 14:52, Jan Kiszka wrote:
> On 05.09.25 14:41, Quirin Gylstorff wrote:
>>
>>
>> On 9/5/25 14:32, Jan Kiszka wrote:
>>> On 05.09.25 13:27, Quirin Gylstorff wrote:
>>>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>>
>>>> This allows to exchange the initramfs generator.
>>>>
>>>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>>> ---
>>>> meta/classes/initramfs.bbclass | 3 ++-
>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/classes/initramfs.bbclass b/meta/classes/
>>>> initramfs.bbclass
>>>> index 658ef0ac..f9c919de 100644
>>>> --- a/meta/classes/initramfs.bbclass
>>>> +++ b/meta/classes/initramfs.bbclass
>>>> @@ -10,6 +10,7 @@ INITRAMFS_INSTALL ?= ""
>>>> INITRAMFS_PREINSTALL ?= ""
>>>> INITRAMFS_ROOTFS ?= "${WORKDIR}/rootfs"
>>>> INITRAMFS_IMAGE_NAME = "${INITRAMFS_FULLNAME}.initrd.img"
>>>> +INITRAMFS_GENERATOR_PKG ??= "initramfs-tools"
>>>> INITRD_DEPLOY_FILE = "${INITRAMFS_IMAGE_NAME}"
>>>> # Install proper kernel
>>>> @@ -26,6 +27,6 @@ DEPENDS += "${INITRAMFS_INSTALL}"
>>>> ROOTFSDIR = "${INITRAMFS_ROOTFS}"
>>>> ROOTFS_FEATURES = "generate-manifest"
>>>> -ROOTFS_PACKAGES = "initramfs-tools ${INITRAMFS_PREINSTALL}
>>>> ${INITRAMFS_INSTALL}"
>>>> +ROOTFS_PACKAGES = "${INITRAMFS_GENERATOR_PKG}
>>>> ${INITRAMFS_PREINSTALL} ${INITRAMFS_INSTALL}"
>>>> inherit rootfs
>>>
>>> Do we need extra safety belts for the case that users create custom
>>> initramfs hooks and set the wrong INITRAMFS_GENERATOR_PKG?
>>
>> I am not sure if this will survive the next iteration. Reusing the
>> initramfs class for dracut initrd leads to major pains if using in
>> layers where the INITRAMFS_(PRE)INSTALL is set by *.conf.
>
> No, it's really about flagging / preventing unsupported combos. We will
> continue to support initramfs-hooks for a longer while, backward
> compatibility. But now user should not try to generate custom initramfs
> with those hooks while having switched to a different generator.
Currently it breaks on the package installation level if the dependency
are correct. As initramfs-tools are incompatible with dracut. We need to
check the dependencies of the package before installing it to avoid
this. For now i can check if there are recipes with a specific name in
ROOTFS_PACKAGE but there is always the possibility to that it will break
on installation.
>
>>
>> My current plan is to split it up and create a base class.
>
> We will probably need completely different helpers to create custom
> dracut modules, no?
Yes we need a new set of helpers. I will look into it after the basic
infrastructure is in place.
> > Jan
>
Quirin
--
You received this message because you are subscribed to the Google Groups "isar-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to isar-users+unsubscribe@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/isar-users/4184d1bf-d388-40c4-8d87-ef33629ae786%40siemens.com.
^ permalink raw reply [flat|nested] 16+ messages in thread