From: Jan Kiszka <jan.kiszka@siemens.com>
To: Anton Mikanovich <amikan@ilbers.de>, isar-users@googlegroups.com
Subject: Re: [PATCH v2 2/3] ubuntu: Fix building of non-arm64 targets
Date: Mon, 22 Mar 2021 17:49:33 +0100 [thread overview]
Message-ID: <c7a2bc8a-f618-7010-4dc2-b8b7a74b8e7d@siemens.com> (raw)
In-Reply-To: <20210322163140.159616-3-amikan@ilbers.de>
On 22.03.21 17:31, Anton Mikanovich wrote:
> Generic apt sources list for ubuntu targets was added but not actually
> used. This made qemuamd64-focal not buildable.
>
The commit message is misleading: patch 1 causes this. Before that,
DISTRO_APT_SOURCE came from debian-common.conf (which had other issues,
as we know). You likely want to reorder to avoid bisection breakage.
Jan
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta-isar/conf/distro/ubuntu-focal.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta-isar/conf/distro/ubuntu-focal.conf b/meta-isar/conf/distro/ubuntu-focal.conf
> index 0e4557e..ceb854d 100644
> --- a/meta-isar/conf/distro/ubuntu-focal.conf
> +++ b/meta-isar/conf/distro/ubuntu-focal.conf
> @@ -5,6 +5,7 @@
>
> require conf/distro/debian-common.conf
>
> +DISTRO_APT_SOURCES ?= "conf/distro/${DISTRO}.list"
> DISTRO_APT_SOURCES_arm64 ?= "conf/distro/${DISTRO}-ports.list"
> HOST_DISTRO_APT_SOURCES_append_arm64 = " ${DISTRO_APT_SOURCES}"
>
>
next prev parent reply other threads:[~2021-03-22 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 16:31 [PATCH v2 0/3] Fix DISTRO_APT_SOURCES declaration Anton Mikanovich
2021-03-22 16:31 ` [PATCH v2 1/3] Revert "meta/conf/distro: Cleanup DISTRO_APT_SOURCES" Anton Mikanovich
2021-03-22 16:31 ` [PATCH v2 2/3] ubuntu: Fix building of non-arm64 targets Anton Mikanovich
2021-03-22 16:49 ` Jan Kiszka [this message]
2021-03-23 11:56 ` Anton Mikanovich
2021-03-22 16:31 ` [PATCH v2 3/3] meta/conf/distro: Make debian inherit DISTRO_APT_SOURCES declaration Anton Mikanovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7a2bc8a-f618-7010-4dc2-b8b7a74b8e7d@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=amikan@ilbers.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox