From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6942517048885903360 X-Received: by 2002:a7b:cc85:: with SMTP id p5mr30467wma.148.1616432375107; Mon, 22 Mar 2021 09:59:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:cc94:: with SMTP id p20ls21673wma.0.gmail; Mon, 22 Mar 2021 09:59:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKzZJBZxeup4ZMCJV4+VfQB65IPWTY6tpHnT6RPSEOF82CYvW+iWaGTanZzMiPmUIT2Ki+ X-Received: by 2002:a05:600c:b57:: with SMTP id k23mr12wmr.145.1616432374154; Mon, 22 Mar 2021 09:59:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616432374; cv=none; d=google.com; s=arc-20160816; b=DgVybK1PeFonq93JSlDA3MXBcS1OuVAukLpvUqkSD4m9YA5jKn/kV84LnBD9kmR5L4 JCDMgjwKpt0tAZCUkjlKvHabvu/ZTeEZ9bGtDz82wLQ220ccZP1DGhIDJT01ivgpfIVP zdHfh1cTeBbQi5ekdYbpxTzM2xLcBHlVm3ClNQF670cmIfyNkQchvaVMyKvsKOfIq9ye 6bhpWP6YLVI3f50Uo+xabp0mZEC8GFtaRmQUMzpQYa3NmfXVIsgsctSQdOG14jPZnlD8 RkrltOjayToQRZXpikdQDe5Ub9Wh3OtFrkh0ol3vpNdg/G/DHXClDW+QcGVrNvmjcrL2 i1Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject; bh=G/X39WgplqSgCnPq7GXB7qvK+h2YPdrnMPcCxxoQGcI=; b=LsubU6RrzmleFL9VZ9OlwPG7+DmFA7NajQn3gC4zdjEiEVleWgipq/BywyiFz0GehV yyxxoJNMfWacwyxKNOyTPGzXGm/9u0B0IvKCbxQoxxmN43enXsD8VL9uzoULdlC0cnT5 67WjNAFPVX3vCypqVhD9ONVglVc89cAWVMGzJJewD69UhIADkdWoiE0lupFBU+FkM+ln dOuYbgGCIhAsK/dWJMMo73CI/cinAx2CzPsIh9tea6UJLfI6z2lEr9v3eVVU9gxX8hNt xd7y+MW+GT6ij2xAkQ7FRhL4f7W+SoDI51DeWQabo2mG3gVi7ENo9JJRRi17kxtgZX4w Q/Hw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id p189si2086wmp.1.2021.03.22.09.59.34 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Mar 2021 09:59:34 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id 12MGxXKc017568 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 17:59:33 +0100 Received: from [167.87.37.70] ([167.87.37.70]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id 12MGnXuE011941; Mon, 22 Mar 2021 17:49:33 +0100 Subject: Re: [PATCH v2 2/3] ubuntu: Fix building of non-arm64 targets To: Anton Mikanovich , isar-users@googlegroups.com References: <20210322163140.159616-1-amikan@ilbers.de> <20210322163140.159616-3-amikan@ilbers.de> From: Jan Kiszka Message-ID: Date: Mon, 22 Mar 2021 17:49:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322163140.159616-3-amikan@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: 3p4+ivV3Has5 On 22.03.21 17:31, Anton Mikanovich wrote: > Generic apt sources list for ubuntu targets was added but not actually > used. This made qemuamd64-focal not buildable. > The commit message is misleading: patch 1 causes this. Before that, DISTRO_APT_SOURCE came from debian-common.conf (which had other issues, as we know). You likely want to reorder to avoid bisection breakage. Jan > Signed-off-by: Anton Mikanovich > --- > meta-isar/conf/distro/ubuntu-focal.conf | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-isar/conf/distro/ubuntu-focal.conf b/meta-isar/conf/distro/ubuntu-focal.conf > index 0e4557e..ceb854d 100644 > --- a/meta-isar/conf/distro/ubuntu-focal.conf > +++ b/meta-isar/conf/distro/ubuntu-focal.conf > @@ -5,6 +5,7 @@ > > require conf/distro/debian-common.conf > > +DISTRO_APT_SOURCES ?= "conf/distro/${DISTRO}.list" > DISTRO_APT_SOURCES_arm64 ?= "conf/distro/${DISTRO}-ports.list" > HOST_DISTRO_APT_SOURCES_append_arm64 = " ${DISTRO_APT_SOURCES}" > >