Re: [PATCH 5/6] meta/dpkg: add dpkg-custom class

[Claudius Heine <claudius.heine.ext@siemens.com>]

Hi again,

On 09/11/2017 10:13 AM, Claudius Heine wrote:
>> If I got this correctly, the difference from dpkg-debian flow is that 
>> you generate 'debian' folder on the fly. So:
>>
>> 1. Why we need another do_deb_package, while do_build from dpkg class 
>> does the same?
> 
> Why not? 'do_build' is a very bad name, because it not really describes 
> anything specific and if you have multiple tasks with good names like 
> 'deb_package' (while I still would prefer 'package_deb') that do just 
> one job each, then its much easier to recognize the tasks when calling 
> 'bitbake -c liststasks ..' and its simpler to extend the pipeline in 
> each recipe as needed.

>> 2. Can we just add optional task to generic pipeline which generates 
>> debian folder? Or make it as a part of do_build: if [ ! -d ${D}/debian 
>> ]; then blablabla.
> 
> No, please not part of the 'do_build' task! Thats exactly the reason why 
> 'build' is not a good name, because it describes everything and nothing 
> and now developers are ensnared by its name to put everything in it.
> And you agree that one big task that rules the world is just very bad 
> design. Every task should be very simple and do just one thing.
> 
> About the optional task inserted into the generic pipeline: I don't 
> really see the benefit. I currently tend to prefer them to be separated 
> and I see different arguments on both sides. My current view of those 
> packages where the 'DEBIAN' directory is created on the fly are that 
> they aren't clean packages. The 'right' way to do this is to have 
> debianized sources or a patch that adds the right 'DEBIAN' directory to 
> the sources. This here is just a useful shortcut for debianizing the 
> sources.

I missed the context here that this thread is about building the 
packages without the debianized source and your 'do_build' is about 
creating packages from debian source packages.

Sorry for this confusion.

Claudius

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de