From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6460145511220379648 X-Received: by 10.46.33.202 with SMTP id h71mr748708lji.3.1505119373623; Mon, 11 Sep 2017 01:42:53 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 10.46.27.27 with SMTP id b27ls224367ljb.8.gmail; Mon, 11 Sep 2017 01:42:53 -0700 (PDT) X-Google-Smtp-Source: AOwi7QCBFv3wRlHvZOIRZRev7CVv0dAB2vVn969Tj2e35pUMRvgptziKZaoJJporkqE+0ULIxj7b X-Received: by 10.25.163.210 with SMTP id m201mr751838lfe.42.1505119373349; Mon, 11 Sep 2017 01:42:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1505119373; cv=none; d=google.com; s=arc-20160816; b=zdM8mfdT7+PvQh58WA+SVsRoEh64nWxGdpVmAvhfviMTV7v4+LqCS8qu0RJ/QhuPaM NdGzsWCznrhCYR4x4keTTe3G26pU4LCdCEyJFKMi7BFwtexjeqU4PDJOXdWV172XpO/g AeFBj3/vxXNB9s5yTtuZ8z2BIGqTL+RSXGL4NNk40Oa/5PNe/bP1lXt9hcjvBgeWpVHJ U7OHPnncHJlfF8Wljvd58bJGbAINsfqJstSNb66u9WU8jz5d4eWcdHxlfhWIroGP+2rP UNZsrwHTaICKJvenBCaEYcbrSEsPx9eeAJATliOSR2nmoVtjkTG81wsnjHnsT0JOTVLW LKJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:from:subject :arc-authentication-results; bh=kk3asjmXj+3ea0LAJ75Gq00hOf4Qzm8jYnoJIB3lPiY=; b=uVezw7wHW25bwF7FUoTNQoF+o2+l9u+tenPCKa0boy2m3yykDoGWGVitNYNLbUvdsi 8MyrAducITpkfC+48LI9gjAszWJwaAe1iv9rp5D7gh5HCYoA70+w6pTAUclOlGfiDFxI icbB6L/EuxD3tOfWapzQiGWI9hQ6719DiYuFToAJKjn0fK0F/KW4svjej3IyKEVGW9Za wBWRWXdxOtvBIspJVqU/GuVUmE36ZvsY9MpNkvd5hGkB0rIkUc0Fmp1gH64znw2k1dQH MDyaVsx3YJJPyC3YY+GhMpFUGMHplLi3QdF3ZC60L+PGpuQ19GPY00TZuKgoQRwi+DKV hqzg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 200si696250wmj.0.2017.09.11.01.42.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Sep 2017 01:42:53 -0700 (PDT) Received-SPF: neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 192.35.17.2 is neither permitted nor denied by best guess record for domain of claudius.heine.ext@siemens.com) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v8B8gqjS017223 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Sep 2017 10:42:52 +0200 Received: from [139.25.68.223] (linux-ses-ext02.ppmd.siemens.net [139.25.68.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id v8B8gq93026029; Mon, 11 Sep 2017 10:42:52 +0200 Subject: Re: [PATCH 5/6] meta/dpkg: add dpkg-custom class From: Claudius Heine To: Alexander Smirnov , isar-users@googlegroups.com References: <356cb2c3f7dfead49d75580fdff10dfa8c41232e.1504119538.git.henning.schild@siemens.com> <303e4092-fb88-3115-b770-44dc7cdc2420@siemens.com> Message-ID: Date: Mon, 11 Sep 2017 10:42:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <303e4092-fb88-3115-b770-44dc7cdc2420@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: YUg3+asHfQ1+ Hi again, On 09/11/2017 10:13 AM, Claudius Heine wrote: >> If I got this correctly, the difference from dpkg-debian flow is that >> you generate 'debian' folder on the fly. So: >> >> 1. Why we need another do_deb_package, while do_build from dpkg class >> does the same? > > Why not? 'do_build' is a very bad name, because it not really describes > anything specific and if you have multiple tasks with good names like > 'deb_package' (while I still would prefer 'package_deb') that do just > one job each, then its much easier to recognize the tasks when calling > 'bitbake -c liststasks ..' and its simpler to extend the pipeline in > each recipe as needed. >> 2. Can we just add optional task to generic pipeline which generates >> debian folder? Or make it as a part of do_build: if [ ! -d ${D}/debian >> ]; then blablabla. > > No, please not part of the 'do_build' task! Thats exactly the reason why > 'build' is not a good name, because it describes everything and nothing > and now developers are ensnared by its name to put everything in it. > And you agree that one big task that rules the world is just very bad > design. Every task should be very simple and do just one thing. > > About the optional task inserted into the generic pipeline: I don't > really see the benefit. I currently tend to prefer them to be separated > and I see different arguments on both sides. My current view of those > packages where the 'DEBIAN' directory is created on the fly are that > they aren't clean packages. The 'right' way to do this is to have > debianized sources or a patch that adds the right 'DEBIAN' directory to > the sources. This here is just a useful shortcut for debianizing the > sources. I missed the context here that this thread is about building the packages without the debianized source and your 'do_build' is about creating packages from debian source packages. Sorry for this confusion. Claudius -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-54 Fax: (+49)-8142-66989-80 Email: ch@denx.de