Re: [PATCH] image: include image name in the kernel/initrd image copies

[chombourger@gmail.com]

[-- Attachment #1.1: Type: text/plain, Size: 1424 bytes --]


Hi Jan,

See below

On Thursday, October 18, 2018 at 11:27:10 AM UTC+2, Jan Kiszka wrote:
>
> On 18.10.18 11:04, Cedric Hombourger wrote: 
> > The kernel and initrd images are really image-specific (especially the 
> later 
> > with the initrd being created/updated as packages get installed into the 
> root 
> > file-system). Make sure we retain a per-image copy of these images in 
> the 
>
> I don't buy this argument yet: Which additional parameters besides the and 
> the 
> MACHINE make kernel different?


An image recipe may pull a different kernel than the default kernel 
proposed by the MACHINE or DISTRO
There are several ways: locally setting KERNEL_NAME, IMAGE_INSTALL_remove 
games, etc.

This is obviously a less frequent use-case than the initrd which is 
evidently populated based on hooks/scripts installed into your root 
file-system (and therefore image dependent)
 

> If there is any, can't we associate that 
> variation more directly with the image then? It's surely not the image 
> recipe name. 
>
>
Would you have a suggestion (based on the extra info I provided above)?

A possibly cleaner solution would be to NOT copy these files 
into DEPLOY_DIR_IMAGE in the first place! and have e.g. wic plugins extract 
the kernel/initrd images from the rootfs they are working with
I am happy to rework this patch if breaking the API (by removing 
KERNEL_IMAGE and INITRD_IMAGE) is an option

Cedric
 

[-- Attachment #1.2: Type: text/html, Size: 1932 bytes --]