From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6613620343774904320 Date: Thu, 18 Oct 2018 02:46:00 -0700 (PDT) From: chombourger@gmail.com To: isar-users Message-Id: In-Reply-To: <578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com> References: <1539853468-156-1-git-send-email-Cedric_Hombourger@mentor.com> <578d4e7b-292e-3795-08d7-041c9abe80ee@siemens.com> Subject: Re: [PATCH] image: include image name in the kernel/initrd image copies MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3060_186816843.1539855960446" X-Google-Token: ENisod4FO_sqOv_3Sn00 X-Google-IP: 192.94.31.2 X-TUID: 0anFkh7S+806 ------=_Part_3060_186816843.1539855960446 Content-Type: multipart/alternative; boundary="----=_Part_3061_740019785.1539855960446" ------=_Part_3061_740019785.1539855960446 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jan, See below On Thursday, October 18, 2018 at 11:27:10 AM UTC+2, Jan Kiszka wrote: > > On 18.10.18 11:04, Cedric Hombourger wrote: > > The kernel and initrd images are really image-specific (especially the > later > > with the initrd being created/updated as packages get installed into the > root > > file-system). Make sure we retain a per-image copy of these images in > the > > I don't buy this argument yet: Which additional parameters besides the and > the > MACHINE make kernel different? An image recipe may pull a different kernel than the default kernel proposed by the MACHINE or DISTRO There are several ways: locally setting KERNEL_NAME, IMAGE_INSTALL_remove games, etc. This is obviously a less frequent use-case than the initrd which is evidently populated based on hooks/scripts installed into your root file-system (and therefore image dependent) > If there is any, can't we associate that > variation more directly with the image then? It's surely not the image > recipe name. > > Would you have a suggestion (based on the extra info I provided above)? A possibly cleaner solution would be to NOT copy these files into DEPLOY_DIR_IMAGE in the first place! and have e.g. wic plugins extract the kernel/initrd images from the rootfs they are working with I am happy to rework this patch if breaking the API (by removing KERNEL_IMAGE and INITRD_IMAGE) is an option Cedric ------=_Part_3061_740019785.1539855960446 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Hi Jan,

See below

On = Thursday, October 18, 2018 at 11:27:10 AM UTC+2, Jan Kiszka wrote:On 18.10.18 11:04, Cedric Hombourger wr= ote:
> The kernel and initrd images are really image-specific (especially= the later
> with the initrd being created/updated as packages get installed in= to the root
> file-system). Make sure we retain a per-image copy of these images= in the

I don't buy this argument yet: Which additional parameters besides = the and the=20
MACHINE make kernel different?

An = image recipe may pull a different kernel than the default kernel proposed b= y the MACHINE or DISTRO
There are several ways: locally setting K= ERNEL_NAME, IMAGE_INSTALL_remove games, etc.

This = is obviously a less frequent use-case than the initrd which is evidently po= pulated based on hooks/scripts installed into your root file-system (and th= erefore image dependent)
=C2=A0
If there is any, can't we associate that=20
variation more directly with the image then? It's surely not the im= age recipe name.


Would you have a suggestion (based on = the extra info I provided above)?

A possibly clean= er solution would be to NOT copy these files into=C2=A0DEPLOY_DIR_IMAGE in = the first place! and have e.g. wic plugins extract the kernel/initrd images= from the rootfs they are working with
I am happy to rework this = patch if breaking the API (by removing KERNEL_IMAGE and INITRD_IMAGE) is an= option

Cedric
=C2=A0
------=_Part_3061_740019785.1539855960446-- ------=_Part_3060_186816843.1539855960446--