From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6664521764891000832 X-Received: by 2002:a2e:5bc9:: with SMTP id m70mr434549lje.18.1552406595844; Tue, 12 Mar 2019 09:03:15 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:7408:: with SMTP id v8ls157744lfe.9.gmail; Tue, 12 Mar 2019 09:03:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqzgRGCMNs30tklbprKyFUcQGlMcg0kacYfC5IKYMfYjGfPyIrEM1G74tW36K7nYhtXxFu6i X-Received: by 2002:ac2:5632:: with SMTP id b18mr794751lff.5.1552406595103; Tue, 12 Mar 2019 09:03:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1552406595; cv=none; d=google.com; s=arc-20160816; b=pXvHg+4TIajz13p2o1CF+jfKZwW9+tS6I6Eh+4ri5fPqlOKHvxtNN0fosQoLrSOCyr 0WbYbeYKQO1pc+EerZaNk4YyqGPW41wYlSvvgwX8MVtIq5O7nNelZUEfuEzLxo6siKhd qJKPkiZdheO7liHvAtdG6UIGbLSMk0gEJ1qOdRg+q+uGrHC0/Spj3TLwrKRsyjnrngZn JRgpG8Y12WKMp+ogc/v9mXeHINIX99+QMeG95Z6o7IxjPc55Eb9QyjLvAc2KYLsP/HMG BbPNC1gJHerteEyLB/hpcvRMhK9cg0SxNaT41rmEZQTRTYNucHFgztFz3b8V/ZYWfOnL rYyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject; bh=wg2ZOJjnyl4RCXJRZpXWXZtVO065zgvH/xOsOJa/XbE=; b=OVBoEaPvm/PeqciioPs5omBkhYeqr/REzDp7DuZwfhAue9K6EodBja3+5LIbjifPef /fIhIcPNng1nDGHm4/OzmyTkzcrl/ADbtbgLFe9oSHEf8cbbzj2JJDG04xGrhTZOXkz+ lwuprrdiP8UQ/tAE1y5x7WlKkQLLn8ARhovIj6A6NJbG9JhpTPt1Z0W2SqoBf59UDVw5 YYIFjuf8zJQ1it8DII8YR7c4YF77ECZPJikz7B9uV70hv05leav3fbuFThgaxiynFVHr cs8KcBxnfChet1yX2Z/LaPJAiZVl1FGcr0iYitZk4TJSW4q6skcLymyrsYAGzQi4NUc0 Scbw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id y13si360972lfg.4.2019.03.12.09.03.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Mar 2019 09:03:15 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x2CG3Csb022931 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Mar 2019 17:03:12 +0100 Received: from [167.87.52.219] ([167.87.52.219]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x2CG3Bw6030387; Tue, 12 Mar 2019 17:03:12 +0100 Subject: Re: [PATCH v4 0/6] Python refactoring To: Claudius Heine , isar-users@googlegroups.com Cc: Claudius Heine References: <20190304130801.20628-1-claudius.heine.ext@siemens.com> <9ca8abb2-3f3c-747a-f3dc-19a0a2eb8b41@siemens.com> <961f1436-d453-48db-4519-81ab1ca0b42e@siemens.com> From: Jan Kiszka Message-ID: Date: Tue, 12 Mar 2019 17:03:11 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <961f1436-d453-48db-4519-81ab1ca0b42e@siemens.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TUID: UhAbYrRLxQCI On 12.03.19 16:34, Claudius Heine wrote: > On 12/03/2019 16.26, Jan Kiszka wrote: >> On 12.03.19 15:56, [ext] Claudius Heine wrote: >>> This should probaly also be part of the isar release. It should fix >>> those 'ResourceWarning: unclosed file <_io.BufferedReader name=32>' >>> bitbake warnings. >> >> Which of the commits should fix that, and why? Remains non-obvious to me. > > The first one 'Remove all uses of subprocess.call(shell=True)'. > > The usage of 'Popen' requires that the process handler should be closed, which > was not done in isar-bootstrap-helper.bbclass. The right solution is either not > use Popen (which this patch changes) or use Popen with a context manager (which > I have done in the template.bbclass). > Ah, ok. Should be in the commit log then. These warnings were pretty annoying. Jan >> >> But I don't disagree that fixes, even minor ones, should be part of the >> release. There are way more fixes pending, let's give Maxim some time. > > I just wanted to give the additional information here, because that could have > been missed. > > Claudius > >> >> Jan >> >>> >>> On Mon, 2019-03-04 at 14:07 +0100, [ext] claudius.heine.ext@siemens.com >>> wrote: >>>> From: Claudius Heine >>>> >>>> Hi, >>>> >>>> I just took Haralds patchset + Maxims rebase and fixed it up. >>>> >>>> There was just a tiny change necessary, I added that in an additional >>>> patch. >>>> It builds on my machine (qemuamd64) and I am currently testing it on >>>> isar-ci. >>>> >>>> If that is successful and review is ok, my patch can be merged into >>>> the >>>> 'Remove all uses of subprocess.call(shell=True)' or left separately. >>>> >>>> regards, >>>> Claudius >>>> >>>> Claudius Heine (1): >>>>    isar-bootstrap-helper: get_deb_host_arch: fix decoding >>>> >>>> Harald Seiler (5): >>>>    Remove all uses of subprocess.call(shell=True) >>>>    Use modern python formatting >>>>    image: Remove recursion in get_image_name >>>>    wic: Refactor fakeroot script >>>>    Fix python style >>>> >>>>   .../example-module/example-module.bb          |  8 ++- >>>>   meta/classes/base.bbclass                     | 70 ++++++++++++----- >>>> -- >>>>   meta/classes/image.bbclass                    | 22 ++++-- >>>>   meta/classes/isar-bootstrap-helper.bbclass    |  8 +-- >>>>   meta/classes/isar-events.bbclass              | 14 ++-- >>>>   meta/classes/patch.bbclass                    | 13 ++-- >>>>   meta/classes/wic-img.bbclass                  | 21 ++++-- >>>>   .../isar-bootstrap/isar-bootstrap-host.bb     |  9 ++- >>>>   .../isar-bootstrap/isar-bootstrap-target.bb   |  5 +- >>>>   .../isar-bootstrap/isar-bootstrap.inc         | 12 ++-- >>>>   scripts/wic_fakeroot                          |  9 +-- >>>>   11 files changed, 120 insertions(+), 71 deletions(-) >>>> >>>> -- >>>> 2.20.1 >>>> >>> >> > -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux