From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6522139533803257856 X-Received: by 10.28.184.88 with SMTP id i85mr319261wmf.22.1518554981214; Tue, 13 Feb 2018 12:49:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 10.28.202.2 with SMTP id a2ls1806646wmg.4.gmail; Tue, 13 Feb 2018 12:49:40 -0800 (PST) X-Google-Smtp-Source: AH8x224E+8Y0kLtvGEuhD7/J18Tsfe1o8snEi8eUQUCQHNmCPE50OgVdGIcHqGyhThEd1z+SF5TR X-Received: by 10.28.231.9 with SMTP id e9mr313785wmh.12.1518554980654; Tue, 13 Feb 2018 12:49:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1518554980; cv=none; d=google.com; s=arc-20160816; b=0oSb267yyfobyoYukFUN0q6cyYp8WQngLnO5wob+5bH/HajZaBPKMEVu/tXSkrMjOg z/XwRYXzMXpB8/XXnizyKRWZVpQnOv1/XnIIrqDcGZdXXvWjA1geXtYnbzioB8GntVe7 wEJymx37AozM9Eixm7q2L+hcGBRqhAEIhCTdnyZt7ZkETuwF79XxmerwKplFjHVd2wtE tU+UEjKkSHtexdm4+1yoPinEXNcQo6IFiNjpMU0uPxXtpFw57nmrKMG75i7KL8wPyn1q qe9sTNqphf8CXMz9MWksmFzRzfMD68yRckdDII/5xS2R06pl7bazzN+R9vzeuAWRBr3U Mvbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :arc-authentication-results; bh=oeqWCliOG10UVVMR8WpWhMiKcIPXRFxe+q6dEYnRt3s=; b=M7iZU2XtpXyiIz74bX1oLxW7tpJjIvg8iZPj/eXb/ExEqm/2pCJ5/HS5UE1jlfpeLZ wOuNvnwx41E6T1c/PZa/Bwngi2Ea7yggXGC1omZ9W74mhKdvweBfArssmCDKeX1MEC1w 2gqjD6oHFSz+uJG2S+/smbbA9b3PDIiw95C1pF50qw3uVP65sKPa/uDpsm2rsRlgBOf3 m5kzkTEI8T68odGyRdM/88hCjPTGDQ74lsgMVCk8GK0jV1ZujmdlTuhsuGDf//nso5AR CFRW9DZdz4MiMTpNa22gABndF7T0q9uNQBrk5RijnxeaP24AG5U3dKBDIDuIkoc0D7hA FG3w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id s81si551310wmd.2.2018.02.13.12.49.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Feb 2018 12:49:40 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id w1DKne1B010050 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Feb 2018 21:49:40 +0100 Received: from [139.25.68.37] (md1q0hnc.ad001.siemens.net [139.25.68.37] (may be forged)) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id w1DKne1c005528; Tue, 13 Feb 2018 21:49:40 +0100 Subject: Re: [PATCH] [RFC] buildchroot: Fix do_setup_mounts To: Alexander Smirnov , isar-users@googlegroups.com References: <20180213203202.4161-1-asmirnov@ilbers.de> From: Jan Kiszka Message-ID: Date: Tue, 13 Feb 2018 21:49:39 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <20180213203202.4161-1-asmirnov@ilbers.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TUID: UG5SCKbjhv6b On 2018-02-13 21:32, Alexander Smirnov wrote: > Fix this function to work correctly for re-running builds. > > Signed-off-by: Alexander Smirnov > --- > meta/recipes-devtools/buildchroot/buildchroot.bb | 20 ++++++++------------ > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb b/meta/recipes-devtools/buildchroot/buildchroot.bb > index 570c0ad..d25b549 100644 > --- a/meta/recipes-devtools/buildchroot/buildchroot.bb > +++ b/meta/recipes-devtools/buildchroot/buildchroot.bb > @@ -74,20 +74,16 @@ do_build() { > do_cleanup_mounts > } > > -# Invalidate stamp for do_setup_mounts before each build start. > -# This will guarantee that this function will be executed once > -# per build. > -python __anonymous() { > - stamp = d.getVar("STAMP") + ".do_setup_mounts." + d.getVarFlag("do_setup_mounts", 'stamp-extra-info') > - os.remove(stamp) if os.path.exists(stamp) else None > -} > - > -do_setup_mounts[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > +do_setup_mounts[nostamp] = "1" > +do_setup_mounts[lockfiles] = "${WORKDIR}/isar.lock" > > do_setup_mounts() { > - sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt > - sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev > - sudo mount -t proc none ${BUILDCHROOT_DIR}/proc > + grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts || \ > + sudo mount --bind ${DEPLOY_DIR_APT}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt > + grep -q ${BUILDCHROOT_DIR}/dev /proc/mounts || \ > + sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev > + grep -q ${BUILDCHROOT_DIR}/proc /proc/mounts || \ > + sudo mount -t proc none ${BUILDCHROOT_DIR}/proc > } > > addtask setup_mounts after do_build > NACK. I've tried that (nostamp), but that breaks the dependency due to recurring execution of this task which every one depends upon. Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux