* [PATCH] tar: remove duplicated compressing
@ 2022-05-16 14:57 Anton Mikanovich
2022-05-18 12:23 ` Schmidt, Adriaan
2022-05-23 14:27 ` Anton Mikanovich
0 siblings, 2 replies; 3+ messages in thread
From: Anton Mikanovich @ 2022-05-16 14:57 UTC (permalink / raw)
To: isar-users; +Cc: adriaan.schmidt, Anton Mikanovich
If using -z option in IMAGE_CMD_tar call archive will be gzipped and
then gzipped again after direct gzip run. This will result in wrong
double-gzipped output file for tar.gz. So remove -z to have correct
output image.
Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
---
meta/classes/imagetypes.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/imagetypes.bbclass b/meta/classes/imagetypes.bbclass
index 2838c96..bea5af5 100644
--- a/meta/classes/imagetypes.bbclass
+++ b/meta/classes/imagetypes.bbclass
@@ -8,7 +8,7 @@ IMAGER_INSTALL_tar = "tar"
TAR_OPTIIONS ?= ""
IMAGE_CMD_tar() {
- ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvzf \
+ ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvf \
${IMAGE_FILE_CHROOT} --one-file-system -C ${PP_ROOTFS} .
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] tar: remove duplicated compressing
2022-05-16 14:57 [PATCH] tar: remove duplicated compressing Anton Mikanovich
@ 2022-05-18 12:23 ` Schmidt, Adriaan
2022-05-23 14:27 ` Anton Mikanovich
1 sibling, 0 replies; 3+ messages in thread
From: Schmidt, Adriaan @ 2022-05-18 12:23 UTC (permalink / raw)
To: Anton Mikanovich, isar-users
Anton Mikanovic, 16. Mai 2022 16:58:
> If using -z option in IMAGE_CMD_tar call archive will be gzipped and
> then gzipped again after direct gzip run. This will result in wrong
> double-gzipped output file for tar.gz. So remove -z to have correct
> output image.
Nice catch! Yes, this is of course a bug.
Thanks,
Adriaan
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta/classes/imagetypes.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/imagetypes.bbclass
> b/meta/classes/imagetypes.bbclass
> index 2838c96..bea5af5 100644
> --- a/meta/classes/imagetypes.bbclass
> +++ b/meta/classes/imagetypes.bbclass
> @@ -8,7 +8,7 @@ IMAGER_INSTALL_tar = "tar"
> TAR_OPTIIONS ?= ""
>
> IMAGE_CMD_tar() {
> - ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvzf \
> + ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvf \
> ${IMAGE_FILE_CHROOT} --one-file-system -C ${PP_ROOTFS} .
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tar: remove duplicated compressing
2022-05-16 14:57 [PATCH] tar: remove duplicated compressing Anton Mikanovich
2022-05-18 12:23 ` Schmidt, Adriaan
@ 2022-05-23 14:27 ` Anton Mikanovich
1 sibling, 0 replies; 3+ messages in thread
From: Anton Mikanovich @ 2022-05-23 14:27 UTC (permalink / raw)
To: isar-users; +Cc: adriaan.schmidt
16.05.2022 17:57, Anton Mikanovich wrote:
> If using -z option in IMAGE_CMD_tar call archive will be gzipped and
> then gzipped again after direct gzip run. This will result in wrong
> double-gzipped output file for tar.gz. So remove -z to have correct
> output image.
>
> Signed-off-by: Anton Mikanovich <amikan@ilbers.de>
> ---
> meta/classes/imagetypes.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/imagetypes.bbclass b/meta/classes/imagetypes.bbclass
> index 2838c96..bea5af5 100644
> --- a/meta/classes/imagetypes.bbclass
> +++ b/meta/classes/imagetypes.bbclass
> @@ -8,7 +8,7 @@ IMAGER_INSTALL_tar = "tar"
> TAR_OPTIIONS ?= ""
>
> IMAGE_CMD_tar() {
> - ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvzf \
> + ${SUDO_CHROOT} tar ${TAR_OPTIONS} -cvf \
> ${IMAGE_FILE_CHROOT} --one-file-system -C ${PP_ROOTFS} .
> }
>
Applied to next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-23 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-16 14:57 [PATCH] tar: remove duplicated compressing Anton Mikanovich
2022-05-18 12:23 ` Schmidt, Adriaan
2022-05-23 14:27 ` Anton Mikanovich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox