From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 7044234567900725248 X-Received: by 2002:a5d:6c6b:: with SMTP id r11mr35145192wrz.548.1641194383123; Sun, 02 Jan 2022 23:19:43 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a05:600c:5111:: with SMTP id o17ls3257157wms.1.canary-gmail; Sun, 02 Jan 2022 23:19:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJxP7qjYe3ZAhYDLfQHabmQ8cs25oC0iKHO46pjHuMWd+8vnT4Rojo9NRN+fOuwPkb4c1hLr X-Received: by 2002:a7b:c341:: with SMTP id l1mr39195525wmj.60.1641194382101; Sun, 02 Jan 2022 23:19:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1641194382; cv=pass; d=google.com; s=arc-20160816; b=UusRyBb7XyClVm+/3aVOnvLCkk2l8VtlvUCfl+xt3fpQUmrtaX+HNfcngQZL3VJdbI Wog3OrqGTSZWB4oOKUKmelJ5l3xuMePp/BbdMSSDaulmBYhCaFNK1edvF8cXzpSp46tq StZ6cyYtANNvP/+UNay658AgVFFLZLbRqKHEr/kNN3eorIPwghRJ2HKaS5u0AKCOlYMg YEXfZEhJtNj0KVxBzP7G4r1GfkoT8nP0YYxy4DVbNAovjD4oD48kJD4nU+uNoqxgf0WR 1r/MX9e0TxEbkwLHEHZw7f6d2jOZ1k8q0iVavVX9EAts4tuYuusLkKhQpKeAh5B4/fl6 Y02g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :dkim-signature; bh=zgWBkj2d1uMqixaweRkMd0+5LddSGkZL3tjWqinZYbk=; b=potwzMqcfnYdf5MF7jm1PUj/bOJ6/DI8qHy0n70yH3b4DoPx4w7urxSEijHz7t+1FA rHTKalUaQ08wjC15VWNeFCJ+wmiS1BS8YDINby5G0UnTJ4If138DG2qLdHZtaoucl8eF uibEB94JVPK1l56NSQyy9DmNwkq1uRvfYF/S/HyP0JWPHztTx3PU+uVPdh3XzhrQsXWY zaMzl0WMIwMEZqjS/CLSun2h49fXZtLzL8bcT/5Vpkc9amh0Um2rGufAHWOMmiyFnb86 vmX+Ug1+5FtEv189yRYLRzJt/BpPKzaISmk4fzXkHUIxSOFvdrjG4nStwXYR321HWi/1 rphg== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=iuX5Cbtd; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.73 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70073.outbound.protection.outlook.com. [40.107.7.73]) by gmr-mx.google.com with ESMTPS id i12si1911478wml.2.2022.01.02.23.19.41 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Jan 2022 23:19:42 -0800 (PST) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.73 as permitted sender) client-ip=40.107.7.73; Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@siemens.com header.s=selector2 header.b=iuX5Cbtd; arc=pass (i=1 spf=pass spfdomain=siemens.com dmarc=pass fromdomain=siemens.com); spf=pass (google.com: domain of jan.kiszka@siemens.com designates 40.107.7.73 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRdY8qvrWamkxrfZJg9KHMoXbeP8MKfA/GvQXxJDCOoj/stKH1MzrryFLSp3tLhroH0fkO5Gf+pkLto0FhbU7qPNifbK84tCHPfj0OOliAAK5uvhEcWjf7DD59WOSsCwkULROCH/LlDmUoiuYXVH2XMXY0sV0wOsDkSthxp459qrSN67HBR8AvJTpHTa7ezx7SWjTYfjppZQ20IMV0IFEMzByndPeuVAk0sQglxEgZSfVBhwa8aBB0QqNckd1gW+GpNkVE1ilnjHHfigFhARtyN+ZqG2PUG75TYNxy2LxHWtomqUPtKI9A9hykGcmK9pNpHW00oMWVPoKs0JXHrERw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zgWBkj2d1uMqixaweRkMd0+5LddSGkZL3tjWqinZYbk=; b=LdAAEmxAckozMn6UYjSYv5x2Z7S3SM3RoExZyaDrMfpeFUuD12xkU8dBEtcOYWf4Os8O1jc1EJwiEKZanPd2Zu2NGL+Cu/q8ullQKBpwy3bAbmuwFBiB3Ctaab+9UhpkmRBXXltahP52lIVV3ch5Gzx6fBah+AQWvNIfg/J3z5k/KngCiDhubRh0fqp5nOxY4+HzUaItLiN5FZVARv+OMI33/78/CQ64EonL5l1RXL5xJN5XKBGjBaDrsVN1E+32QQC5J0xND92cwK8OFRGOthpj1Q0/jbeQENxUBnxxpLlNBFc6ln0u7MdSYK4epj2M3PidDm4X7Q0hW/4EkCau9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 194.138.21.70) smtp.rcpttodomain=gmail.com smtp.mailfrom=siemens.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=siemens.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=siemens.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zgWBkj2d1uMqixaweRkMd0+5LddSGkZL3tjWqinZYbk=; b=iuX5CbtdXclJyXNrYFAVfqDVC/8fmYBJytZN3FXtJDXSZ0sVJCR4z0FHTPMUEiaf0Z4VSi0b/eFTKVY04cvmgL0twgY1lu2PKAAMgXIKqAaCz5UmBhgKNj4v4XHXPGUbsspy7wrVKT0nv6k4karsd3a9kV/kALuf48UGZc0I+lY8Sbb/8vc8sB1+HWFCJ9Y5HdtVEByN/pR1MZJn+gNuGjcZa7UPzTmLPaa2YK+Q30+5udqpdNkmIVJeA6P1BnBBxHB6udvW401JEoc2YgiLiq0DYPWztETkQ8MArHnWshDJ6bq/L1/y1hZCk/EqZCZZDBBba346JM3vC1nNJHH+kQ== Received: from SV0P279CA0008.NORP279.PROD.OUTLOOK.COM (2603:10a6:f10:11::13) by AM0PR10MB3666.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:15b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Mon, 3 Jan 2022 07:19:41 +0000 Received: from HE1EUR01FT013.eop-EUR01.prod.protection.outlook.com (2603:10a6:f10:11:cafe::bc) by SV0P279CA0008.outlook.office365.com (2603:10a6:f10:11::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14 via Frontend Transport; Mon, 3 Jan 2022 07:19:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 194.138.21.70) smtp.mailfrom=siemens.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=siemens.com; Received-SPF: Pass (protection.outlook.com: domain of siemens.com designates 194.138.21.70 as permitted sender) receiver=protection.outlook.com; client-ip=194.138.21.70; helo=hybrid.siemens.com; Received: from hybrid.siemens.com (194.138.21.70) by HE1EUR01FT013.mail.protection.outlook.com (10.152.0.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4844.14 via Frontend Transport; Mon, 3 Jan 2022 07:19:40 +0000 Received: from DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) by DEMCHDC9SJA.ad011.siemens.net (194.138.21.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 3 Jan 2022 08:19:40 +0100 Received: from [167.87.0.57] (167.87.0.57) by DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Mon, 3 Jan 2022 08:19:39 +0100 Message-ID: Date: Mon, 3 Jan 2022 08:19:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 1/1] add support for debian build profiles Content-Language: en-US To: "Moessbauer, Felix (T RDA IOT SES-DE)" , vijai kumar CC: isar-users References: <20211221190653.1142246-1-felix.moessbauer@siemens.com> From: Jan Kiszka In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: jan.kiszka@siemens.com X-Originating-IP: [167.87.0.57] X-ClientProxiedBy: DEMCHDC89YA.ad011.siemens.net (139.25.226.104) To DEMCHDC8A0A.ad011.siemens.net (139.25.226.106) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cc9736be-f927-4a45-1fb1-08d9ce89687d X-MS-TrafficTypeDiagnostic: AM0PR10MB3666:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bElXzahUUdT8hsW8Ksyo/MEQJ2i69vAD7oeSwy+FHEidHEmB6qwCMVuPY486X3ZUW44H5j5TYu1Xfh5rxV9mRdV68rMdK+mxFU9396girbMvDZCuGyYdwNfiR/INQkAkVp31M8ZWPN7mXHHLKASIoV7DbXD8rDMXwK2zZJuhLDHzy50zA3ApchSc/WjqimX5QgtljRU/LwIJZsSCgp4OfaVBo6wyrpOwbJNLTsJJRHrD5src9kOV7zxcumjPnTwVWAq3i5RbGWFXQ6e0yKki8Uj6qcus3dqitSRpccgJak31x6H0mvHbIZVn5tOoAufPq+ro9Z2wQH8jFGMT0hJSK9/OYuOgo9mu9Rzv+ZybhPpc+WjBRStPtS22v7glukB/lXX7zeh1kXG6oXc6um8AaTJrcexs8G5AvwIkjlgxn6hTRvbAslYhd4lNNHST7tLK0F5kvtnW55wdzXhkxE1Vif/a5F0kGe4/hBXyRobQMNnU3H30prvTyg66Nj/gZIrg5J2d5sZh/NaNf6TCRp7UMz8COFlrXREZw33UJZqmvdKS945T6R6NZlo74r/ZBhBcNyg+YZHShQssum+WjfXhgPD3MuihyIKz4ueJBstAShTX95EqV2XfleAkDdLw3F0QAflQYlgOVHU7aUGer40FJqShuBTdolDrs05D7e14BgR0XZRptzq+xLSzq1R6lJqZK6XZSiz9OUYH0LhKBbyO4UD7rfTNOPfuKgv3NmOeXNEb0JU3n2MEBJlqKKouDUzWEWsi5Tr5XGtsR2EJ0JNIYh3ZKArJ6v36X0DtNQhqwFXvgY6DtIXYrg/mCyJd2gSJrJLsM0l3ZCEZvUbyyPSsOQ== X-Forefront-Antispam-Report: CIP:194.138.21.70;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:hybrid.siemens.com;PTR:hybrid.siemens.com;CAT:NONE;SFS:(4636009)(40470700002)(36840700001)(46966006)(110136005)(70586007)(82310400004)(47076005)(4326008)(8936002)(82960400001)(53546011)(31696002)(70206006)(36860700001)(2616005)(31686004)(5660300002)(956004)(44832011)(16576012)(336012)(36756003)(16526019)(6706004)(8676002)(7596003)(83380400001)(356005)(508600001)(40460700001)(26005)(316002)(186003)(7636003)(2906002)(86362001)(3940600001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: siemens.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2022 07:19:40.7570 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc9736be-f927-4a45-1fb1-08d9ce89687d X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=38ae3bcd-9579-4fd4-adda-b42e1495d55a;Ip=[194.138.21.70];Helo=[hybrid.siemens.com] X-MS-Exchange-CrossTenant-AuthSource: HE1EUR01FT013.eop-EUR01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3666 X-TUID: 4CRhIb+CZx6n On 31.12.21 12:23, Moessbauer, Felix (T RDA IOT SES-DE) wrote: >>> diff --git a/meta/classes/dpkg-base.bbclass >>> b/meta/classes/dpkg-base.bbclass index 6704385b..c1588528 100644 >>> --- a/meta/classes/dpkg-base.bbclass >>> +++ b/meta/classes/dpkg-base.bbclass >>> @@ -13,6 +13,8 @@ inherit deb-dl-dir >>> DEPENDS ?= "" >>> >>> DEPENDS_append_riscv64 = "${@' crossbuild-essential-riscv64' if >> d.getVar('ISAR_CROSS_COMPILE', True) == '1' and d.getVar('PN') != 'crossbuild- >> essential-riscv64' else ''}" >>> +DEB_BUILD_PROFILES ?= "" >>> +DEB_BUILD_PROFILES_CROSS ?= "cross" >> >> Do we really need two variables? Is the DEB_BUILD_PROFILES not sufficient? > > Well... I implemented this patch series while working on a layer that has to support both arm64 and x64. > With just one variable the inline python functions became a pattern because (depending on the package), various profiles had to be activated only for arm64 (e.g. like "nocheck", "nodoc"). > That's why I prefer to have both variables. > Is there any strong reason against it (apart from having two variables to maintain)? > The central pattern to append "cross" to DEB_BUILD_PROFILES if cross-compiling makes sense. I just wonder if making that "cross" appendix configurable via a variable is actually necessary. Also, that var name is confusing, may suggest that DEB_BUILD_PROFILES_CROSS is used alternatively to DEB_BUILD_PROFILES if cross-compiling. Jan -- Siemens AG, T RDA IOT Corporate Competence Center Embedded Linux