From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6729358150130991104 X-Received: by 2002:a50:f285:: with SMTP id f5mr16926213edm.109.1566800795047; Sun, 25 Aug 2019 23:26:35 -0700 (PDT) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:8599:: with SMTP id v25ls5106180ejx.5.gmail; Sun, 25 Aug 2019 23:26:34 -0700 (PDT) X-Google-Smtp-Source: APXvYqySOkQ2Av0FTnFNhBUNcYfGOY9AJlrAhGaHWpDAIweXnlOA6nYp78SiCBC+WqKg+J8eqIgt X-Received: by 2002:a17:906:a954:: with SMTP id hh20mr15201313ejb.196.1566800794590; Sun, 25 Aug 2019 23:26:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1566800794; cv=none; d=google.com; s=arc-20160816; b=TjhP6TYdDB3Y1UEHh2zsDWh+233i06m+1s7wQiRZrh8yGowISCwwM72mcQjOAaLRbZ zpUY6tCquqCKdlS38Bg17apndNA4JxwZsPd6PXdlr6nL+hrI0w4rEuqfklllOr/NZqfI sUtPhiSxv893vWpUx0mr2tKUJybt1NAnoYc3ocHibP8gqql7HtDykUtLKuXTsBk4MWDr G2T58eby6BOF39dvVCtPpeGTQEi60CGL+VcePwPk13tlhcO8fUGJM4pkqrNBEhS+LxZf 6XE/P+cGZnbuJArV84alrl+fpiSlGsKWa3iqKdM9ZIdftYxUVy9E0au6u6qDvE+51qPo nLOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:references:in-reply-to:message-id:date :subject:to:from; bh=Aw55qR0hha0TB+OwFrl4aE1tENi+dTo2q7x0jCEllg4=; b=ElBaSTT7xLemPa5KUasPzmwqgeMKvbsMs2dZxjVPjK99ONOsgcJg0yPBxdbBdL8vXN c/qC1awg6qc4DmRXMIeFxbOdumzHJRBJVdI1AcdX09Ya+Hr8+DJCfJzhnKxqefZ186zG Yd4No6kekDNwuKGCrg0d4o0kbFzbsENl9VqoWfAG4iWSawSeBnQYTM3HojVlBYZOkOx2 2TyS+ldtTIv4jkRJVqXfDYVve7kDRZulmZNykqVp3WggZUvyVu/NOj+4OvP9DUiH5ybz cik31KU9sK0aP377IIPH0JfBdP7ss3vBtlhW+cwaaJcBMovH5ewkkq0cfXDywjppadeY pBkw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id m29si630769edb.3.2019.08.25.23.26.34 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Aug 2019 23:26:34 -0700 (PDT) Received-SPF: pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jan.kiszka@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=jan.kiszka@siemens.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x7Q6QYMu025203 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Aug 2019 08:26:34 +0200 Received: from md1f2u6c.ad001.siemens.net ([139.22.35.99]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x7Q6QRHI015165 for ; Mon, 26 Aug 2019 08:26:33 +0200 From: Jan Kiszka To: isar-users Subject: [PATCH 24/26] Detect false sharing of recipes Date: Mon, 26 Aug 2019 08:26:25 +0200 Message-Id: X-Mailer: git-send-email 2.16.4 In-Reply-To: References: In-Reply-To: References: X-TUID: v1M+zqELQt59 From: Jan Kiszka When a task is run more than once per build, this indicates a bug, usually (though not only) related to incorrect multiconfig use. Such bugs are hard to find in practice, so they could benefit from some tooling. This adds a very simple but effective check for such re-run scenarios by putting a "once." stamp file into each workdir during a build. If such a file already exists, an error is thrown. The workdirs are purged after the parsing phase on the beginning of each build so that no false positives are raised. Signed-off-by: Jan Kiszka --- meta/classes/isar-events.bbclass | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/meta/classes/isar-events.bbclass b/meta/classes/isar-events.bbclass index 62eb25d..1335356 100644 --- a/meta/classes/isar-events.bbclass +++ b/meta/classes/isar-events.bbclass @@ -4,6 +4,28 @@ # Copyright (C) 2015-2017 ilbers GmbH # Copyright (c) Siemens AG, 2018 +addhandler parse_completed + +python parse_completed() { + bb.utils.remove(d.getVar('TMPDIR') + "/work/*/*/*/temp/once.*") +} +parse_completed[eventmask] = "bb.event.ParseCompleted" + +addhandler task_started + +python task_started() { + task = d.getVar('BB_RUNTASK') + try: + f = open("%s/once.%s" % (d.getVar('T'), task), "x") + f.close() + except FileExistsError: + bb.error("Detect multiple executions of %s in %s" % + (task, d.getVar('WORKDIR'))) + bb.error("Rerun a clean build with empty STAMPCLEAN " \ + "and compare the sigdata files") +} +task_started[eventmask] = "bb.build.TaskStarted" + addhandler build_completed python build_completed() { -- 2.16.4